Sign upLogin

michielbdejong/solid-ui

View on GitHub
Star

Showing 337 of 337 total issues

Identical blocks of code found in 3 locations. Consider refactoring.
Open

const UI = {
  authn: require('../authn/authn'),
  icons: require('../iconBase'),
  log: require('../log'),
  ns: require('../ns'),
Severity: Major
Found in src/chat/bookmarks.js and 2 other locations - About 3 hrs to fix
src/chat/message.js on lines 4..16
src/chat/messageTools.js on lines 10..22

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

const UI = {
  authn: require('../authn/authn'),
  icons: require('../iconBase'),
  log: require('../log'),
  ns: require('../ns'),
Severity: Major
Found in src/chat/messageTools.js and 2 other locations - About 3 hrs to fix
src/chat/bookmarks.js on lines 3..15
src/chat/message.js on lines 4..16

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 3 locations. Consider refactoring.
Open

const UI = {
  authn: require('../authn/authn'),
  icons: require('../iconBase'),
  log: require('../log'),
  ns: require('../ns'),
Severity: Major
Found in src/chat/message.js and 2 other locations - About 3 hrs to fix
src/chat/bookmarks.js on lines 3..15
src/chat/messageTools.js on lines 10..22

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 106.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function Column has 85 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  function Column () {
    this.useCount = 0

    // Have we checked any values for this column yet?
Severity: Major
Found in src/table.js - About 3 hrs to fix

    Function renderItem has 85 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function renderItem (object) {
    async function deleteThisItem () {
      if (ordered) {
        console.log('pre delete: ' + debugString(list.elements))
        for (let i = 0; i < list.elements.length; i++) {
    Severity: Major
    Found in src/widgets/forms.js - About 3 hrs to fix

      Function getACLorDefault has 85 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function getACLorDefault (
  doc: $rdf.NamedNode,
  callbackFunction: (
    a: boolean,
    b: boolean,
      Severity: Major
      Found in src/acl/acl.ts - About 3 hrs to fix

        Function loginStatusBox has 83 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export function loginStatusBox (
  dom: HTMLDocument,
  listener: ((uri: string | null) => void) | null = null,
  options: {
    buttonStyle?: string
        Severity: Major
        Found in src/authn/authn.ts - About 3 hrs to fix

          Function wrapper has 82 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          var wrapper = function () {
  var logger = {}

  // ///////////////////////  Logging
  //
          Severity: Major
          Found in src/log.js - About 3 hrs to fix

            Function ensureOneTypeIndex has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
            Open

            async function ensureOneTypeIndex (context: AuthenticationContext, isPublic: boolean): Promise<AuthenticationContext | void> {
  async function makeIndexIfNecessary (context, isPublic) {
    const relevant = isPublic ? context.publicProfile : context.preferencesFile
    const visibility = isPublic ? 'public' : 'private'
            Severity: Minor
            Found in src/authn/authn.ts - About 3 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function onChange has 79 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              var onChange = function (_e) {
    select.disabled = true // until data written back - gives user feedback too
    var ds = []
    var is = []
    var removeValue = function (t) {
            Severity: Major
            Found in src/widgets/forms.js - About 3 hrs to fix

              Function makeDescription has 79 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              forms.makeDescription = function (
  dom,
  kb,
  subject,
  predicate,
              Severity: Major
              Found in src/widgets/forms.js - About 3 hrs to fix

                Function registrationControl has 78 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                export function registrationControl (
  context: AuthenticationContext,
  instance,
  klass
): Promise<AuthenticationContext | void> {
                Severity: Major
                Found in src/authn/authn.ts - About 3 hrs to fix

                  Function sameACL has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
                  Open

                  export function sameACL (a: AgentMapMap, b: AgentMapMap): boolean {
  const contains = function (a, b) {
    for (const pred in {
      agent: true,
      agentClass: true,
                  Severity: Minor
                  Found in src/acl/acl.ts - About 3 hrs to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function label has 77 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function label (x, initialCap) {
  // x is an object
  function doCap (s) {
    // s = s.toString()
    if (initialCap) return s.slice(0, 1).toUpperCase() + s.slice(1)
                  Severity: Major
                  Found in src/utils.js - About 3 hrs to fix

                    Function renderMessage has 75 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      var renderMessage = function (bindings, fresh) {
    var creator = bindings['?creator']
    var message = bindings['?msg']
    var date = bindings['?date']
    var content = bindings['?content']
                    Severity: Major
                    Found in src/chat/thread.js - About 3 hrs to fix

                      Function renderMessage has 75 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        var renderMessage = function (bindings, fresh) {
    var creator = bindings['?creator']
    var message = bindings['?msg']
    var date = bindings['?date']
    var content = bindings['?content']
                      Severity: Major
                      Found in src/messageArea.js - About 3 hrs to fix

                        Function logInLoadPreferences has 73 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                        export function logInLoadPreferences (context: AuthenticationContext): Promise<AuthenticationContext> {
  if (context.preferencesFile) return Promise.resolve(context) // already done

  const statusArea = context.statusArea || context.div || null
  let progressDisplay
                        Severity: Major
                        Found in src/authn/authn.ts - About 2 hrs to fix

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                          var UI = {
  authn: require('./authn/authn'),
  icons: require('./iconBase'),
  log: require('./log'),
  ns: require('./ns'),
                          Severity: Major
                          Found in src/messageArea.js and 1 other location - About 2 hrs to fix
                          src/chat/thread.js on lines 4..14

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 93.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Open

                          var UI = {
  authn: require('../authn/authn'),
  icons: require('../iconBase'),
  log: require('../log'),
  ns: require('../ns'),
                          Severity: Major
                          Found in src/chat/thread.js and 1 other location - About 2 hrs to fix
                          src/messageArea.js on lines 4..14

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 93.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Function updateStore has 71 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              var updateStore = function (part) {
      var chunk = part.subject
      setPartStyle(part, undefined, true)
      var old = kb.any(chunk, ns.sioc('content')).value
      var del = [$rdf.st(chunk, ns.sioc('content'), old, padDoc)]
                          Severity: Major
                          Found in src/pad.js - About 2 hrs to fix
                            Severity
                            Category
                            Status
                            Source
                            Language