Sign upLogin

micro-toolkit/zmq-service-suite-broker-js

View on GitHub
Star

Showing 18 of 20 total issues

Function ServiceManagementInterface has 113 lines of code (exceeds 25 allowed). Consider refactoring.
Open

var ServiceManagementInterface = function(configuration){

  var log = Logger.getLogger('SMI');

  var defaults = {
Severity: Major
Found in lib/smi.js - About 4 hrs to fix

    Function exports has 106 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function(grunt) {

  grunt.initConfig({
    pkg: grunt.file.readJSON('package.json'),
    Severity: Major
    Found in Gruntfile.js - About 4 hrs to fix

      Function Backend has 106 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      var Backend = function(configuration, smiService){
  var instance;

  var log = Logger.getLogger('Backend');
      Severity: Major
      Found in lib/backend.js - About 4 hrs to fix

        Function Backend has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
        Open

        var Backend = function(configuration, smiService){
  var instance;

  var log = Logger.getLogger('Backend');
        Severity: Minor
        Found in lib/backend.js - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function Frontend has 79 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        var Frontend = function(configuration, smiService){
  var instance;

  var log = Logger.getLogger('Frontend');
        Severity: Major
        Found in lib/frontend.js - About 3 hrs to fix

          Function ServiceManagementInterface has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
          Open

          var ServiceManagementInterface = function(configuration){

  var log = Logger.getLogger('SMI');

  var defaults = {
          Severity: Minor
          Found in lib/smi.js - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            var replyError = function(errorCode, message){
    var error = errors[errorCode.toString()];

    message.status = error.code;
    message.payload = error.body;
          Severity: Major
          Found in lib/frontend.js and 1 other location - About 1 hr to fix
          lib/backend.js on lines 74..81

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 69.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

            var replyError = function(errorCode, message){
    var error = errors[errorCode.toString()];

    message.status = error.code;
    message.payload = error.body;
          Severity: Major
          Found in lib/backend.js and 1 other location - About 1 hr to fix
          lib/frontend.js on lines 65..72

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 69.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function Broker has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          var Broker = function(configuration, smiService, frontend, backend){
  var defaults = {
    frontend: 'tcp://127.0.0.1:5560',
    backend: 'tcp://127.0.0.1:5559',
    smi: {
          Severity: Minor
          Found in lib/broker.js - About 1 hr to fix

            Function onMessage has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              var onMessage = function(){

    var msg;
    var frames = _.toArray(arguments);
            Severity: Minor
            Found in lib/frontend.js - About 1 hr to fix

              Function RoundRobinStrategy has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              var RoundRobinStrategy = function(){

  // store key:index
  var state = { };
              Severity: Minor
              Found in lib/round_robin_strategy.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function Frontend has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

              var Frontend = function(configuration, smiService){
  var instance;

  var log = Logger.getLogger('Frontend');
              Severity: Minor
              Found in lib/frontend.js - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              TODO found
              Open

                    // TODO: log frames in debug mode
              Severity: Minor
              Found in lib/frontend.js by fixme

              TODO found
              Open

                  // TODO: log frames in debug mode
              Severity: Minor
              Found in lib/frontend.js by fixme

              TODO found
              Open

                  // TODO: log frames in debug mode
              Severity: Minor
              Found in lib/backend.js by fixme

              TODO found
              Open

                  // TODO: log frames in debug mode
              Severity: Minor
              Found in lib/backend.js by fixme

              TODO found
              Open

                  // TODO: log frames in debug mode
              Severity: Minor
              Found in lib/frontend.js by fixme

              TODO found
              Open

                  // TODO: log frames in debug mode
              Severity: Minor
              Found in lib/backend.js by fixme
              Severity
              Category
              Status
              Source
              Language