Sign upLogin

microting/eform-sdk-dotnet

View on GitHub
Star

Showing 3,203 of 3,219 total issues

Method Core_SiteWorkers_Advanced_SiteWorkerRead_ReadsSiteWorker has 79 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        [Test]
        public async Task Core_SiteWorkers_Advanced_SiteWorkerRead_ReadsSiteWorker()
        {
            // Arrange
Severity: Major
Found in eFormSDK.Integration.CheckLists.CoreTests/CoreTestAdvanced.cs - About 3 hrs to fix

    Method Core_Case_CaseRead_ReadsCase has 79 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            [Test]
        public async Task Core_Case_CaseRead_ReadsCase()
        {
            // Arrange
            #region Arrance
    Severity: Major
    Found in eFormSDK.Integration.Tests/CoreTestCase.cs - About 3 hrs to fix

      Method XmlToClass has 79 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              public Response XmlToClass(string xmlStr)
        {
            try
            {
                ResponseTypes rType = ResponseTypes.Invalid;
      Severity: Major
      Found in eFormCore/Infrastructure/Models/reply/Response.cs - About 3 hrs to fix

        Method InsertPicture has 79 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                public static void InsertPicture(List<string> values, WordprocessingDocument wordDoc,
            Paragraph paragraph = null)
        {
            MainDocumentPart mainPart = wordDoc.MainDocumentPart;
            ImagePart imagePart = mainPart.AddImagePart(ImagePartType.Jpeg);
        Severity: Major
        Found in eFormCore/Helpers/ReportHelper.cs - About 3 hrs to fix

          Method OptionTranslation_Delete_DoesDelete has 79 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  [Test]
        public async Task OptionTranslation_Delete_DoesDelete()
        {
            //Arrange
          Severity: Major
          Found in eFormSDK.InSight.Tests/OptionTranslationUTest.cs - About 3 hrs to fix

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                        migrationBuilder.CreateTable(
                name: "LogExceptions",
                columns: table => new
                {
                    Id = table.Column<int>(type: "int", nullable: false)
            Severity: Major
            Found in eFormCore/Migrations/20201223104631_AddingTranslations.cs and 2 other locations - About 3 hrs to fix
            eFormCore/Migrations/20201222125152_HugheTableRenaming.cs on lines 1369..1383
            eFormCore/Migrations/20201223104631_AddingTranslations.cs on lines 376..390

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 219.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                        migrationBuilder.CreateTable(
                name: "Logs",
                columns: table => new
                {
                    Id = table.Column<int>(type: "int", nullable: false)
            Severity: Major
            Found in eFormCore/Migrations/20201223104631_AddingTranslations.cs and 2 other locations - About 3 hrs to fix
            eFormCore/Migrations/20201222125152_HugheTableRenaming.cs on lines 1369..1383
            eFormCore/Migrations/20201223104631_AddingTranslations.cs on lines 360..374

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 219.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 3 locations. Consider refactoring.
            Open

                        migrationBuilder.CreateTable(
                name: "log_exceptions",
                columns: table => new
                {
                    Id = table.Column<int>(type: "int", nullable: false)
            Severity: Major
            Found in eFormCore/Migrations/20201222125152_HugheTableRenaming.cs and 2 other locations - About 3 hrs to fix
            eFormCore/Migrations/20201223104631_AddingTranslations.cs on lines 360..374
            eFormCore/Migrations/20201223104631_AddingTranslations.cs on lines 376..390

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 219.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method Core_eForm_SimpleCommenteFormCreateInDB_ReturnseFormId has 78 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    [Test] // Core_Template_TemplateFromXml_ReturnsTemplate()
        public async Task Core_eForm_SimpleCommenteFormCreateInDB_ReturnseFormId()
        {
            // Arrange
            string xmlstring = @"
            Severity: Major
            Found in eFormSDK.Integration.CheckLists.CoreTests/CoreTesteFormCreateInDB.cs - About 3 hrs to fix

              Method TemplateSetTags has a Cognitive Complexity of 37 (exceeds 20 allowed). Consider refactoring.
              Open

                      public async Task<bool> TemplateSetTags(int templateId, List<int> tagIds)
        {
            string methodName = "SqlController.TemplateSetTags";
            try
            {
              Severity: Minor
              Found in eFormCore/Infrastructure/SqlController.cs - About 3 hrs to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method Core_eFormSimpleTextSingleLineFormCreateInDB_ReturnseFormId has 77 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      [Test] // Text
        public async Task Core_eFormSimpleTextSingleLineFormCreateInDB_ReturnseFormId()
        {
            string xmlstring = @"
                <?xml version='1.0' encoding='UTF-8'?>
              Severity: Major
              Found in eFormSDK.Integration.CheckLists.CoreTests/CoreTesteFormCreateInDB.cs - About 3 hrs to fix

                Method Core_eFormSimpleTextMultiLineFormCreateInDB_ReturnseFormId has 77 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        [Test] // Comment
        public async Task Core_eFormSimpleTextMultiLineFormCreateInDB_ReturnseFormId()
        {
            string xmlstring = @"
                <?xml version='1.0' encoding='UTF-8'?>
                Severity: Major
                Found in eFormSDK.Integration.CheckLists.CoreTests/CoreTesteFormCreateInDB.cs - About 3 hrs to fix

                  Method CreateDataElement has 77 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          private async Task CreateDataElement(int parentId, DataElement dataElement, Language language)
        {
            string methodName = "SqlController.CreateDataElement";
            try
            {
                  Severity: Major
                  Found in eFormCore/Infrastructure/SqlController.cs - About 3 hrs to fix

                    Method Questions_Create_DoesCreate has 77 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            [Test]
        public async Task Questions_Create_DoesCreate()
        {
            //Arrange
                    Severity: Major
                    Found in eFormSDK.InSight.Tests/QuestionsUTest.cs - About 3 hrs to fix

                      Method Options_Update_DoesUpdate has 77 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                              [Test]
        public async Task Options_Update_DoesUpdate()
        {
            Random rnd = new Random();
                      Severity: Major
                      Found in eFormSDK.InSight.Tests/OptionsUTest.cs - About 3 hrs to fix

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                                        if (xmlStr.Contains("<Value type="))
                {
                    string subXmlStr = t.Locate(xmlStr, "<Response>", "</Response>").Trim();
                    string valueTypeLower =
                        t.Locate(xmlStr, "Value type=\"", "\"").Trim().ToLower(); //digs out value's type
                        Severity: Major
                        Found in eFormCore/Infrastructure/Models/reply/Response.cs and 1 other location - About 3 hrs to fix
                        eFormCore/Infrastructure/Models/reply/Response.cs on lines 166..199

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 213.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            public class EntitySearch : DataItem
    {
        // con
        internal EntitySearch()
        {
                        Severity: Major
                        Found in eFormCore/Infrastructure/Models/DataItem.cs and 1 other location - About 3 hrs to fix
                        eFormCore/Infrastructure/Models/DataItem.cs on lines 505..545

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 213.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Identical blocks of code found in 2 locations. Consider refactoring.
                        Open

                                        if (xmlStr.Contains("<Value type="))
                {
                    string subXmlStr = t.Locate(xmlStr, "<Response>", "</Response>").Trim();
                    string valueTypeLower =
                        t.Locate(xmlStr, "Value type=\"", "\"").Trim().ToLower(); //digs out value's type
                        Severity: Major
                        Found in eFormCore/Infrastructure/Models/reply/Response.cs and 1 other location - About 3 hrs to fix
                        eFormCore/Infrastructure/Models/reply/Response.cs on lines 75..108

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 213.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                            public class Text : DataItem
    {
        internal Text()
        {
        }
                        Severity: Major
                        Found in eFormCore/Infrastructure/Models/DataItem.cs and 1 other location - About 3 hrs to fix
                        eFormCore/Infrastructure/Models/DataItem.cs on lines 577..620

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 213.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Method Taggins_Create_DoesCreate has 76 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                                [Test]
        public async Task Taggins_Create_DoesCreate()
        {
            Random rnd = new Random();
                        Severity: Major
                        Found in eFormSDK.Base.Tests/TagginsUTest.cs - About 3 hrs to fix
                          Severity
                          Category
                          Status
                          Source
                          Language