Showing 3,203 of 3,219 total issues
Method question_Update_DoesUpdate_BackButtonEnabledImageTrue has 74 lines of code (exceeds 25 allowed). Consider refactoring. Open
[Test]
public async Task question_Update_DoesUpdate_BackButtonEnabledImageTrue()
{
// Arrange
string name = Guid.NewGuid().ToString();Method question_Update_DoesUpdate_PrioritisedImageTrue_QSFalse has 74 lines of code (exceeds 25 allowed). Consider refactoring. Open
[Test]
public async Task question_Update_DoesUpdate_PrioritisedImageTrue_QSFalse()
{
// Arrange
string name = Guid.NewGuid().ToString();Method question_Update_DoesUpdate_AllTrue has 74 lines of code (exceeds 25 allowed). Consider refactoring. Open
[Test]
public async Task question_Update_DoesUpdate_AllTrue()
{
// Arrange
string name = Guid.NewGuid().ToString();Method question_Update_DoesUpdate_BackButtonEnabledTrue has 74 lines of code (exceeds 25 allowed). Consider refactoring. Open
[Test]
public async Task question_Update_DoesUpdate_BackButtonEnabledTrue()
{
// Arrange
string name = Guid.NewGuid().ToString();Method question_Update_DoesUpdate_PrioritisedValidDisplayTrue has 74 lines of code (exceeds 25 allowed). Consider refactoring. Open
[Test]
public async Task question_Update_DoesUpdate_PrioritisedValidDisplayTrue()
{
// Arrange
string name = Guid.NewGuid().ToString();Method question_Update_DoesUpdate_ValidDisplayBackButtonEnabledImageTrue has 74 lines of code (exceeds 25 allowed). Consider refactoring. Open
[Test]
public async Task question_Update_DoesUpdate_ValidDisplayBackButtonEnabledImageTrue()
{
// Arrange
string name = Guid.NewGuid().ToString();Method question_Update_DoesUpdate_ValidDisplayTrue_QSFalse has 74 lines of code (exceeds 25 allowed). Consider refactoring. Open
[Test]
public async Task question_Update_DoesUpdate_ValidDisplayTrue_QSFalse()
{
// Arrange
string name = Guid.NewGuid().ToString();Method question_Update_DoesUpdate_ValidDisplayBackButtonEnabledImageTrue_QSFalse has 74 lines of code (exceeds 25 allowed). Consider refactoring. Open
[Test]
public async Task question_Update_DoesUpdate_ValidDisplayBackButtonEnabledImageTrue_QSFalse()
{
// Arrange
string name = Guid.NewGuid().ToString();Method question_Update_DoesUpdate_PrioritisedTrue has 74 lines of code (exceeds 25 allowed). Consider refactoring. Open
[Test]
public async Task question_Update_DoesUpdate_PrioritisedTrue()
{
// Arrange
string name = Guid.NewGuid().ToString();Method question_Update_DoesUpdate_PrioritisedImageTrue has 74 lines of code (exceeds 25 allowed). Consider refactoring. Open
[Test]
public async Task question_Update_DoesUpdate_PrioritisedImageTrue()
{
// Arrange
string name = Guid.NewGuid().ToString();Method question_Update_DoesUpdate_PrioritisedBackButtonEnabledTrue has 74 lines of code (exceeds 25 allowed). Consider refactoring. Open
[Test]
public async Task question_Update_DoesUpdate_PrioritisedBackButtonEnabledTrue()
{
// Arrange
string name = Guid.NewGuid().ToString();Method question_Update_DoesUpdate_ValidDisplayImageTrue has 74 lines of code (exceeds 25 allowed). Consider refactoring. Open
[Test]
public async Task question_Update_DoesUpdate_ValidDisplayImageTrue()
{
// Arrange
string name = Guid.NewGuid().ToString();Method question_Update_DoesUpdate_PrioritisedValidDisplayBackButtonEnabledTrue has 74 lines of code (exceeds 25 allowed). Consider refactoring. Open
[Test]
public async Task question_Update_DoesUpdate_PrioritisedValidDisplayBackButtonEnabledTrue()
{
// Arrange
string name = Guid.NewGuid().ToString();Method question_Update_DoesUpdate_ImageTrue_QSFalse has 74 lines of code (exceeds 25 allowed). Consider refactoring. Open
[Test]
public async Task question_Update_DoesUpdate_ImageTrue_QSFalse()
{
// Arrange
string name = Guid.NewGuid().ToString();Method question_Update_DoesUpdate_BackButtonEnabledTrue_QSFalse has 74 lines of code (exceeds 25 allowed). Consider refactoring. Open
[Test]
public async Task question_Update_DoesUpdate_BackButtonEnabledTrue_QSFalse()
{
// Arrange
string name = Guid.NewGuid().ToString();Method question_Update_DoesUpdate_ValidDisplayImageTrue_QSFalse has 74 lines of code (exceeds 25 allowed). Consider refactoring. Open
[Test]
public async Task question_Update_DoesUpdate_ValidDisplayImageTrue_QSFalse()
{
// Arrange
string name = Guid.NewGuid().ToString();Method SaveResult has 74 lines of code (exceeds 25 allowed). Consider refactoring. Open
private async Task<int> SaveResult(Response resp, string respXml, MicrotingDbContext dbContext,
int microtingUid, int? checkIdLastKnown, CaseDto aCase)
{
XmlDocument xDoc = new XmlDocument();
Similar blocks of code found in 2 locations. Consider refactoring. Open
if (!db.FieldValues.Any(x =>
x.FieldId == dbField.Id
&& x.CaseId == theCase.Id
&& x.WorkflowState != Constants.Constants.WorkflowStates.Removed))
{- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 206.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
if (!db.FieldValues.Any(x =>
x.FieldId == subDbField.Id
&& x.CaseId == theCase.Id
&& x.WorkflowState != Constants.Constants.WorkflowStates.Removed))
{- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 206.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Method Core_Unit_Advanced_UnitRead_ReadsUnit has 73 lines of code (exceeds 25 allowed). Consider refactoring. Open
[Test]
public async Task Core_Unit_Advanced_UnitRead_ReadsUnit()
{
// Arrange
// #region Checklist