Showing 3,203 of 3,219 total issues
Method Core_Tags_TemplateSetTags_DoesAssignTagToTemplate
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
[Test]
public async Task Core_Tags_TemplateSetTags_DoesAssignTagToTemplate()
{
// Arrance
CheckList cl1 = new CheckList
Method CaseReadFull
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
public async Task<Case> CaseReadFull(int microtingUId, int checkUId)
{
string methodName = "SqlController.CaseReadFull";
try
{
Method UnitGetAll
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
public async Task<List<UnitDto>> UnitGetAll()
{
string methodName = "SqlController.UnitGetAll";
try
{
Method EntityGroupUpdate
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
public async Task<bool> EntityGroupUpdate(string entityType, string name, int id, string entityGroupMuId)
{
_log.LogEverything("Communicator.EntityGroupUpdate", "called");
_log.LogVariable("Communicator.EntityGroupUpdate", nameof(entityType), entityType);
_log.LogVariable("Communicator.EntityGroupUpdate", nameof(name), name);
Method MapVersions
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
private QuestionVersion MapVersions(Question question)
{
return new QuestionVersion
{
QuestionSetId = question.QuestionSetId,
Method TemplateFromJson
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
public MainElement TemplateFromJson(string json)
{
if (string.IsNullOrEmpty(json))
throw new ArgumentNullException("json cannot be null or empty");
string methodName = "Core.TemplateFromXml";
Method Advanced_UnitRequestOtp
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
public async Task<UnitDto> Advanced_UnitRequestOtp(int microtingUid)
{
string methodName = "Core.Advanced_UnitRequestOtp";
try
{
Method Core_Case_CaseLookupMUId_Returns_ReturnCase
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
[Test]
public async Task Core_Case_CaseLookupMUId_Returns_ReturnCase()
{
// Arrance
Method Core_Case_CaseLookupCaseUId_Returns_lstDto
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
[Test]
public async Task Core_Case_CaseLookupCaseUId_Returns_lstDto()
{
// Arrance
Method Core_Case_CaseLookupCaseId_Returns_cDto
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
[Test]
public async Task Core_Case_CaseLookupCaseId_Returns_cDto()
{
// Arrance
Method Core_Case_CaseReadFirstId
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
[Test]
public async Task Core_Case_CaseReadFirstId()
{
// Arrance
Method Core_Case_CaseReadByCaseId_Returns_cDto
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
[Test]
public async Task Core_Case_CaseReadByCaseId_Returns_cDto()
{
// Arrance
Method EntityGroupRead
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
public async Task<EntityGroup> EntityGroupRead(string entityGroupMuId, string sort, string nameFilter)
{
string methodName = "Core.EntityGroupRead";
if (string.IsNullOrEmpty(entityGroupMuId))
throw new ArgumentNullException(nameof(entityGroupMuId));
Method Advanced_TemplateUpdateFieldIdsForColumns
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
public async Task<bool> Advanced_TemplateUpdateFieldIdsForColumns(int templateId, int? fieldId1, int? fieldId2,
int? fieldId3, int? fieldId4, int? fieldId5, int? fieldId6, int? fieldId7, int? fieldId8, int? fieldId9,
int? fieldId10)
{
string methodName = "Core.Advanced_TemplateUpdateFieldIdsForColumns";
Method GetFileFromS3Storage
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
public async Task<GetObjectResponse> GetFileFromS3Storage(string fileName, bool isRetry = false)
{
try
{
GetObjectRequest request = new GetObjectRequest
Method EntityItemDelete
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
public async Task EntityItemDelete(int id)
{
EntityItem et = await _sqlController.EntityItemRead(id);
if (et == null)
{
Similar blocks of code found in 6 locations. Consider refactoring. Open
answers answer = new answers
{
SiteId = site1.Id,
QuestionSetId = questionSet.Id,
SurveyConfigurationId = surveyConfiguration.Id,
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 93.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 6 locations. Consider refactoring. Open
answers answer = new answers
{
SiteId = site1.Id,
QuestionSetId = questionSet.Id,
SurveyConfigurationId = surveyConfiguration.Id,
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 93.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
Option option = new Option
{
Question = question,
Weight = rnd.Next(1, 255),
OptionIndex = rnd.Next(1, 255),
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 93.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
Option option = new Option
{
Question = question,
Weight = rnd.Next(1, 255),
OptionIndex = rnd.Next(1, 255),
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 93.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76