Sign upLogin

microting/eform-sdk-dotnet

View on GitHub
Star

Showing 3,203 of 3,219 total issues

Similar blocks of code found in 6 locations. Consider refactoring.
Open

            answers answer = new answers
            {
                SiteId = site1.Id,
                QuestionSetId = questionSet.Id,
                SurveyConfigurationId = surveyConfiguration.Id,
Severity: Major
Found in eFormSDK.Integration.Tests/SqlControllerTestAnswer.cs and 5 other locations - About 1 hr to fix
eFormSDK.Integration.Tests/SqlControllerTestAnswer.cs on lines 353..364
eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 107..118
eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 230..241
eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 290..301
eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 422..433

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            Answer answer = new Answer
            {
                AnswerDuration = rnd.Next(1, 255),
                FinishedAt = DateTime.UtcNow,
                LanguageId = language.Id,
Severity: Major
Found in eFormSDK.InSight.Tests/AnswerValuesUTest.cs and 1 other location - About 1 hr to fix
eFormSDK.InSight.Tests/AnswersUTest.cs on lines 359..370

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

            Answer answer = new Answer
            {
                AnswerDuration = rnd.Next(1, 255),
                FinishedAt = DateTime.UtcNow,
                LanguageId = language.Id,
Severity: Major
Found in eFormSDK.InSight.Tests/AnswersUTest.cs and 1 other location - About 1 hr to fix
eFormSDK.InSight.Tests/AnswerValuesUTest.cs on lines 271..282

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

            answers answer = new answers
            {
                SiteId = site1.Id,
                QuestionSetId = questionSet.Id,
                SurveyConfigurationId = surveyConfiguration.Id,
Severity: Major
Found in eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs and 5 other locations - About 1 hr to fix
eFormSDK.Integration.Tests/SqlControllerTestAnswer.cs on lines 105..116
eFormSDK.Integration.Tests/SqlControllerTestAnswer.cs on lines 353..364
eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 107..118
eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 230..241
eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 290..301

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

            answers answer = new answers
            {
                SiteId = site1.Id,
                QuestionSetId = questionSet.Id,
                SurveyConfigurationId = surveyConfiguration.Id,
Severity: Major
Found in eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs and 5 other locations - About 1 hr to fix
eFormSDK.Integration.Tests/SqlControllerTestAnswer.cs on lines 105..116
eFormSDK.Integration.Tests/SqlControllerTestAnswer.cs on lines 353..364
eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 230..241
eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 290..301
eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 422..433

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 6 locations. Consider refactoring.
Open

            answers answer2 = new answers
            {
                SiteId = site1.Id,
                QuestionSetId = questionSet.Id,
                SurveyConfigurationId = surveyConfiguration.Id,
Severity: Major
Found in eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs and 5 other locations - About 1 hr to fix
eFormSDK.Integration.Tests/SqlControllerTestAnswer.cs on lines 105..116
eFormSDK.Integration.Tests/SqlControllerTestAnswer.cs on lines 353..364
eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 107..118
eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 230..241
eFormSDK.Integration.Tests/SqlControllerTestAnswerValue.cs on lines 422..433

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 93.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method SQL_Worker_WorkerRead_ReadsWorker has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        [Test]
        public async Task SQL_Worker_WorkerRead_ReadsWorker()
        {
            // Arrance
Severity: Minor
Found in eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestWorker.cs - About 1 hr to fix

    Method SQL_Worker_WorkerUpdate_UpdatesWorker has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            [Test]
        public async Task SQL_Worker_WorkerUpdate_UpdatesWorker()
        {
            // Arrance
    Severity: Minor
    Found in eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestWorker.cs - About 1 hr to fix

      Method DoSetup has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              public override async Task DoSetup()
        {
            #region Setup SettingsTableContent

            DbContextHelper dbContextHelper = new DbContextHelper(ConnectionString);
      Severity: Minor
      Found in eFormSDK.Integration.CheckLists.CoreTests/CoreTesteFormCreateInDB.cs - About 1 hr to fix

        Method DoSetup has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                public override async Task DoSetup()
        {
            #region Setup SettingsTableContent

            DbContextHelper dbContextHelper = new DbContextHelper(ConnectionString);
        Severity: Minor
        Found in eFormSDK.Integration.CheckLists.CoreTests/CoreTesteFormQuickSyncXML.cs - About 1 hr to fix

          Method DoSetup has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  public override async Task DoSetup()
        {
            #region Setup SettingsTableContent

            DbContextHelper dbContextHelper = new DbContextHelper(ConnectionString);
          Severity: Minor
          Found in eFormSDK.Integration.CheckLists.CoreTests/CoreTesteFormFromXML.cs - About 1 hr to fix

            Method SQL_File_FileRead_doesFileRead has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    [Test]
        public async Task SQL_File_FileRead_doesFileRead()
        {
            UploadedData ud = new UploadedData
            {
            Severity: Minor
            Found in eFormSDK.Integration.Base.SqlControllerTests/SqlControllerTestUploadedData.cs - About 1 hr to fix

              Method DoSetup has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      public override async Task DoSetup()
        {
            #region Setup SettingsTableContent

            DbContextHelper dbContextHelper = new DbContextHelper(ConnectionString);
              Severity: Minor
              Found in eFormSDK.Integration.Base.CoreTests/CoreTestEntity.cs - About 1 hr to fix

                Method Core_Folders_DeleteFolder_DoesMarkFolderAsRemoved has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        [Test]
        public async Task Core_Folders_DeleteFolder_DoesMarkFolderAsRemoved()
        {
            // Arrange
                Severity: Minor
                Found in eFormSDK.Integration.Base.CoreTests/CoreTestFolders.cs - About 1 hr to fix

                  Method DoSetup has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          public override async Task DoSetup()
        {
            #region Setup SettingsTableContent

            DbContextHelper dbContextHelper = new DbContextHelper(ConnectionString);
                  Severity: Minor
                  Found in eFormSDK.Integration.Base.CoreTests/CoreTestTag.cs - About 1 hr to fix

                    Method DoSetup has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            public override async Task DoSetup()
        {
            #region Setup SettingsTableContent

            DbContextHelper dbContextHelper = new DbContextHelper(ConnectionString);
                    Severity: Minor
                    Found in eFormSDK.Integration.Base.CoreTests/CoreTestFolders.cs - About 1 hr to fix

                      Method DoSetup has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                              public override async Task DoSetup()
        {
            #region Setup SettingsTableContent

            _dbContextHelper = new DbContextHelper(ConnectionString);
                      Severity: Minor
                      Found in eFormSDK.Integration.Base.CoreTests/CoreTestSite.cs - About 1 hr to fix

                        Method Down has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                                protected override void Down(MigrationBuilder migrationBuilder)
        {
            migrationBuilder.DropPrimaryKey(
                name: "PK_site_survey_configurations",
                table: "site_survey_configurations");
                        Severity: Minor
                        Found in eFormCore/Migrations/20190318122928_FixingNamingOfSurveyConfigurationSites.cs - About 1 hr to fix

                          Method Down has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                                  protected override void Down(MigrationBuilder migrationBuilder)
        {
            migrationBuilder.DropForeignKey(
                name: "FK_cases_folders_FolderId",
                table: "cases");
                          Severity: Minor
                          Found in eFormCore/Migrations/20200513142551_AddingFolderIdToCasesAndCheckListSites.cs - About 1 hr to fix

                            Method Up has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                    protected override void Up(MigrationBuilder migrationBuilder)
        {
            migrationBuilder.AddColumn<int>(
                name: "MicrotingUid",
                table: "QuestionTranslationVersions",
                            Severity: Minor
                            Found in eFormCore/Migrations/20200120171433_AddingMicrotingUidToInSight.cs - About 1 hr to fix
                              Severity
                              Category
                              Status
                              Source
                              Language