Sign upLogin

milosmns/silly-android

View on GitHub
Star

Showing 55 of 92 total issues

Preconditions has 84 methods (exceeds 20 allowed). Consider refactoring.
Open

@SuppressWarnings({"unused", "WeakerAccess"})
public final class Preconditions {

    private Preconditions() {}
Severity: Major
Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Preconditions.java - About 1 day to fix

    File Preconditions.java has 560 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    package me.angrybyte.sillyandroid.extras;

/*
 * Copyright (C) 2007 The Guava Authors
 *
    Severity: Major
    Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Preconditions.java - About 1 day to fix

      File DialogManagerImpl.java has 351 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      package me.angrybyte.sillyandroid.dialogs;

import android.app.Dialog;
import android.os.Bundle;
import android.os.Parcel;
      Severity: Minor
      Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/dialogs/DialogManagerImpl.java - About 4 hrs to fix

        DialogManagerImpl has 24 methods (exceeds 20 allowed). Consider refactoring.
        Open

        public class DialogManagerImpl implements DialogManager {

    private static final String TAG = DialogManagerImpl.class.getSimpleName();

    static final class DialogInfo implements Parcelable {
        Severity: Minor
        Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/dialogs/DialogManagerImpl.java - About 2 hrs to fix

          File EasyFragment.java has 272 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          package me.angrybyte.sillyandroid.components;

import android.Manifest;
import android.annotation.TargetApi;
import android.app.Activity;
          Severity: Minor
          Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/components/EasyFragment.java - About 2 hrs to fix

            Method recreateFromConfigs has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
            Open

                private void recreateFromConfigs(@NonNull final Collection<DialogInfo> configs, boolean showNow) {
        clearAllMappings();
        for (DialogInfo iDialogInfo : configs) {
            if (!iDialogInfo.isFragment) {
                final Dialog created = createDialog(iDialogInfo.id, iDialogInfo.config);
            Severity: Minor
            Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/dialogs/DialogManagerImpl.java - About 2 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                    if (!shouldFade) {
            // no fading, add all applicable states
            states.addState(clickedStates, clickedState); // !
            states.addState(selectedStates, checkedState);
            states.addState(focusedStates, normalState);
            Severity: Major
            Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Coloring.java and 2 other locations - About 1 hr to fix
            sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Coloring.java on lines 560..577
            sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Coloring.java on lines 746..763

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 114.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                    if (!shouldFade) {
            // no fading, add all applicable states
            states.addState(clickedState, clickedDrawable); // !
            states.addState(selectedState, focusedDrawable); // reuse the focused drawable
            states.addState(focusedState, focusedDrawable);
            Severity: Major
            Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Coloring.java and 2 other locations - About 1 hr to fix
            sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Coloring.java on lines 746..763
            sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Coloring.java on lines 803..820

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 114.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 3 locations. Consider refactoring.
            Open

                    if (!shouldFade) {
            // no fading, add all applicable states
            states.addState(clickedState, clickedDrawable); // !
            states.addState(selectedState, focusedDrawable); // reuse the focused drawable
            states.addState(focusedState, focusedDrawable);
            Severity: Major
            Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Coloring.java and 2 other locations - About 1 hr to fix
            sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Coloring.java on lines 560..577
            sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Coloring.java on lines 803..820

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 114.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method onCreateView has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

                @Nullable
    @Override
    @CallSuper
    public View onCreateView(@NonNull final LayoutInflater inflater, @Nullable final ViewGroup container, @Nullable final Bundle savedInstanceState) {
        final Context fragmentContext = getContext();
            Severity: Minor
            Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/components/EasyFragment.java - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method onClick has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                @Override
    public void onClick(final View v) {
        super.onClick(v);
        switch (v.getId()) {
            case R.id.button_print_info: {
            Severity: Minor
            Found in demo/src/main/java/me/angrybyte/sillyandroid/demo/MainActivity.java - About 1 hr to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  @Nullable
    private DialogFragment createDialogFragment(final int dialogId, @Nullable final Bundle config) {
        if (mCallback == null) {
            Log.w(TAG, "Can't create a dialog fragment without the callback being set prior to this call");
            return null;
              Severity: Major
              Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/dialogs/DialogManagerImpl.java and 1 other location - About 1 hr to fix
              sillyandroid/src/main/java/me/angrybyte/sillyandroid/dialogs/DialogManagerImpl.java on lines 326..336

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 73.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  @Nullable
    private Dialog createDialog(final int dialogId, @Nullable final Bundle config) {
        if (mCallback == null) {
            Log.w(TAG, "Can't show a dialog without the callback being set prior to this call");
            return null;
              Severity: Major
              Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/dialogs/DialogManagerImpl.java and 1 other location - About 1 hr to fix
              sillyandroid/src/main/java/me/angrybyte/sillyandroid/dialogs/DialogManagerImpl.java on lines 338..348

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 73.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  private static String badPositionIndex(int index, int size, String desc) {
        if (index < 0) {
            return format("%s (%s) must not be negative", desc, index);
        } else if (size < 0) {
            throw new IllegalArgumentException("negative size: " + size);
              Severity: Minor
              Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Preconditions.java and 1 other location - About 50 mins to fix
              sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Preconditions.java on lines 1173..1181

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 60.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  private static String badElementIndex(int index, int size, String desc) {
        if (index < 0) {
            return format("%s (%s) must not be negative", desc, index);
        } else if (size < 0) {
            throw new IllegalArgumentException("negative size: " + size);
              Severity: Minor
              Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Preconditions.java and 1 other location - About 50 mins to fix
              sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Preconditions.java on lines 1218..1226

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 60.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Method checkNotNull has 6 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                          T obj,
            @Nullable String errorMessageTemplate,
            @Nullable Object p1,
            @Nullable Object p2,
            @Nullable Object p3,
              Severity: Minor
              Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Preconditions.java - About 45 mins to fix

                Method checkArgument has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                            boolean b,
            @Nullable String errorMessageTemplate,
            @Nullable Object p1,
            @Nullable Object p2,
            @Nullable Object p3,
                Severity: Minor
                Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Preconditions.java - About 45 mins to fix

                  Method checkState has 6 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                              boolean b,
            @Nullable String errorMessageTemplate,
            @Nullable Object p1,
            @Nullable Object p2,
            @Nullable Object p3,
                  Severity: Minor
                  Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Preconditions.java - About 45 mins to fix

                    Method createContrastStateDrawable has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public static StateListDrawable createContrastStateDrawable(@NonNull final Context context, @ColorInt final int normalColor, @ColorInt final int
            pressedBackColor,
                                                                final boolean shouldFade, @NonNull final Drawable original) {
                    Severity: Minor
                    Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Coloring.java - About 35 mins to fix

                      Method setPadding has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                          protected final void setPadding(@NonNull final View view, @Px final int start, @Px final int top, @Px final int end, @Px final int bottom) {
                      Severity: Minor
                      Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/components/EasyActivity.java - About 35 mins to fix
                        Severity
                        Category
                        Status
                        Source
                        Language