Sign upLogin

milosmns/silly-android

View on GitHub
Star
sillyandroid/src/main/java/me/angrybyte/sillyandroid/SillyAndroid.java

Summary

Maintainability
A
1 hr
Test Coverage

File SillyAndroid.java has 390 lines of code (exceeds 250 allowed). Consider refactoring.
Wontfix

package me.angrybyte.sillyandroid;

import android.Manifest;
import android.annotation.TargetApi;
import android.app.Activity;
Severity: Minor
Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/SillyAndroid.java - About 5 hrs to fix

    SillyAndroid has 39 methods (exceeds 20 allowed). Consider refactoring.
    Wontfix

    @SuppressWarnings("WeakerAccess")
public final class SillyAndroid {

    private static final String TAG = SillyAndroid.class.getSimpleName();
    Severity: Minor
    Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/SillyAndroid.java - About 5 hrs to fix

      Method listenToKeyboard has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Wontfix

          @NonNull
    public static ViewTreeObserver.OnGlobalLayoutListener listenToKeyboard(@NonNull final OnKeyboardChangeListener with, @NonNull final Activity context) {
        return new ViewTreeObserver.OnGlobalLayoutListener() {
            private boolean isKeyboardVisible;
      Severity: Minor
      Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/SillyAndroid.java - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method listenToKeyboard has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Invalid

          @NonNull
    public static ViewTreeObserver.OnGlobalLayoutListener listenToKeyboard(@NonNull final OnKeyboardChangeListener with, @NonNull final Activity context) {
        return new ViewTreeObserver.OnGlobalLayoutListener() {
            private boolean isKeyboardVisible;
      Severity: Minor
      Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/SillyAndroid.java - About 1 hr to fix

        Method setPadding has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            public static void setPadding(@NonNull final View view, @Px final int start, @Px final int top, @Px final int end, @Px final int bottom) {
        Severity: Minor
        Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/SillyAndroid.java - About 35 mins to fix

          Method close has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              public static boolean close(@Nullable final Closeable closeable) {
        if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN && closeable instanceof Cursor) {
            return close((Cursor) closeable);
        }
          Severity: Minor
          Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/SillyAndroid.java - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method onGlobalLayout has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

                      @Override
            public void onGlobalLayout() {
                final int statusBarHeight = UI.getStatusBarHeight(context);
                final int navigationBarHeight = UI.getNavigationBarHeight(context);
          Severity: Minor
          Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/SillyAndroid.java - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Wontfix

                  if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1) {
            view.setPaddingRelative(start, top, end, bottom);
        } else {
            view.setPadding(start, top, end, bottom);
        }
          Severity: Minor
          Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/SillyAndroid.java and 1 other location - About 40 mins to fix
          sillyandroid/src/main/java/me/angrybyte/sillyandroid/SillyAndroid.java on lines 358..362

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Wontfix

                  if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1) {
            view.setPaddingRelative(paddingStart, padding, paddingEnd, padding);
        } else {
            view.setPadding(paddingStart, padding, paddingEnd, padding);
        }
          Severity: Minor
          Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/SillyAndroid.java and 1 other location - About 40 mins to fix
          sillyandroid/src/main/java/me/angrybyte/sillyandroid/SillyAndroid.java on lines 342..346

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 48.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status