Sign upLogin

milosmns/silly-android

View on GitHub
Star
sillyandroid/src/main/java/me/angrybyte/sillyandroid/components/EasyDialog.java

Summary

Maintainability
A
1 hr
Test Coverage

EasyDialog has 28 methods (exceeds 20 allowed). Consider refactoring.
Wontfix

@UiThread
@SuppressWarnings({"unused", "WeakerAccess"})
public class EasyDialog extends Dialog implements LayoutWrapper, SillyAndroid.OnKeyboardChangeListener {

    private ViewTreeObserver.OnGlobalLayoutListener mKeyboardListener;
Severity: Minor
Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/components/EasyDialog.java - About 3 hrs to fix

    Method setPadding has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        protected final void setPadding(@NonNull final View view, @Px final int start, @Px final int top, @Px final int end, @Px final int bottom) {
    Severity: Minor
    Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/components/EasyDialog.java - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          @Override
    @CallSuper
    protected void onStart() {
        super.onStart();
        final View contentView = getContentView();
      Severity: Minor
      Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/components/EasyDialog.java and 1 other location - About 35 mins to fix
      sillyandroid/src/main/java/me/angrybyte/sillyandroid/components/EasyFragment.java on lines 378..386

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status