Sign upLogin

milosmns/silly-android

View on GitHub
Star
sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Preconditions.java

Summary

Maintainability
F
3 days
Test Coverage

Preconditions has 84 methods (exceeds 20 allowed). Consider refactoring.
Open

@SuppressWarnings({"unused", "WeakerAccess"})
public final class Preconditions {

    private Preconditions() {}
Severity: Major
Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Preconditions.java - About 1 day to fix

    File Preconditions.java has 560 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    package me.angrybyte.sillyandroid.extras;

/*
 * Copyright (C) 2007 The Guava Authors
 *
    Severity: Major
    Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Preconditions.java - About 1 day to fix

      Method checkNotNull has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

                  T obj,
            @Nullable String errorMessageTemplate,
            @Nullable Object p1,
            @Nullable Object p2,
            @Nullable Object p3,
      Severity: Minor
      Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Preconditions.java - About 45 mins to fix

        Method checkState has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                    boolean b,
            @Nullable String errorMessageTemplate,
            @Nullable Object p1,
            @Nullable Object p2,
            @Nullable Object p3,
        Severity: Minor
        Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Preconditions.java - About 45 mins to fix

          Method checkArgument has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

                      boolean b,
            @Nullable String errorMessageTemplate,
            @Nullable Object p1,
            @Nullable Object p2,
            @Nullable Object p3,
          Severity: Minor
          Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Preconditions.java - About 45 mins to fix

            Method checkArgument has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                        boolean b,
            @Nullable String errorMessageTemplate,
            @Nullable Object p1,
            @Nullable Object p2,
            @Nullable Object p3) {
            Severity: Minor
            Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Preconditions.java - About 35 mins to fix

              Method checkState has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                          boolean b,
            @Nullable String errorMessageTemplate,
            @Nullable Object p1,
            @Nullable Object p2,
            @Nullable Object p3) {
              Severity: Minor
              Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Preconditions.java - About 35 mins to fix

                Method checkNotNull has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                            T obj,
            @Nullable String errorMessageTemplate,
            @Nullable Object p1,
            @Nullable Object p2,
            @Nullable Object p3) {
                Severity: Minor
                Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Preconditions.java - About 35 mins to fix

                  Method format has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      public static String format(String template, @Nullable Object... args) {
        template = String.valueOf(template); // null -> "null"
        if (args == null) return template;

        // start substituting the arguments into the '%s' placeholders
                  Severity: Minor
                  Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Preconditions.java - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      private static String badPositionIndex(int index, int size, String desc) {
        if (index < 0) {
            return format("%s (%s) must not be negative", desc, index);
        } else if (size < 0) {
            throw new IllegalArgumentException("negative size: " + size);
                  Severity: Minor
                  Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Preconditions.java and 1 other location - About 50 mins to fix
                  sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Preconditions.java on lines 1173..1181

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 60.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      private static String badElementIndex(int index, int size, String desc) {
        if (index < 0) {
            return format("%s (%s) must not be negative", desc, index);
        } else if (size < 0) {
            throw new IllegalArgumentException("negative size: " + size);
                  Severity: Minor
                  Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Preconditions.java and 1 other location - About 50 mins to fix
                  sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Preconditions.java on lines 1218..1226

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 60.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public static int checkPositionIndex(int index, int size, @Nullable String desc) {
        // Carefully optimized for execution by hotspot (explanatory comment above)
        if (index < 0 || index > size) {
            throw new IndexOutOfBoundsException(badPositionIndex(index, size, desc));
        }
                  Severity: Minor
                  Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Preconditions.java and 1 other location - About 30 mins to fix
                  sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Preconditions.java on lines 1165..1171

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 40.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                      public static int checkElementIndex(int index, int size, @Nullable String desc) {
        // Carefully optimized for execution by hotspot (explanatory comment above)
        if (index < 0 || index >= size) {
            throw new IndexOutOfBoundsException(badElementIndex(index, size, desc));
        }
                  Severity: Minor
                  Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Preconditions.java and 1 other location - About 30 mins to fix
                  sillyandroid/src/main/java/me/angrybyte/sillyandroid/extras/Preconditions.java on lines 1210..1216

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 40.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status