Sign upLogin

milosmns/silly-android

View on GitHub
Star
sillyandroid/src/main/java/me/angrybyte/sillyandroid/parsable/AnnotationParser.java

Summary

Maintainability
A
0 mins
Test Coverage

Method parseFields has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Wontfix

    public static SparseArray<View> parseFields(@NonNull final Context context, @NonNull final Object instance, @NonNull final LayoutWrapper wrapper) {
        // find all fields
        final SparseArray<View> parsedFields = new SparseArray<>();
        final List<Field> allFields = getAllFields(instance.getClass());
Severity: Minor
Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/parsable/AnnotationParser.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parseType has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Wontfix

    public static void parseType(@NonNull final Context context, @NonNull final Object instance) {
        final Class<?> parsedClass = instance.getClass();

        // look for the @Menu annotation
        if (parsedClass.isAnnotationPresent(Annotations.Menu.class)) {
Severity: Minor
Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/parsable/AnnotationParser.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parseType has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Invalid

    public static void parseType(@NonNull final Context context, @NonNull final Object instance) {
        final Class<?> parsedClass = instance.getClass();

        // look for the @Menu annotation
        if (parsedClass.isAnnotationPresent(Annotations.Menu.class)) {
Severity: Minor
Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/parsable/AnnotationParser.java - About 1 hr to fix

    Method findAndSetView has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Invalid

        @Nullable
    @VisibleForTesting
    static View findAndSetView(@NonNull final Context context, @NonNull final Object instance, @NonNull final LayoutWrapper wrapper,
                               @NonNull final Field field) {
        // check 'find view' annotation, don't crash when 'safe' is set
    Severity: Minor
    Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/parsable/AnnotationParser.java - About 1 hr to fix

      Method findAndSetView has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Invalid

          @Nullable
    @VisibleForTesting
    static View findAndSetView(@NonNull final Context context, @NonNull final Object instance, @NonNull final LayoutWrapper wrapper,
                               @NonNull final Field field) {
        // check 'find view' annotation, don't crash when 'safe' is set
      Severity: Minor
      Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/parsable/AnnotationParser.java - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Wontfix

              if (parsedClass.isAnnotationPresent(Annotations.Layout.class)) {
            Annotations.Layout annotation = parsedClass.getAnnotation(Annotations.Layout.class);
            int layoutId = annotation.value();
            if (layoutId == -1) {
                // ID not provided, check the name
      Severity: Major
      Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/parsable/AnnotationParser.java and 1 other location - About 1 hr to fix
      sillyandroid/src/main/java/me/angrybyte/sillyandroid/parsable/AnnotationParser.java on lines 53..66

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 102.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Wontfix

              if (parsedClass.isAnnotationPresent(Annotations.Menu.class)) {
            Annotations.Menu annotation = parsedClass.getAnnotation(Annotations.Menu.class);
            int menuId = annotation.value();
            if (menuId == -1) {
                // ID not provided, check the name
      Severity: Major
      Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/parsable/AnnotationParser.java and 1 other location - About 1 hr to fix
      sillyandroid/src/main/java/me/angrybyte/sillyandroid/parsable/AnnotationParser.java on lines 69..82

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 102.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Wontfix

          private static void setClickListener(@Nullable final View view, @Nullable final View.OnClickListener listener) {
        if (view != null && listener != null) {
            view.setOnClickListener(listener);
        } else {
            throw new IllegalArgumentException("Cannot set a click listener " + listener + " to " + view);
      Severity: Minor
      Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/parsable/AnnotationParser.java and 1 other location - About 40 mins to fix
      sillyandroid/src/main/java/me/angrybyte/sillyandroid/parsable/AnnotationParser.java on lines 287..293

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Wontfix

          private static void setLongClickListener(@Nullable final View view, @Nullable final View.OnLongClickListener listener) {
        if (view != null && listener != null) {
            view.setOnLongClickListener(listener);
        } else {
            throw new IllegalArgumentException("Cannot set a long-click listener " + listener + " to " + view);
      Severity: Minor
      Found in sillyandroid/src/main/java/me/angrybyte/sillyandroid/parsable/AnnotationParser.java and 1 other location - About 40 mins to fix
      sillyandroid/src/main/java/me/angrybyte/sillyandroid/parsable/AnnotationParser.java on lines 273..279

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 51.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status