Sign upLogin

ministryofjustice/prison-visits

View on GitHub
Star
app/services/email_checker.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method compute_error has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

  def compute_error
    return :unparseable unless parsed
    return :domain_dot if domain_dot_error?
    return :bad_domain if bad_domain?
    return :malformed unless well_formed_address?
Severity: Minor
Found in app/services/email_checker.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

    return :no_mx_record unless mx_records?
Severity: Major
Found in app/services/email_checker.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

          return :spam_reported if spam_reported?(parsed.address)
    Severity: Major
    Found in app/services/email_checker.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

            return :bounced if bounced?(parsed.address)
      Severity: Major
      Found in app/services/email_checker.rb - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status