Sign upLogin

ministryofjustice/prison-visits

View on GitHub
Star

Showing 29 of 29 total issues

Function exports has 109 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(grunt) {

  'use strict';

  // Project configuration.
Severity: Major
Found in Gruntfile.js - About 4 hrs to fix

    Function time_slots has 89 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          var time_slots = this.evaluate(function () {

        var nodes, slots = {};

        // filter-out text nodes
    Severity: Major
    Found in scripts/visiting_times.js - About 3 hrs to fix

      Function displayPerformanceLineChart has 78 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function displayPerformanceLineChart(where, percentile95data, percentile50data, volumeData) {
    var xRange = [new Date(thisYear() - 1, 11, 29), new Date(thisYear() + 1, 0, 1)];
    var y1Range = [0, 1.3 * d3.max(percentile95data, function(d) { return parseInt(d.y); })];
    var y2Range = [0, 1.3 * d3.max(volumeData, function(d) { return parseInt(d.y); })];
      Severity: Major
      Found in app/assets/javascripts/metrics.js - About 3 hrs to fix

        Function displayHistogram has 77 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function displayHistogram(where, dataSource, displayLines) {
    var width, height, x, y, n, data, maxY, svg, bars, xAxis, medianValue, percentileValue;

    width = 960 - margin.left - margin.right;
    height = 500 - margin.top - margin.bottom;
        Severity: Major
        Found in app/assets/javascripts/metrics.js - About 3 hrs to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  svg.append('text')
            .attr('x', 0)
            .attr('y', 0)
            .attr('class', 'percentile-label')
            .attr('transform', 'translate(' + (x(percentileValue) + 4) + ',' + y(maxY) + '),rotate(90)')
          Severity: Major
          Found in app/assets/javascripts/metrics.js and 1 other location - About 2 hrs to fix
          app/assets/javascripts/metrics.js on lines 129..134

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 83.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  svg.append('text')
            .attr('x', 0)
            .attr('y', 0)
            .attr('class', 'median-label')
            .attr('transform', 'translate(' + (x(medianValue) + 4) + ',' + y(maxY) + '),rotate(90)')
          Severity: Major
          Found in app/assets/javascripts/metrics.js and 1 other location - About 2 hrs to fix
          app/assets/javascripts/metrics.js on lines 123..128

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 83.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            moj.Modules.AgeLabel = {
    init: function() {
      return $('.AgeLabel').each(function() {
        $(this).data('AgeLabel', new AgeLabel($(this), $(this).data()));
      });
          Severity: Major
          Found in app/assets/javascripts/modules/moj.AgeLabel.js and 1 other location - About 2 hrs to fix
          app/assets/javascripts/modules/moj.checkbox-summary.js on lines 79..85

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 82.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            moj.Modules.CheckboxSummary = {
    init: function() {
      return $('.CheckboxSummary').each(function() {
        $(this).data('CheckboxSummary', new CheckboxSummary($(this), $(this).data()));
      });
          Severity: Major
          Found in app/assets/javascripts/modules/moj.checkbox-summary.js and 1 other location - About 2 hrs to fix
          app/assets/javascripts/modules/moj.AgeLabel.js on lines 75..81

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 82.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              svg = d3.select(where).append('svg')
        .attr('width', width + margin.left + margin.right)
        .attr('height', height + margin.top + margin.bottom)
        .append('g')
          Severity: Major
          Found in app/assets/javascripts/metrics.js and 1 other location - About 2 hrs to fix
          app/assets/javascripts/metrics.js on lines 186..190

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 75.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              var svg = d3.select(where)
        .append('svg')
        .attr('width', width + margin.left + margin.right)
        .attr('height', height + margin.top + margin.bottom)
        .append('g');
          Severity: Major
          Found in app/assets/javascripts/metrics.js and 1 other location - About 2 hrs to fix
          app/assets/javascripts/metrics.js on lines 63..66

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 75.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  svg.append('line')
            .attr('x1', x(percentileValue))
            .attr('x2', x(percentileValue))
            .attr('y1', y(0))
            .attr('y2', y(maxY))
          Severity: Major
          Found in app/assets/javascripts/metrics.js and 1 other location - About 1 hr to fix
          app/assets/javascripts/metrics.js on lines 111..116

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 72.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  svg.append('line')
            .attr('x1', x(medianValue))
            .attr('x2', x(medianValue))
            .attr('y1', y(0))
            .attr('y2', y(maxY))
          Severity: Major
          Found in app/assets/javascripts/metrics.js and 1 other location - About 1 hr to fix
          app/assets/javascripts/metrics.js on lines 105..110

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 72.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Method compute_error has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

            def compute_error
    return :unparseable unless parsed
    return :domain_dot if domain_dot_error?
    return :bad_domain if bad_domain?
    return :malformed unless well_formed_address?
          Severity: Minor
          Found in app/services/email_checker.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _createAutocomplete has 34 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              _createAutocomplete: function(){
      var selected = this.$select.children(':selected'),
          val = selected.val() ? selected.text() : '',
          key, value, i, attrs, raw_attrs;
          Severity: Minor
          Found in app/assets/javascripts/modules/moj.autocomplete.js - About 1 hr to fix

            Method refresh has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def refresh
    @min_week = 55
    @max_week = 0
    hash_with_default = Hash.new { |h, k| h[k] = Array.new(52, 0) }
            Severity: Minor
            Found in app/reports/weekly_confirmations_report.rb - About 1 hr to fix

              Function formatSeconds has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

              function formatSeconds(s) {
    var output = [],
        d, h, m;

    if (s === 0) {
              Severity: Minor
              Found in app/assets/javascripts/metrics.js - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method booking_receipt_email has 26 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                def booking_receipt_email(visit, confirmation)
    @visit = visit
    @confirmation = confirmation

    if confirmation.slot_selected?
              Severity: Minor
              Found in app/mailers/prison_mailer.rb - About 1 hr to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  def handle_prison_email!
    if parsed_email.source == :prison
      STATSD_CLIENT.increment('pvb.app.email.autorespond_to_prison')
      PrisonMailer.autorespond(parsed_email).deliver_later
      render text: "Accepted."
                Severity: Minor
                Found in app/controllers/webhooks_controller.rb and 1 other location - About 35 mins to fix
                app/controllers/webhooks_controller.rb on lines 52..61

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 35.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                  def handle_visitor_email!
    if parsed_email.source == :visitor
      STATSD_CLIENT.increment('pvb.app.email.autorespon_to_visitor')
      VisitorMailer.autorespond(parsed_email).deliver_later
      render text: "Accepted."
                Severity: Minor
                Found in app/controllers/webhooks_controller.rb and 1 other location - About 35 mins to fix
                app/controllers/webhooks_controller.rb on lines 41..50

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 35.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    svg.selectAll('bar')
        .data(volumeData)
        .enter().append('rect')
        .style('fill', 'pink')
        .attr('x', function(d) { return x(new Date(d.x)); })
                Severity: Minor
                Found in app/assets/javascripts/metrics.js and 1 other location - About 35 mins to fix
                app/assets/javascripts/metrics.js on lines 69..71

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 46.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Severity
                Category
                Status
                Source
                Language