Sign upLogin

ministryofjustice/prison-visits

View on GitHub
Star

Showing 29 of 29 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    svg.selectAll('bar')
        .data(volumeData)
        .enter().append('rect')
        .style('fill', 'pink')
        .attr('x', function(d) { return x(new Date(d.x)); })
Severity: Minor
Found in app/assets/javascripts/metrics.js and 1 other location - About 35 mins to fix
app/assets/javascripts/metrics.js on lines 69..71

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this method.
Open

    return :no_mx_record unless mx_records?
Severity: Major
Found in app/services/email_checker.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

          return :spam_reported if spam_reported?(parsed.address)
    Severity: Major
    Found in app/services/email_checker.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

            return :bounced if bounced?(parsed.address)
      Severity: Major
      Found in app/services/email_checker.rb - About 30 mins to fix

        Method parse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def self.parse(hash)
    hash = hash.dup
    raise ParseError.new("Missing subject") unless hash[:subject]
    raise ParseError.new("Missing email body") unless hash[:text]
    charsets = JSON.parse(hash[:charsets]).with_indifferent_access
        Severity: Minor
        Found in app/models/parsed_email.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def create
    @feedback = Feedback.new(feedback_params)
    @feedback.prison = prison_name if visit

    if @feedback.valid?
        Severity: Minor
        Found in app/controllers/feedbacks_controller.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method validate_renewals has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def validate_renewals
    if outcome == NO_ALLOWANCE
      if no_vo.present? && renew_vo.blank?
        errors.add(:no_vo, 'a renewal date must be chosen')
      end
        Severity: Minor
        Found in app/models/confirmation.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method update_entry has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def update_entry(visit_id)
    entry = find_entry(visit_id)
    if entry
      yield entry
      entry.save! if entry.changed?
        Severity: Minor
        Found in app/services/metrics_logger.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method update has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def update
    visit.visitors = build_visitors

    go_forward = visit.visitors.all?(&:valid?) && visit.valid?(:visitors_set)
        Severity: Minor
        Found in app/controllers/visitors_details_controller.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language