modxcms/revolution

View on GitHub

Showing 7,873 of 7,873 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public $yyTokenName = array(
        '$', 'OPENB', 'SECTION', 'CLOSEB',
        'DOT', 'ID', 'EQUAL', 'FLOAT',
        'INT', 'BOOL', 'SINGLE_QUOTED_STRING', 'DOUBLE_QUOTED_STRING',
        'TRIPPLE_QUOTES', 'TRIPPLE_TEXT', 'TRIPPLE_QUOTES_END', 'NAKED_STRING',
core/model/modx/modcategory.class.php on lines 29..31

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    protected $_invalidCharacters = array('!','@','#','$','%','^','&','*',
    '(',')','+','=','[',']','{','}','\'','"',':',';','\\','/','<','>','?'
    ,',','`','~');
Severity: Minor
Found in core/model/modx/modcategory.class.php and 1 other location - About 30 mins to fix
core/model/smarty/sysplugins/smarty_internal_configfileparser.php on lines 261..269

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            if ($parentObject !== null && $fkMeta !== null) {
                if ($fkMeta['owner'] == 'local') {
                    if ($object->get($fkMeta['foreign']) !== $parentObject->get($fkMeta['local'])) {
                        $object->set($fkMeta['foreign'], $parentObject->get($fkMeta['local']));
                    }
Severity: Minor
Found in core/xpdo/transport/xpdoobjectvehicle.class.php and 1 other location - About 30 mins to fix
core/xpdo/transport/xpdoobjectvehicle.class.php on lines 216..222

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

        return el;
Severity: Major
Found in setup/assets/js/ext-core-debug.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return String(o);
    Severity: Major
    Found in setup/assets/js/ext-core-debug.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return docEl;
      Severity: Major
      Found in setup/assets/js/ext-core-debug.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return isFinite(o) ? String(o) : "null";
        Severity: Major
        Found in setup/assets/js/ext-core-debug.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return null;
          Severity: Major
          Found in setup/assets/js/ext-core-debug.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return a.join("");
            Severity: Major
            Found in setup/assets/js/ext-core-debug.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return r;
              Severity: Major
              Found in setup/assets/js/ext-core-debug.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                        return el;
                Severity: Major
                Found in setup/assets/js/ext-core-debug.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return El.select(el);
                  Severity: Major
                  Found in setup/assets/js/ext-core-debug.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                        return e;
                    Severity: Major
                    Found in manager/assets/ext3/adapter/yui/ext-yui-adapter-debug.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                          return el;
                      Severity: Major
                      Found in manager/assets/ext3/adapter/prototype/ext-prototype-adapter-debug.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                            return el;
                        Severity: Major
                        Found in manager/assets/ext3/adapter/yui/ext-yui-adapter-debug.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                              return e;
                          Severity: Major
                          Found in manager/assets/ext3/adapter/prototype/ext-prototype-adapter-debug.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                                return el;
                            Severity: Major
                            Found in manager/assets/ext3/adapter/jquery/ext-jquery-adapter-debug.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                                  return e;
                              Severity: Major
                              Found in manager/assets/ext3/adapter/jquery/ext-jquery-adapter-debug.js - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                                    return e;
                                Severity: Major
                                Found in manager/assets/ext3/adapter/ext/ext-base-debug.js - About 30 mins to fix

                                  Avoid too many return statements within this function.
                                  Open

                                                      return el;
                                  Severity: Major
                                  Found in manager/assets/ext3/adapter/ext/ext-base-debug.js - About 30 mins to fix
                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language