modxcms/revolution

View on GitHub

Showing 7,873 of 7,873 total issues

Avoid too many return statements within this function.
Open

            return true;
Severity: Major
Found in manager/assets/modext/util/superboxselect.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return;
    Severity: Major
    Found in manager/assets/modext/util/superboxselect.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return true;
      Severity: Major
      Found in manager/assets/modext/util/superboxselect.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                        return true;
        Severity: Major
        Found in manager/assets/modext/util/superboxselect.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return true;
          Severity: Major
          Found in manager/assets/modext/util/superboxselect.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return true;
            Severity: Major
            Found in manager/assets/modext/util/superboxselect.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return;
              Severity: Major
              Found in manager/assets/modext/util/superboxselect.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                                return;
                Severity: Major
                Found in manager/assets/modext/util/superboxselect.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                  Ext.namespace('Ext.ux.dd');Ext.ux.dd.GridDragDropRowOrder=Ext.extend(Ext.util.Observable,{copy:false,scrollable:false,constructor:function(config){if(config)Ext.apply(this,config);this.addEvents({beforerowmove:true,afterrowmove:true,beforerowcopy:true,afterrowcopy:true});Ext.ux.dd.GridDragDropRowOrder.superclass.constructor.call(this)},init:function(grid){this.grid=grid;grid.enableDragDrop=true;grid.on({render:{fn:this.onGridRender,scope:this,single:true}})},onGridRender:function(grid){var self=this;this.target=new Ext.dd.DropTarget(grid.getEl(),{ddGroup:grid.ddGroup||'GridDD',grid:grid,gridDropTarget:this,notifyDrop:function(dd,e,data){if(this.currentRowEl){this.currentRowEl.removeClass('grid-row-insert-below');this.currentRowEl.removeClass('grid-row-insert-above')}var t=Ext.lib.Event.getTarget(e);var rindex=this.grid.getView().findRowIndex(t);if(rindex===false||rindex==data.rowIndex){return false}if(this.gridDropTarget.fireEvent(self.copy?'beforerowcopy':'beforerowmove',this.gridDropTarget,data.rowIndex,rindex,data.selections,123)===false){return false}var ds=this.grid.getStore();var selections=new Array();var keys=ds.data.keys;for(var key in keys){for(var i=0;i<data.selections.length;i++){if(keys[key]==data.selections[i].id){if(rindex==key){return false}selections.push(data.selections[i])}}}if(rindex>data.rowIndex&&this.rowPosition<0){rindex--}if(rindex<data.rowIndex&&this.rowPosition>0){rindex++}if(rindex>data.rowIndex&&data.selections.length>1){rindex=rindex-(data.selections.length-1)}if(rindex==data.rowIndex){return false}if(!self.copy){for(var i=0;i<data.selections.length;i++){ds.remove(ds.getById(data.selections[i].id))}}for(var i=selections.length-1;i>=0;i--){var insertIndex=rindex;ds.insert(insertIndex,selections[i])}var sm=this.grid.getSelectionModel();if(sm){sm.selectRecords(data.selections)}this.gridDropTarget.fireEvent(self.copy?'afterrowcopy':'afterrowmove',this.gridDropTarget,data.rowIndex,rindex,data.selections);return true},notifyOver:function(dd,e,data){var t=Ext.lib.Event.getTarget(e);var rindex=this.grid.getView().findRowIndex(t);var ds=this.grid.getStore();var keys=ds.data.keys;for(var key in keys){for(var i=0;i<data.selections.length;i++){if(keys[key]==data.selections[i].id){if(rindex==key){if(this.currentRowEl){this.currentRowEl.removeClass('grid-row-insert-below');this.currentRowEl.removeClass('grid-row-insert-above')}return this.dropNotAllowed}}}}if(rindex<0||rindex===false){this.currentRowEl.removeClass('grid-row-insert-above');return this.dropNotAllowed}try{var currentRow=this.grid.getView().getRow(rindex);var resolvedRow=new Ext.Element(currentRow).getY()-this.grid.getView().scroller.dom.scrollTop;var rowHeight=currentRow.offsetHeight;this.rowPosition=e.getPageY()-resolvedRow-(rowHeight/2);if(this.currentRowEl){this.currentRowEl.removeClass('grid-row-insert-below');this.currentRowEl.removeClass('grid-row-insert-above')}if(this.rowPosition>0){this.currentRowEl=new Ext.Element(currentRow);this.currentRowEl.addClass('grid-row-insert-below')}else{if(rindex-1>=0){var previousRow=this.grid.getView().getRow(rindex-1);this.currentRowEl=new Ext.Element(previousRow);this.currentRowEl.addClass('grid-row-insert-below')}else{this.currentRowEl.addClass('grid-row-insert-above')}}}catch(err){console.warn(err);rindex=false}return(rindex===false)?this.dropNotAllowed:this.dropAllowed},notifyOut:function(dd,e,data){if(this.currentRowEl){this.currentRowEl.removeClass('grid-row-insert-above');this.currentRowEl.removeClass('grid-row-insert-below')}}});if(this.targetCfg){Ext.apply(this.target,this.targetCfg)}if(this.scrollable){Ext.dd.ScrollManager.register(grid.getView().getEditorParent());grid.on({beforedestroy:this.onBeforeDestroy,scope:this,single:true})}},getTarget:function(){return this.target},getGrid:function(){return this.grid},getCopy:function(){return this.copy?true:false},setCopy:function(b){this.copy=b?true:false},onBeforeDestroy:function(grid){Ext.dd.ScrollManager.unregister(grid.getView().getEditorParent())}});
                  Severity: Major
                  Found in manager/assets/modext/util/utilities.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                                    return false;
                    Severity: Major
                    Found in manager/assets/modext/widgets/modx.treedrop.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                      return true;
                      Severity: Major
                      Found in manager/assets/modext/widgets/modx.treedrop.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                    return false;
                        Severity: Major
                        Found in manager/assets/modext/widgets/resource/modx.tree.resource.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                  return dropNode.attributes.text != 'root' && dropNode.attributes.text !== ''
                                      && targetParent.attributes.text != 'root' && targetParent.attributes.text !== '';
                          Severity: Major
                          Found in manager/assets/modext/widgets/resource/modx.tree.resource.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                    return target.getDepth() > 0;
                            Severity: Major
                            Found in manager/assets/modext/widgets/element/modx.tree.element.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                      return v;
                              Severity: Major
                              Found in manager/assets/modext/widgets/core/modx.grid.settings.js - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                        return a.leaf !== true;
                                Severity: Major
                                Found in manager/assets/modext/widgets/security/modx.tree.resource.group.js - About 30 mins to fix

                                  Avoid too many return statements within this function.
                                  Open

                                  Ext.grid.PropertyColumnModel=function(a,b){var g=Ext.grid,f=Ext.form;this.grid=a;g.PropertyColumnModel.superclass.constructor.call(this,[{header:this.nameText,width:50,sortable:true,dataIndex:'name',id:'name',menuDisabled:true},{header:this.valueText,width:50,resizable:false,dataIndex:'value',id:'value',menuDisabled:true}]);this.store=b;var c=new f.Field({autoCreate:{tag:'select',children:[{tag:'option',value:'true',html:'true'},{tag:'option',value:'false',html:'false'}]},getValue:function(){return this.el.dom.value=='true'}});this.editors={'date':new g.GridEditor(new f.DateField({selectOnFocus:true})),'string':new g.GridEditor(new f.TextField({selectOnFocus:true})),'number':new g.GridEditor(new f.NumberField({selectOnFocus:true,style:'text-align:left;'})),'boolean':new g.GridEditor(c)};this.renderCellDelegate=this.renderCell.createDelegate(this);this.renderPropDelegate=this.renderProp.createDelegate(this)};Ext.extend(Ext.grid.PropertyColumnModel,Ext.grid.ColumnModel,{nameText:'Name',valueText:'Value',dateFormat:'m/j/Y',renderDate:function(a){return a.dateFormat(this.dateFormat)},renderBool:function(a){return a?'true':'false'},isCellEditable:function(a,b){return a==1},getRenderer:function(a){return a==1?this.renderCellDelegate:this.renderPropDelegate},renderProp:function(v){return this.getPropertyName(v)},renderCell:function(a){var b=a;if(Ext.isDate(a)){b=this.renderDate(a)}else if(typeof a=='boolean'){b=this.renderBool(a)}return Ext.util.Format.htmlEncode(b)},getPropertyName:function(a){var b=this.grid.propertyNames;return b&&b[a]?b[a]:a},getCellEditor:function(a,b){var p=this.store.getProperty(b),n=p.data.name,val=p.data.value;if(this.grid.customEditors[n]){return this.grid.customEditors[n]}if(Ext.isDate(val)){return this.editors.date}else if(typeof val=='number'){return this.editors.number}else if(typeof val=='boolean'){return this.editors['boolean']}else{return this.editors.string}},destroy:function(){Ext.grid.PropertyColumnModel.superclass.destroy.call(this);for(var a in this.editors){Ext.destroy(a)}}});
                                  Severity: Major
                                  Found in manager/assets/modext/widgets/core/modx.grid.js - About 30 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                            return $options;
                                    Severity: Major
                                    Found in manager/min/lib/Minify/Controller/MinApp.php - About 30 mins to fix

                                      Avoid too many return statements within this method.
                                      Open

                                                  return '/**/';
                                      Severity: Major
                                      Found in manager/min/lib/Minify/CSS/Compressor.php - About 30 mins to fix

                                        Avoid too many return statements within this method.
                                        Open

                                                      return (float) $var;
                                        Severity: Major
                                        Found in manager/min/lib/FirePHP.php - About 30 mins to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language