Sign upLogin

moip/moip-sdk-php

View on GitHub
Star

Showing 40 of 40 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

    $customer = $moipMerchant->customers()->setOwnId(uniqid())
        ->setFullname('Fulano de Tal')
        ->setEmail('fulano@email.com')
        ->setBirthDate('1988-12-30')
        ->setTaxDocument('22222222222')
Severity: Major
Found in examples/marketplace/transparent_moip_account_flow.php and 1 other location - About 1 hr to fix
examples/marketplace/multiorder_and_multipayment.php on lines 18..31

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 107.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method populate has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function populate(stdClass $response)
    {
        $refund = clone $this;

        $refund->data->id = $this->getIfSet('id', $response);
Severity: Minor
Found in src/Resource/Refund.php - About 1 hr to fix

    Method addAddress has 9 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function addAddress($type, $street, $number, $district, $city, $state, $zip, $complement = null, $country = self::ADDRESS_COUNTRY)
    Severity: Major
    Found in src/Resource/Customer.php - About 1 hr to fix

      Method setAddress has 9 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function setAddress($type, $street, $number, $district, $city, $state, $zip, $complement = null, $country = self::ADDRESS_COUNTRY)
      Severity: Major
      Found in src/Resource/Holder.php - About 1 hr to fix

        Function httpRequest has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            protected function httpRequest($path, $method, $payload = null, $headers = [])
    {
        $http_sess = $this->moip->getSession();
        $body = null;
        if ($payload !== null) {
        Severity: Minor
        Found in src/Resource/MoipResource.php - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method httpRequest has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function httpRequest($path, $method, $payload = null, $headers = [])
    {
        $http_sess = $this->moip->getSession();
        $body = null;
        if ($payload !== null) {
        Severity: Minor
        Found in src/Resource/MoipResource.php - About 1 hr to fix

          Method addAddress has 8 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function addAddress($street, $number, $district, $city, $state, $zip, $complement = null, $country = self::ADDRESS_COUNTRY)
          Severity: Major
          Found in src/Resource/Account.php - About 1 hr to fix

            Method setCompanyAddress has 8 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function setCompanyAddress($street, $number, $district, $city, $state, $zip, $complement = null, $country = self::ADDRESS_COUNTRY)
            Severity: Major
            Found in src/Resource/Account.php - About 1 hr to fix

              Method bankAccountPartial has 8 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function bankAccountPartial($amount, $type, $bankNumber, $agencyNumber, $agencyCheckNumber, $accountNumber, $accountCheckNumber, Customer $holder)
              Severity: Major
              Found in src/Resource/Refund.php - About 1 hr to fix

                Method bankAccountDataCustomer has 7 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    private function bankAccountDataCustomer($type, $bankNumber, $agencyNumber, $agencyCheckNumber, $accountNumber, $accountCheckNumber, Customer $holder)
                Severity: Major
                Found in src/Resource/Refund.php - About 50 mins to fix

                  Method bankAccountFull has 7 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                      public function bankAccountFull($type, $bankNumber, $agencyNumber, $agencyCheckNumber, $accountNumber, $accountCheckNumber, Customer $holder)
                  Severity: Major
                  Found in src/Resource/Refund.php - About 50 mins to fix

                    Function generateListPath has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function generateListPath(Pagination $pagination = null, Filters $filters = null, $params = [])
    {
        $queryParams = [];

        if (!is_null($pagination)) {
                    Severity: Minor
                    Found in src/Resource/MoipResource.php - About 45 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method setCreditCard has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        public function setCreditCard($expirationMonth, $expirationYear, $number, $cvc, Holder $holder, $store = true)
                    Severity: Minor
                    Found in src/Resource/Payment.php - About 45 mins to fix

                      Method setTransfers has 6 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                              $amount,
        $bankNumber,
        $agencyNumber,
        $agencyCheckNumber,
        $accountNumber,
                      Severity: Minor
                      Found in src/Resource/Transfers.php - About 45 mins to fix

                        Method setCreditCard has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                            public function setCreditCard($expirationMonth, $expirationYear, $number, $cvc, Holder $holder = null)
                        Severity: Minor
                        Found in src/Resource/Customer.php - About 35 mins to fix

                          Method before_request has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                              public function before_request(&$url, &$headers, &$data, &$type, &$options)
                          Severity: Minor
                          Found in src/Auth/BasicAuth.php - About 35 mins to fix

                            Method addItem has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                public function addItem($product, $quantity, $detail, $price, $category = 'OTHER_CATEGORIES')
                            Severity: Minor
                            Found in src/Resource/Orders.php - About 35 mins to fix

                              Method before_request has 5 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                  public function before_request(&$url, &$headers, &$data, &$type, &$options)
                              Severity: Minor
                              Found in src/Auth/OAuth.php - About 35 mins to fix

                                Method setDeviceFingerprint has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                    public function setDeviceFingerprint($ip, $latitude, $longitude, $userAgent, $fingerprint)
                                Severity: Minor
                                Found in src/Resource/Payment.php - About 35 mins to fix

                                  Method addReceiver has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                      public function addReceiver($moipAccount, $type, $fixed = null, $percentual = null, $feePayor = false)
                                  Severity: Minor
                                  Found in src/Resource/Orders.php - About 35 mins to fix
                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language