moleculer-go/moleculer

View on GitHub
broker/broker.go

Summary

Maintainability
D
2 days
Test Coverage

Function mergeConfigs has a Cognitive Complexity of 48 (exceeds 20 allowed). Consider refactoring.
Open

func mergeConfigs(baseConfig moleculer.Config, userConfig []*moleculer.Config) moleculer.Config {
    if len(userConfig) > 0 {
        for _, config := range userConfig {
            if config.Services != nil {
                baseConfig.Services = mergeMaps(baseConfig.Services, config.Services)
Severity: Minor
Found in broker/broker.go - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

ServiceBroker has 34 methods (exceeds 20 allowed). Consider refactoring.
Open

type ServiceBroker struct {
    namespace string

    logger *log.Entry

Severity: Minor
Found in broker/broker.go - About 4 hrs to fix

    File broker.go has 518 lines of code (exceeds 500 allowed). Consider refactoring.
    Open

    package broker
    
    import (
        "errors"
        "strings"
    Severity: Minor
    Found in broker/broker.go - About 2 hrs to fix

      Avoid deeply nested control flow statements.
      Open

          } else if strings.ToUpper(broker.config.LogLevel) == "FATAL" {
              log.SetLevel(log.FatalLevel)
          } else {
              log.SetLevel(log.InfoLevel)
          }
      Severity: Major
      Found in broker/broker.go - About 45 mins to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        func (broker *ServiceBroker) waitAction(action string) error {
            start := time.Now()
            for {
                if broker.registry.KnowAction(action) {
                    break
        Severity: Major
        Found in broker/broker.go and 2 other locations - About 1 hr to fix
        broker/broker.go on lines 322..336
        broker/broker.go on lines 356..370

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 149.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        func (broker *ServiceBroker) waitForService(service string) error {
            start := time.Now()
            for {
                if broker.registry.KnowService(service) {
                    break
        Severity: Major
        Found in broker/broker.go and 2 other locations - About 1 hr to fix
        broker/broker.go on lines 339..353
        broker/broker.go on lines 356..370

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 149.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        func (broker *ServiceBroker) waitForNode(nodeID string) error {
            start := time.Now()
            for {
                if broker.registry.KnowNode(nodeID) {
                    break
        Severity: Major
        Found in broker/broker.go and 2 other locations - About 1 hr to fix
        broker/broker.go on lines 322..336
        broker/broker.go on lines 339..353

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 149.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (broker *ServiceBroker) Broadcast(event string, params interface{}, groups ...string) {
            broker.logger.Trace("Broker - Broadcast() event: ", event, " params: ", params, " groups: ", groups)
            if !broker.IsStarted() {
                panic(errors.New("Broker must be started before broadcasting events :("))
            }
        Severity: Major
        Found in broker/broker.go and 1 other location - About 1 hr to fix
        broker/broker.go on lines 507..514

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 132.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        func (broker *ServiceBroker) Emit(event string, params interface{}, groups ...string) {
            broker.logger.Trace("Broker - Emit() event: ", event, " params: ", params, " groups: ", groups)
            if !broker.IsStarted() {
                panic(errors.New("Broker must be started before emiting events :("))
            }
        Severity: Major
        Found in broker/broker.go and 1 other location - About 1 hr to fix
        broker/broker.go on lines 516..523

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 132.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status