Sign upLogin

morrisjdev/FileContextCore

View on GitHub
Star
FileContextCore/Query/Internal/FileContextExpressionTranslatingExpressionVisitor.cs

Summary

Maintainability
A
0 mins
Test Coverage

File FileContextExpressionTranslatingExpressionVisitor.cs has 516 lines of code (exceeds 250 allowed). Consider refactoring.
Wontfix

using System;
using System.Collections.Generic;
using System.Diagnostics;
using System.Linq;
using System.Linq.Expressions;
Severity: Major
Found in FileContextCore/Query/Internal/FileContextExpressionTranslatingExpressionVisitor.cs - About 1 day to fix

    Method VisitMethodCall has 55 lines of code (exceeds 25 allowed). Consider refactoring.
    Wontfix

            protected override Expression VisitMethodCall(MethodCallExpression methodCallExpression)
        {
            if (methodCallExpression.Method.IsGenericMethod
                && methodCallExpression.Method.GetGenericMethodDefinition() == EntityMaterializerSource.TryReadValueMethod)
            {
    Severity: Major
    Found in FileContextCore/Query/Internal/FileContextExpressionTranslatingExpressionVisitor.cs - About 2 hrs to fix

      Method TryBindMember has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Wontfix

              private bool TryBindMember(Expression source, MemberIdentity memberIdentity, Type type, out Expression result)
        {
            result = null;
            Type convertedType = null;
            if (source is UnaryExpression unaryExpression
      Severity: Minor
      Found in FileContextCore/Query/Internal/FileContextExpressionTranslatingExpressionVisitor.cs - About 1 hr to fix

        Method VisitUnary has 34 lines of code (exceeds 25 allowed). Consider refactoring.
        Wontfix

                protected override Expression VisitUnary(UnaryExpression unaryExpression)
        {
            var newOperand = Visit(unaryExpression.Operand);

            if (unaryExpression.NodeType == ExpressionType.Convert
        Severity: Minor
        Found in FileContextCore/Query/Internal/FileContextExpressionTranslatingExpressionVisitor.cs - About 1 hr to fix

          Method VisitMember has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Wontfix

                  protected override Expression VisitMember(MemberExpression memberExpression)
        {
            var innerExpression = Visit(memberExpression.Expression);
            if (memberExpression.Expression != null && innerExpression == null)
            {
          Severity: Minor
          Found in FileContextCore/Query/Internal/FileContextExpressionTranslatingExpressionVisitor.cs - About 1 hr to fix

            Method VisitTypeBinary has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Wontfix

                    protected override Expression VisitTypeBinary(TypeBinaryExpression typeBinaryExpression)
        {
            if (typeBinaryExpression.NodeType == ExpressionType.TypeIs
                && Visit(typeBinaryExpression.Expression) is EntityProjectionExpression entityProjectionExpression)
            {
            Severity: Minor
            Found in FileContextCore/Query/Internal/FileContextExpressionTranslatingExpressionVisitor.cs - About 1 hr to fix

              Avoid too many return statements within this method.
              Wontfix

                                      return Expression.Call(
                            FileContextLinqOperatorProvider.LongCountWithoutPredicate.MakeGenericMethod(typeof(ValueBuffer)),
                            groupByShaperExpression.GroupingParameter);
              Severity: Major
              Found in FileContextCore/Query/Internal/FileContextExpressionTranslatingExpressionVisitor.cs - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Wontfix

                        protected override Expression VisitNew(NewExpression newExpression)
        {
            var newArguments = new List<Expression>();
            foreach (var argument in newExpression.Arguments)
            {
                Severity: Major
                Found in FileContextCore/Query/Internal/FileContextExpressionTranslatingExpressionVisitor.cs and 1 other location - About 1 hr to fix
                FileContextCore/Query/Internal/FileContextExpressionTranslatingExpressionVisitor.cs on lines 500..515

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 107.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Wontfix

                        protected override Expression VisitNewArray(NewArrayExpression newArrayExpression)
        {
            var newExpressions = new List<Expression>();
            foreach (var expression in newArrayExpression.Expressions)
            {
                Severity: Major
                Found in FileContextCore/Query/Internal/FileContextExpressionTranslatingExpressionVisitor.cs and 1 other location - About 1 hr to fix
                FileContextCore/Query/Internal/FileContextExpressionTranslatingExpressionVisitor.cs on lines 483..498

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 107.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Wontfix

                                    foreach (var derivedDerivedType in derivedType.GetDerivedTypes())
                    {
                        equals = Expression.OrElse(
                            equals,
                            Expression.Equal(
                Severity: Minor
                Found in FileContextCore/Query/Internal/FileContextExpressionTranslatingExpressionVisitor.cs and 1 other location - About 35 mins to fix
                FileContextCore/Query/Internal/FileContextQueryableMethodTranslatingExpressionVisitor.cs on lines 509..516

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 66.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Wontfix

                            if (IsConvertedToNullable(ifTrue, conditionalExpression.IfTrue)
                || IsConvertedToNullable(ifFalse, conditionalExpression.IfFalse))
            {
                ifTrue = ConvertToNullable(ifTrue);
                ifFalse = ConvertToNullable(ifFalse);
                Severity: Minor
                Found in FileContextCore/Query/Internal/FileContextExpressionTranslatingExpressionVisitor.cs and 1 other location - About 30 mins to fix
                FileContextCore/Query/Internal/FileContextExpressionTranslatingExpressionVisitor.cs on lines 84..89

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 60.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Wontfix

                            if (IsConvertedToNullable(newLeft, binaryExpression.Left)
                || IsConvertedToNullable(newRight, binaryExpression.Right))
            {
                newLeft = ConvertToNullable(newLeft);
                newRight = ConvertToNullable(newRight);
                Severity: Minor
                Found in FileContextCore/Query/Internal/FileContextExpressionTranslatingExpressionVisitor.cs and 1 other location - About 30 mins to fix
                FileContextCore/Query/Internal/FileContextExpressionTranslatingExpressionVisitor.cs on lines 116..121

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 60.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status