morrisjdev/FileContextCore

View on GitHub
FileContextCore/Query/Internal/FileContextQueryableMethodTranslatingExpressionVisitor.cs

Summary

Maintainability
A
0 mins
Test Coverage

File FileContextQueryableMethodTranslatingExpressionVisitor.cs has 868 lines of code (exceeds 250 allowed). Consider refactoring.
Wontfix

using System;
using System.Collections.Generic;
using System.Linq;
using System.Linq.Expressions;
using System.Reflection;

    Class FileContextQueryableMethodTranslatingExpressionVisitor has 46 methods (exceeds 20 allowed). Consider refactoring.
    Wontfix

        public class FileContextQueryableMethodTranslatingExpressionVisitor : QueryableMethodTranslatingExpressionVisitor
        {
            private static readonly MethodInfo _efPropertyMethod = typeof(EF).GetTypeInfo().GetDeclaredMethod(nameof(EF.Property));
    
            private readonly FileContextExpressionTranslatingExpressionVisitor _expressionTranslator;

      Method Expand has 97 lines of code (exceeds 25 allowed). Consider refactoring.
      Wontfix

                  private Expression Expand(Expression source, MemberIdentity member)
                  {
                      Type convertedType = null;
                      if (source is UnaryExpression unaryExpression
                          && unaryExpression.NodeType == ExpressionType.Convert)

        Method TranslateOfType has 59 lines of code (exceeds 25 allowed). Consider refactoring.
        Wontfix

                protected override ShapedQueryExpression TranslateOfType(ShapedQueryExpression source, Type resultType)
                {
                    if (source.ShaperExpression is EntityShaperExpression entityShaperExpression)
                    {
                        var entityType = entityShaperExpression.EntityType;

          Method TranslateGroupingKey has 47 lines of code (exceeds 25 allowed). Consider refactoring.
          Wontfix

                  private Expression TranslateGroupingKey(Expression expression)
                  {
                      switch (expression)
                      {
                          case NewExpression newExpression:

            Method TranslateGroupBy has 32 lines of code (exceeds 25 allowed). Consider refactoring.
            Wontfix

                    protected override ShapedQueryExpression TranslateGroupBy(ShapedQueryExpression source, LambdaExpression keySelector, LambdaExpression elementSelector, LambdaExpression resultSelector)
                    {
                        var remappedKeySelector = RemapLambdaBody(source, keySelector);
            
                        var translatedKey = TranslateGroupingKey(remappedKeySelector);

              Method TranslateGroupJoin has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Wontfix

                      protected override ShapedQueryExpression TranslateGroupJoin(ShapedQueryExpression outer, ShapedQueryExpression inner, LambdaExpression outerKeySelector, LambdaExpression innerKeySelector, LambdaExpression resultSelector)

                Method TranslateJoin has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Wontfix

                        protected override ShapedQueryExpression TranslateJoin(ShapedQueryExpression outer, ShapedQueryExpression inner, LambdaExpression outerKeySelector, LambdaExpression innerKeySelector, LambdaExpression resultSelector)

                  Method TranslateLeftJoin has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Wontfix

                          protected override ShapedQueryExpression TranslateLeftJoin(ShapedQueryExpression outer, ShapedQueryExpression inner, LambdaExpression outerKeySelector, LambdaExpression innerKeySelector, LambdaExpression resultSelector)

                    Avoid too many return statements within this method.
                    Wontfix

                                    return innerShaper;

                      Avoid too many return statements within this method.
                      Wontfix

                                  return null;

                        Avoid too many return statements within this method.
                        Wontfix

                                            return innerShapedQuery;

                          Similar blocks of code found in 3 locations. Consider refactoring.
                          Wontfix

                                  protected override ShapedQueryExpression TranslateCount(ShapedQueryExpression source, LambdaExpression predicate)
                                  {
                                      var inMemoryQueryExpression = (FileContextQueryExpression)source.QueryExpression;
                          
                                      if (predicate == null)
                          FileContextCore/Query/Internal/FileContextQueryableMethodTranslatingExpressionVisitor.cs on lines 92..119
                          FileContextCore/Query/Internal/FileContextQueryableMethodTranslatingExpressionVisitor.cs on lines 437..466

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 183.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 3 locations. Consider refactoring.
                          Wontfix

                                  protected override ShapedQueryExpression TranslateAny(ShapedQueryExpression source, LambdaExpression predicate)
                                  {
                                      var inMemoryQueryExpression = (FileContextQueryExpression)source.QueryExpression;
                          
                                      if (predicate == null)
                          FileContextCore/Query/Internal/FileContextQueryableMethodTranslatingExpressionVisitor.cs on lines 163..192
                          FileContextCore/Query/Internal/FileContextQueryableMethodTranslatingExpressionVisitor.cs on lines 437..466

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 183.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 3 locations. Consider refactoring.
                          Wontfix

                                  protected override ShapedQueryExpression TranslateLongCount(ShapedQueryExpression source, LambdaExpression predicate)
                                  {
                                      var inMemoryQueryExpression = (FileContextQueryExpression)source.QueryExpression;
                          
                                      if (predicate == null)
                          FileContextCore/Query/Internal/FileContextQueryableMethodTranslatingExpressionVisitor.cs on lines 92..119
                          FileContextCore/Query/Internal/FileContextQueryableMethodTranslatingExpressionVisitor.cs on lines 163..192

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 183.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Wontfix

                                  protected override ShapedQueryExpression TranslateOrderBy(ShapedQueryExpression source, LambdaExpression keySelector, bool ascending)
                                  {
                                      var inMemoryQueryExpression = (FileContextQueryExpression)source.QueryExpression;
                          
                                      keySelector = TranslateLambdaExpression(source, keySelector);
                          FileContextCore/Query/Internal/FileContextQueryableMethodTranslatingExpressionVisitor.cs on lines 718..735

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 124.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Wontfix

                                  protected override ShapedQueryExpression TranslateThenBy(ShapedQueryExpression source, LambdaExpression keySelector, bool ascending)
                                  {
                                      var inMemoryQueryExpression = (FileContextQueryExpression)source.QueryExpression;
                                      keySelector = TranslateLambdaExpression(source, keySelector);
                                      if (keySelector == null)
                          FileContextCore/Query/Internal/FileContextQueryableMethodTranslatingExpressionVisitor.cs on lines 548..566

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 124.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Wontfix

                                  protected override ShapedQueryExpression TranslateSkip(ShapedQueryExpression source, Expression count)
                                  {
                                      var inMemoryQueryExpression = (FileContextQueryExpression)source.QueryExpression;
                                      count = TranslateExpression(count);
                                      if (count == null)
                          FileContextCore/Query/Internal/FileContextQueryableMethodTranslatingExpressionVisitor.cs on lines 697..713

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 103.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Wontfix

                                  protected override ShapedQueryExpression TranslateTake(ShapedQueryExpression source, Expression count)
                                  {
                                      var inMemoryQueryExpression = (FileContextQueryExpression)source.QueryExpression;
                                      count = TranslateExpression(count);
                                      if (count == null)
                          FileContextCore/Query/Internal/FileContextQueryableMethodTranslatingExpressionVisitor.cs on lines 673..689

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 103.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Similar blocks of code found in 2 locations. Consider refactoring.
                          Wontfix

                                              foreach (var derivedDerivedType in derivedType.GetDerivedTypes())
                                              {
                                                  equals = Expression.OrElse(
                                                      equals,
                                                      Expression.Equal(
                          FileContextCore/Query/Internal/FileContextExpressionTranslatingExpressionVisitor.cs on lines 467..474

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 66.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Wontfix

                                              var makeNullable = foreignKey.PrincipalKey.Properties
                                                  .Concat(foreignKey.Properties)
                                                  .Select(p => p.ClrType)
                                                  .Any(t => t.IsNullableType());
                          FileContextCore/Query/Internal/FileContextQueryableMethodTranslatingExpressionVisitor.cs on lines 951..954

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 64.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          Identical blocks of code found in 2 locations. Consider refactoring.
                          Wontfix

                                              var makeNullable = foreignKey.PrincipalKey.Properties
                                                  .Concat(foreignKey.Properties)
                                                  .Select(p => p.ClrType)
                                                  .Any(t => t.IsNullableType());
                          FileContextCore/Query/Internal/FileContextQueryableMethodTranslatingExpressionVisitor.cs on lines 913..916

                          Duplicated Code

                          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                          Tuning

                          This issue has a mass of 64.

                          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                          Refactorings

                          Further Reading

                          There are no issues that match your filters.

                          Category
                          Status