Sign upLogin

mozilla/ssh_scan

View on GitHub
Star

Showing 80 of 80 total issues

Function parseRubyEngineAndVersion has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

function parseRubyEngineAndVersion(rubyVersion) {
  if (rubyVersion === 'default') {
    if (fs.existsSync('.ruby-version')) {
      rubyVersion = '.ruby-version'
    } else if (fs.existsSync('.tool-versions')) {
Severity: Minor
Found in .github/actions/setup-ruby-1.71.0/index.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function setupRuby has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

export async function setupRuby(options = {}) {
  const inputs = { ...options }
  for (const key in inputDefaults) {
    if (!Object.prototype.hasOwnProperty.call(inputs, key)) {
      inputs[key] = core.getInput(key) || inputDefaults[key]
Severity: Minor
Found in .github/actions/setup-ruby-1.71.0/index.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method enumerateIPRange has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def enumerateIPRange(ip,port=nil)
      if ip.fqdn?
        if port.nil?
          socket = ip
        else
Severity: Minor
Found in lib/ssh_scan/target_parser.rb - About 1 hr to fix

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

      module SSHLib
    class NosSSH
      class Version
        def initialize(version_string)
          @version_string = version_string
    Severity: Major
    Found in lib/ssh_scan/ssh_lib/nosssh.rb and 5 other locations - About 1 hr to fix
    lib/ssh_scan/ssh_lib/flowssh.rb on lines 2..30
    lib/ssh_scan/ssh_lib/ipssh.rb on lines 2..30
    lib/ssh_scan/ssh_lib/mpssh.rb on lines 2..30
    lib/ssh_scan/ssh_lib/openssh.rb on lines 2..30
    lib/ssh_scan/ssh_lib/romsshell.rb on lines 2..30

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

      module SSHLib
    class OpenSSH
      class Version
        def initialize(version_string)
          @version_string = version_string
    Severity: Major
    Found in lib/ssh_scan/ssh_lib/openssh.rb and 5 other locations - About 1 hr to fix
    lib/ssh_scan/ssh_lib/flowssh.rb on lines 2..30
    lib/ssh_scan/ssh_lib/ipssh.rb on lines 2..30
    lib/ssh_scan/ssh_lib/mpssh.rb on lines 2..30
    lib/ssh_scan/ssh_lib/nosssh.rb on lines 2..30
    lib/ssh_scan/ssh_lib/romsshell.rb on lines 2..30

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

      module SSHLib
    class RomSShell
      class Version
        def initialize(version_string)
          @version_string = version_string
    Severity: Major
    Found in lib/ssh_scan/ssh_lib/romsshell.rb and 5 other locations - About 1 hr to fix
    lib/ssh_scan/ssh_lib/flowssh.rb on lines 2..30
    lib/ssh_scan/ssh_lib/ipssh.rb on lines 2..30
    lib/ssh_scan/ssh_lib/mpssh.rb on lines 2..30
    lib/ssh_scan/ssh_lib/nosssh.rb on lines 2..30
    lib/ssh_scan/ssh_lib/openssh.rb on lines 2..30

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

      module SSHLib
    class Mpssh
      class Version
        def initialize(version_string)
          @version_string = version_string
    Severity: Major
    Found in lib/ssh_scan/ssh_lib/mpssh.rb and 5 other locations - About 1 hr to fix
    lib/ssh_scan/ssh_lib/flowssh.rb on lines 2..30
    lib/ssh_scan/ssh_lib/ipssh.rb on lines 2..30
    lib/ssh_scan/ssh_lib/nosssh.rb on lines 2..30
    lib/ssh_scan/ssh_lib/openssh.rb on lines 2..30
    lib/ssh_scan/ssh_lib/romsshell.rb on lines 2..30

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

      module SSHLib
    class IpSsh
      class Version
        def initialize(version_string)
          @version_string = version_string
    Severity: Major
    Found in lib/ssh_scan/ssh_lib/ipssh.rb and 5 other locations - About 1 hr to fix
    lib/ssh_scan/ssh_lib/flowssh.rb on lines 2..30
    lib/ssh_scan/ssh_lib/mpssh.rb on lines 2..30
    lib/ssh_scan/ssh_lib/nosssh.rb on lines 2..30
    lib/ssh_scan/ssh_lib/openssh.rb on lines 2..30
    lib/ssh_scan/ssh_lib/romsshell.rb on lines 2..30

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 6 locations. Consider refactoring.
    Open

      module SSHLib
    class FlowSsh
      class Version
        def initialize(version_string)
          @version_string = version_string
    Severity: Major
    Found in lib/ssh_scan/ssh_lib/flowssh.rb and 5 other locations - About 1 hr to fix
    lib/ssh_scan/ssh_lib/ipssh.rb on lines 2..30
    lib/ssh_scan/ssh_lib/mpssh.rb on lines 2..30
    lib/ssh_scan/ssh_lib/nosssh.rb on lines 2..30
    lib/ssh_scan/ssh_lib/openssh.rb on lines 2..30
    lib/ssh_scan/ssh_lib/romsshell.rb on lines 2..30

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function parseRubyEngineAndVersion has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function parseRubyEngineAndVersion(rubyVersion) {
  if (rubyVersion === 'default') {
    if (fs.existsSync('.ruby-version')) {
      rubyVersion = '.ruby-version'
    } else if (fs.existsSync('.tool-versions')) {
    Severity: Minor
    Found in .github/actions/setup-ruby-1.71.0/index.js - About 1 hr to fix

      Method recommendations has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
      Open

          def recommendations
      recommendations = []

      # Add these items to be compliant
      if missing_policy_kex.any?
      Severity: Minor
      Found in lib/ssh_scan/policy_manager.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method os_guess has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def os_guess()
      case @string
      when /Ubuntu/i
        return SSHScan::OS::Ubuntu.new(@string)
      when /6.6p1-5build1/i # non-standard Ubuntu release
      Severity: Minor
      Found in lib/ssh_scan/banner.rb - About 1 hr to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

          if (common.shouldUseToolCache(engine, version)) {
    inToolCache = tc.find('Ruby', version)
    if (inToolCache) {
      rubyPrefix = inToolCache
    } else {
        Severity: Minor
        Found in .github/actions/setup-ruby-1.71.0/ruby-builder.js and 1 other location - About 55 mins to fix
        .github/actions/setup-ruby-1.71.0/windows.js on lines 40..49

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 54.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

          if (common.shouldUseToolCache(engine, version)) {
    inToolCache = tc.find('Ruby', version)
    if (inToolCache) {
      rubyPrefix = inToolCache
    } else {
        Severity: Minor
        Found in .github/actions/setup-ruby-1.71.0/windows.js and 1 other location - About 55 mins to fix
        .github/actions/setup-ruby-1.71.0/ruby-builder.js on lines 20..31

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 54.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function setupPath has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

        export function setupPath(newPathEntries) {
  const envPath = windows ? 'Path' : 'PATH'
  const originalPath = process.env[envPath].split(path.delimiter)
  let cleanPath = originalPath.filter(entry => !/\bruby\b/i.test(entry))
        Severity: Minor
        Found in .github/actions/setup-ruby-1.71.0/common.js - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function bundleInstall has 7 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        export async function bundleInstall(gemfile, lockFile, platform, engine, rubyVersion, bundlerVersion, cacheVersion) {
        Severity: Major
        Found in .github/actions/setup-ruby-1.71.0/bundler.js - About 50 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            def resolve_fqdn_as_ipv6(timeout = 3)
    begin
      Timeout::timeout(timeout) {
        Resolv::DNS.open do |dns|
          ress = dns.getresources self, Resolv::DNS::Resource::IN::AAAA
          Severity: Minor
          Found in lib/string_ext.rb and 1 other location - About 45 mins to fix
          lib/string_ext.rb on lines 42..52

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 41.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

            def resolve_fqdn_as_ipv4(timeout = 3)
    begin
      Timeout::timeout(timeout) {
        Resolv::DNS.open do |dns|
          ress = dns.getresources self, Resolv::DNS::Resource::IN::A
          Severity: Minor
          Found in lib/string_ext.rb and 1 other location - About 45 mins to fix
          lib/string_ext.rb on lines 28..38

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 41.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function install has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          export async function install(platform, engine, version) {
  const url = rubyInstallerVersions[version]

  if (!url.endsWith('.7z')) {
    throw new Error(`URL should end in .7z: ${url}`)
          Severity: Minor
          Found in .github/actions/setup-ruby-1.71.0/windows.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method ubuntu_version_guess has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

                def ubuntu_version_guess
        possible_versions = []
        OS::Ubuntu::FINGERPRINTS.keys.each do |ubuntu_version|
          OS::Ubuntu::FINGERPRINTS[ubuntu_version].uniq.each do |banner|
            openssh_ps, ubuntu_sig = banner.split("-")
          Severity: Minor
          Found in lib/ssh_scan/os/ubuntu.rb - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language