Sign upLogin

mozilla/ssh_scan

View on GitHub
Star

Showing 80 of 80 total issues

Avoid too many return statements within this method.
Open

        return SSHScan::OS::ROS.new
Severity: Major
Found in lib/ssh_scan/banner.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            return SSHScan::OS::Debian.new
    Severity: Major
    Found in lib/ssh_scan/banner.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return SSHScan::SSHLib::Mpssh.new(@string)
      Severity: Major
      Found in lib/ssh_scan/banner.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return SSHScan::SSHLib::FlowSsh.new(@string)
        Severity: Major
        Found in lib/ssh_scan/banner.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return SSHScan::OS::DOPRA.new
          Severity: Major
          Found in lib/ssh_scan/banner.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return SSHScan::SSHLib::NosSSH.new(@string)
            Severity: Major
            Found in lib/ssh_scan/banner.rb - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      return SSHScan::OS::Raspbian.new(@string)
              Severity: Major
              Found in lib/ssh_scan/banner.rb - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return SSHScan::OS::Unknown.new
                Severity: Major
                Found in lib/ssh_scan/banner.rb - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          return SSHScan::SSHLib::Cryptlib.new()
                  Severity: Major
                  Found in lib/ssh_scan/banner.rb - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return SSHScan::SSHLib::Dropbear.new(@string)
                    Severity: Major
                    Found in lib/ssh_scan/banner.rb - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              return SSHScan::SSHLib::DOPRASSH.new()
                      Severity: Major
                      Found in lib/ssh_scan/banner.rb - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                return SSHScan::OS::Windows.new
                        Severity: Major
                        Found in lib/ssh_scan/banner.rb - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                  return SSHScan::SSHLib::PGP.new()
                          Severity: Major
                          Found in lib/ssh_scan/banner.rb - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                    return SSHScan::SSHLib::Unknown.new()
                            Severity: Major
                            Found in lib/ssh_scan/banner.rb - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                      return SSHScan::OS::Cisco.new
                              Severity: Major
                              Found in lib/ssh_scan/banner.rb - About 30 mins to fix

                                Method out_of_policy_auth_methods has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                Open

                                    def out_of_policy_auth_methods
      return [] if @policy.auth_methods.empty?
      return [] if @result.auth_methods.empty?
      target_auth_methods = @result.auth_methods
      outliers = []
                                Severity: Minor
                                Found in lib/ssh_scan/policy_manager.rb - About 25 mins to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Similar blocks of code found in 4 locations. Consider refactoring.
                                Open

                                        if host_keys[i].eql? "ecdsa-sha2-nistp256"
          key = SSHScan::Crypto::PublicKey.new([host_keys[i], host_keys[i + 1]].join(" "))
          keys.merge!(key.to_hash)
                                Severity: Minor
                                Found in lib/ssh_scan/scan_engine.rb and 3 other locations - About 20 mins to fix
                                lib/ssh_scan/scan_engine.rb on lines 139..141
                                lib/ssh_scan/scan_engine.rb on lines 144..146
                                lib/ssh_scan/scan_engine.rb on lines 154..156

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 27.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 4 locations. Consider refactoring.
                                Open

                                        if host_keys[i].eql? "ssh-ed25519"
          key = SSHScan::Crypto::PublicKey.new([host_keys[i], host_keys[i + 1]].join(" "))
          keys.merge!(key.to_hash)
                                Severity: Minor
                                Found in lib/ssh_scan/scan_engine.rb and 3 other locations - About 20 mins to fix
                                lib/ssh_scan/scan_engine.rb on lines 139..141
                                lib/ssh_scan/scan_engine.rb on lines 144..146
                                lib/ssh_scan/scan_engine.rb on lines 149..151

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 27.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 4 locations. Consider refactoring.
                                Open

                                        if host_keys[i].eql? "ssh-rsa"
          key = SSHScan::Crypto::PublicKey.new([host_keys[i], host_keys[i + 1]].join(" "))
          keys.merge!(key.to_hash)
                                Severity: Minor
                                Found in lib/ssh_scan/scan_engine.rb and 3 other locations - About 20 mins to fix
                                lib/ssh_scan/scan_engine.rb on lines 139..141
                                lib/ssh_scan/scan_engine.rb on lines 149..151
                                lib/ssh_scan/scan_engine.rb on lines 154..156

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 27.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Similar blocks of code found in 4 locations. Consider refactoring.
                                Open

                                        if host_keys[i].eql? "ssh-dss"
          key = SSHScan::Crypto::PublicKey.new([host_keys[i], host_keys[i + 1]].join(" "))
          keys.merge!(key.to_hash)
                                Severity: Minor
                                Found in lib/ssh_scan/scan_engine.rb and 3 other locations - About 20 mins to fix
                                lib/ssh_scan/scan_engine.rb on lines 144..146
                                lib/ssh_scan/scan_engine.rb on lines 149..151
                                lib/ssh_scan/scan_engine.rb on lines 154..156

                                Duplicated Code

                                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                Tuning

                                This issue has a mass of 27.

                                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                Refactorings

                                Further Reading

                                Severity
                                Category
                                Status
                                Source
                                Language