Sign upLogin

mpapis/tf

View on GitHub
Star
lib/plugins/tf/env_arr_test.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method execute_size has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

  def execute_size test, matcher, _stdout, _stderr, _stdboth, _status, env
Severity: Major
Found in lib/plugins/tf/env_arr_test.rb - About 50 mins to fix

    Method execute_all has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def execute_all test, matcher, _stdout, _stderr, _stdboth, _status, env
    Severity: Major
    Found in lib/plugins/tf/env_arr_test.rb - About 50 mins to fix

      Method execute_one has 7 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def execute_one test, matcher, _stdout, _stderr, _stdboth, _status, env
      Severity: Major
      Found in lib/plugins/tf/env_arr_test.rb - About 50 mins to fix

        Method execute has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          def execute test, _stdout, _stderr, _stdboth, _status, env
        Severity: Minor
        Found in lib/plugins/tf/env_arr_test.rb - About 45 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              if ( sign == "=" ) ^ ( Regexp.new(value) =~ "#{var_val}" )
      [ false, "failed: env #{variable}[] #{sign} /#{value}/ # was '#{var_val}'" ]
    else
      [ true, "passed: env #{variable}[] #{sign} /#{value}/" ]
          Severity: Minor
          Found in lib/plugins/tf/env_arr_test.rb and 1 other location - About 45 mins to fix
          lib/plugins/tf/env_match_test.rb on lines 16..19

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 39.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status