Sign upLogin

mrDoctorWho/vk4xmpp

View on GitHub
Star
extensions/attachments.py

Summary

Maintainability
D
2 days
Test Coverage

Function parseAttachments has a Cognitive Complexity of 90 (exceeds 5 allowed). Consider refactoring.
Open

def parseAttachments(self, msg, spacer=""):
    """
    “parses” attachments from the json to a string
    """
    result = (MSG_APPEND, "")
Severity: Minor
Found in extensions/attachments.py - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function attachments_msg03 has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

def attachments_msg03(msg, destination, source):
    body = msg.getBody()
    if body:
        if msg.getType() == "groupchat":
            user = Chat.getUserObject(destination)
Severity: Minor
Found in extensions/attachments.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                    if tid > 0:
                        name = "%s's" % name_
                    else:
                        name = "“%s”" % name_
Severity: Major
Found in extensions/attachments.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                        for image in images:
                        if image.get("width") == size or image.get("height") == size:
                            body += "Sticker: %s" % image["url"]
                            found = True
                            break
    Severity: Major
    Found in extensions/attachments.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                          if current.get("attachments"):
                        body += spacer + parseAttachments(self, current, spacer)[1] + "\n" + spacer + "\n"
                body += spacer + ("Wall: %s" % WALL_LINK % current)
      Severity: Major
      Found in extensions/attachments.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                            if current.get("text") or current.get("copy_text"):
                        body += spacer + uhtml(compile_eol.sub("\n" + spacer, current["text"] or current.get("copy_text"))) + "\n"
                    if current.get("attachments"):
        Severity: Major
        Found in extensions/attachments.py - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                              if found:
                        break
          Severity: Major
          Found in extensions/attachments.py - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                for size in sizes:
                        if size.get("type") == key:
                            body += "Photo: %s" % size.get("url")  # No new line needed if we have just one photo and no text
                            found = True
                            break
            Severity: Major
            Found in extensions/attachments.py - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                  if found:
                        break
              Severity: Major
              Found in extensions/attachments.py - About 45 mins to fix

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                        if msg.getType() == "groupchat":
            user = Chat.getUserObject(destination)
        else:
            user = Users.get(destination)
                Severity: Minor
                Found in extensions/attachments.py and 1 other location - About 55 mins to fix
                extensions/sticker.py on lines 40..43

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 37.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status