Sign upLogin

mrtazz/checkmake

View on GitHub
Star
parser/parser.go

Summary

Maintainability
A
1 hr
Test Coverage

Function Parse has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
Open

func Parse(filepath string) (ret Makefile, err error) {

    ret.FileName = filepath
    var scanner *MakefileScanner
    scanner, err = NewMakefileScanner(filepath)
Severity: Minor
Found in parser/parser.go - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function Parse has 5 return statements (exceeds 4 allowed).
Open

func Parse(filepath string) (ret Makefile, err error) {

    ret.FileName = filepath
    var scanner *MakefileScanner
    scanner, err = NewMakefileScanner(filepath)
Severity: Major
Found in parser/parser.go - About 35 mins to fix

    Your code does not pass gofmt in 1 place. Go fmt your code!
    Open

    // Package parser implements all the parser functionality for Makefiles. This
    Severity: Minor
    Found in parser/parser.go by gofmt

    There are no issues that match your filters.

    Category
    Status