Sign upLogin

mumuki/mumuki-gobstones-runner

View on GitHub
Star
lib/checker.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method check_final_board has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def check_final_board(output, expected)
      status = output[:status]
      result = output[:result]

      return if is_expected_timeout(result)
Severity: Minor
Found in lib/checker.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

      return "wrong_arguments_quantity" if code.include? 'arity-mismatch'
Severity: Major
Found in lib/checker.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

          return "wrong_argument_type" if has_wrong_argument_type? code
    Severity: Major
    Found in lib/checker.rb - About 30 mins to fix

      Method convert_known_reason_code has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def convert_known_reason_code(code)
      return "no_stones" if code == 'cannot-remove-stone'
      return "out_of_board" if code == 'cannot-move-to'
      return "unassigned_variable" if code == 'undefined-variable'
      return "boom_called" if code == 'boom-called'
      Severity: Minor
      Found in lib/checker.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status