Sign upLogin

mygento/yandexdelivery

View on GitHub
Star

Showing 262 of 262 total issues

The variable $keys_data is not named in camelCase.
Open

    public function handleSave()
    {

        if (Mage::getStoreConfig('carriers/yandexdelivery/active')) {
            //process keys
Severity: Minor
Found in app/code/local/Mygento/Yandexdelivery/Model/Observer.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $processed_dimensions is not named in camelCase.
Open

    public function collectRates(Mage_Shipping_Model_Rate_Request $request)
    {
        Varien_Profiler::start($this->_name . '_collect_rate');

        if (!$this->getType()) {
Severity: Minor
Found in app/code/local/Mygento/Yandexdelivery/Model/Shipping.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $processed_dimensions is not named in camelCase.
Open

    public function collectRates(Mage_Shipping_Model_Rate_Request $request)
    {
        Varien_Profiler::start($this->_name . '_collect_rate');

        if (!$this->getType()) {
Severity: Minor
Found in app/code/local/Mygento/Yandexdelivery/Model/Shipping.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $ids_data is not named in camelCase.
Open

    public function handleSave()
    {

        if (Mage::getStoreConfig('carriers/yandexdelivery/active')) {
            //process keys
Severity: Minor
Found in app/code/local/Mygento/Yandexdelivery/Model/Observer.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $carrier_offer is not named in camelCase.
Open

    private function processType($response, $type, $request, $result)
    {

        foreach ($response->data as $carrier_offer) {
            $price = $request->getFreeShipping() ? 0 : $carrier_offer->cost;
Severity: Minor
Found in app/code/local/Mygento/Yandexdelivery/Model/Shipping.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $carrier_offer is not named in camelCase.
Open

    private function processType($response, $type, $request, $result)
    {

        foreach ($response->data as $carrier_offer) {
            $price = $request->getFreeShipping() ? 0 : $carrier_offer->cost;
Severity: Minor
Found in app/code/local/Mygento/Yandexdelivery/Model/Shipping.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $carrier_offer is not named in camelCase.
Open

    private function processType($response, $type, $request, $result)
    {

        foreach ($response->data as $carrier_offer) {
            $price = $request->getFreeShipping() ? 0 : $carrier_offer->cost;
Severity: Minor
Found in app/code/local/Mygento/Yandexdelivery/Model/Shipping.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $error_text is not named in camelCase.
Open

    public function deleteAction()
    {
        $order_id = Mage::app()->getRequest()->getParam('orderid');

        if (!$order_id) {
Severity: Minor
Found in app/code/local/Mygento/Yandexdelivery/controllers/Adminhtml/Yandexdelivery/ApiController.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $error_text is not named in camelCase.
Open

    public function collectRates(Mage_Shipping_Model_Rate_Request $request)
    {
        Varien_Profiler::start($this->_name . '_collect_rate');

        if (!$this->getType()) {
Severity: Minor
Found in app/code/local/Mygento/Yandexdelivery/Model/Shipping.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $info_array is not named in camelCase.
Open

    protected function getOrderData($order) {

        if (Mage::getStoreConfig('carriers/' . $this->_name . '/onlyone')) {
            $weight = round(Mage::getStoreConfig('carriers/' . $this->_name . '/oneweight') * 1000 / Mage::getStoreConfig('carriers/' . $this->_name . '/weightunit'), 3);
            $dimensions = Mage::helper($this->_name)->getStandardSizes();
Severity: Minor
Found in app/code/local/Mygento/Yandexdelivery/Model/Carrier.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $order_items is not named in camelCase.
Open

    protected function getOrderData($order) {

        if (Mage::getStoreConfig('carriers/' . $this->_name . '/onlyone')) {
            $weight = round(Mage::getStoreConfig('carriers/' . $this->_name . '/oneweight') * 1000 / Mage::getStoreConfig('carriers/' . $this->_name . '/weightunit'), 3);
            $dimensions = Mage::helper($this->_name)->getStandardSizes();
Severity: Minor
Found in app/code/local/Mygento/Yandexdelivery/Model/Carrier.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $processed_dimensions is not named in camelCase.
Open

    public function collectRates(Mage_Shipping_Model_Rate_Request $request)
    {
        Varien_Profiler::start($this->_name . '_collect_rate');

        if (!$this->getType()) {
Severity: Minor
Found in app/code/local/Mygento/Yandexdelivery/Model/Shipping.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $curl_handle is not named in camelCase.
Open

    public function requestApiPost($url, $data, $sign = false, $method = false)
    {
        $this->addLog('Request to: ' . $url);

        if ($sign) {
Severity: Minor
Found in app/code/local/Mygento/Yandexdelivery/Helper/Data.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $yd_id_collection is not named in camelCase.
Open

    public function getShipment($orderId) {
        $yd_id_collection = Mage::getModel('yandexdelivery/shipment')->getCollection();
        $yd_id_collection->addFieldToFilter('order_id', $orderId);
        $yd_id_collection->load();
        if ($yd_id_collection->getSize() > 0) {
Severity: Minor
Found in app/code/local/Mygento/Yandexdelivery/Model/Carrier.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $ids_data is not named in camelCase.
Open

    public function handleSave()
    {

        if (Mage::getStoreConfig('carriers/yandexdelivery/active')) {
            //process keys
Severity: Minor
Found in app/code/local/Mygento/Yandexdelivery/Model/Observer.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $carrier_offer is not named in camelCase.
Open

    private function processType($response, $type, $request, $result)
    {

        foreach ($response->data as $carrier_offer) {
            $price = $request->getFreeShipping() ? 0 : $carrier_offer->cost;
Severity: Minor
Found in app/code/local/Mygento/Yandexdelivery/Model/Shipping.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $_options is not named in camelCase.
Open

    public function getAllOptions()
    {
        $attributes = Mage::getModel('eav/config')->getEntityType(Mage_Catalog_Model_Product::ENTITY)->getAttributeCollection();
        $attributes->setOrder('frontend_label', 'ASC');
Severity: Minor
Found in app/code/local/Mygento/Yandexdelivery/Model/Source/Attribute.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $data_array is not named in camelCase.
Open

    public function toOptionsArray($model)
    {
        $data_array = [];
        $model = Mage::getModel('yandexdelivery/' . $model);
        $data = $model->getCollection()->getData();
Severity: Minor
Found in app/code/local/Mygento/Yandexdelivery/Helper/Data.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $parcel_id is not named in camelCase.
Open

    public function getSenderParcelDocs($parcel_id) {
        return $this->sendRequest('getSenderParcelDocs', ['parcel_id' => $parcel_id], true);
    }
Severity: Minor
Found in app/code/local/Mygento/Yandexdelivery/Model/Carrier.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $carrier_offer is not named in camelCase.
Open

    private function processType($response, $type, $request, $result)
    {

        foreach ($response->data as $carrier_offer) {
            $price = $request->getFreeShipping() ? 0 : $carrier_offer->cost;
Severity: Minor
Found in app/code/local/Mygento/Yandexdelivery/Model/Shipping.php by phpmd

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

Severity
Category
Status
Source
Language