mygento/yandexdelivery

View on GitHub

Showing 262 of 262 total issues

The variable $carrier_offer is not named in camelCase.
Open

    private function processType($response, $type, $request, $result)
    {

        foreach ($response->data as $carrier_offer) {
            $price = $request->getFreeShipping() ? 0 : $carrier_offer->cost;

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The variable $_options is not named in camelCase.
Open

    public function getAllOptions()
    {
        $attributes = Mage::getModel('eav/config')->getEntityType(Mage_Catalog_Model_Product::ENTITY)->getAttributeCollection();
        $attributes->setOrder('frontend_label', 'ASC');

CamelCaseVariableName

Since: 0.2

It is considered best practice to use the camelCase notation to name variables.

Example

class ClassName {
    public function doSomething() {
        $data_module = new DataModule();
    }
}

Source

The method _prepareColumns is not named in camelCase.
Open

    protected function _prepareColumns()
    {
        $this->addColumn('increment_id', array(
            'header' => Mage::helper('yandexdelivery')->__('Order ID'),
            'align' => 'left',

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _construct is not named in camelCase.
Open

    public function _construct()
    {
        //защита от двойного вызова в одностраничном чекауте
        if (Mage::registry('yd_block_called')) {
            return '';

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _prepareCollection is not named in camelCase.
Open

    protected function _prepareCollection()
    {
        $collection = Mage::getModel('yandexdelivery/shipment')->getCollection();
        $collection->getSelect()->join(
            array('table_alias' => Mage::getConfig()->getTablePrefix() . 'sales_flat_order'),

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _construct is not named in camelCase.
Open

    public function _construct()
    {
        parent::_construct();
        $this->_init('yandexdelivery/warehouse');
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _construct is not named in camelCase.
Open

    public function _construct()
    {
        parent::_construct();
        $this->_init('yandexdelivery/shipment');
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _construct is not named in camelCase.
Open

    public function _construct()
    {
        parent::_construct();
        $this->_init('yandexdelivery/warehouse');
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _construct is not named in camelCase.
Open

    public function _construct()
    {
        parent::_construct();
        $this->_init('yandexdelivery/sender');
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _construct is not named in camelCase.
Open

    public function _construct()
    {
        parent::_construct();
        $this->_init('yandexdelivery/shipment');
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _beforeToHtml is not named in camelCase.
Open

    public function _beforeToHtml()
    {
        $this->removeButton('add');
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _construct is not named in camelCase.
Open

    public function _construct()
    {
        parent::_construct();
        $this->_init('yandexdelivery/sender');
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _construct is not named in camelCase.
Open

    public function _construct()
    {
        $this->_init('yandexdelivery/sender', 'id');
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _construct is not named in camelCase.
Open

    public function _construct()
    {
        $this->_controller = 'adminhtml_shipment';
        $this->_blockGroup = 'yandexdelivery';
        $this->_headerText = Mage::helper('yandexdelivery')->__('Shipment Manager');

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _isAllowed is not named in camelCase.
Open

    protected function _isAllowed()
    {
        return Mage::getSingleton('admin/session')->isAllowed('catalog/yandexdelivery/api');
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _construct is not named in camelCase.
Open

    public function _construct()
    {
        $this->_init('yandexdelivery/shipment', 'id');
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _construct is not named in camelCase.
Open

    public function _construct()
    {
        $this->_init('yandexdelivery/warehouse', 'id');
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _construct is not named in camelCase.
Open

    public function _construct()
    {
        parent::_construct();
        $this->_init('yandexdelivery/requisite');
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _construct is not named in camelCase.
Open

    public function _construct()
    {
        $this->_init('yandexdelivery/requisite', 'id');
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _construct is not named in camelCase.
Open

    public function _construct()
    {
        parent::_construct();
        $this->_init('yandexdelivery/requisite');
    }

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

Severity
Category
Status
Source
Language