Sign upLogin

myles/jekyll-typogrify

View on GitHub
Star

Showing 94 of 94 total issues

Redundant return detected.
Open

      return Typogruby.entities(text.to_s)
Severity: Minor
Found in lib/jekyll/typogrify.rb by rubocop

This cop checks for redundant return expressions.

Example:

def test
  return something
end

def test
  one
  two
  three
  return something
end

It should be extended to handle methods whose body is if/else or a case expression with a default branch.

Redundant return detected.
Open

      return Typogruby.improve(text.to_s)
Severity: Minor
Found in lib/jekyll/typogrify.rb by rubocop

This cop checks for redundant return expressions.

Example:

def test
  return something
end

def test
  one
  two
  three
  return something
end

It should be extended to handle methods whose body is if/else or a case expression with a default branch.

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

require "bundler/setup"
Severity: Minor
Found in bin/console by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Final newline missing.
Open

require "jekyll/typogrify"
Severity: Minor
Found in lib/jekyll-typogrify.rb by rubocop

Redundant return detected.
Open

      return Typogruby.amp(text.to_s)
Severity: Minor
Found in lib/jekyll/typogrify.rb by rubocop

This cop checks for redundant return expressions.

Example:

def test
  return something
end

def test
  one
  two
  three
  return something
end

It should be extended to handle methods whose body is if/else or a case expression with a default branch.

Redundant return detected.
Open

      return Typogruby.smartypants(text.to_s)
Severity: Minor
Found in lib/jekyll/typogrify.rb by rubocop

This cop checks for redundant return expressions.

Example:

def test
  return something
end

def test
  one
  two
  three
  return something
end

It should be extended to handle methods whose body is if/else or a case expression with a default branch.

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

  spec.add_runtime_dependency "typogruby"
Severity: Minor
Found in jekyll-typogrify.gemspec by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Avoid the use of Perl-style backrefs.
Open

        tag, before, caps = $1, $2, $3
Severity: Minor
Found in lib/jekyll/typogrify.rb by rubocop

This cop looks for uses of Perl-style regexp match backreferences like $1, $2, etc.

Example:

# bad
puts $1

# good
puts Regexp.last_match(1)

Line is too long. [97/80]
Open

  spec.summary       = %q{A Jekyll plugin that improves the typography of your Liquid templates.}
Severity: Minor
Found in jekyll-typogrify.gemspec by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

  spec.license       = "MIT"
Severity: Minor
Found in jekyll-typogrify.gemspec by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Final newline missing.
Open

task :default => :spec
Severity: Minor
Found in Rakefile by rubocop

Line is too long. [97/80]
Open

      # $1 and $2 are excluded HTML tags, $3 is the part before the caps and $4 is the caps match
Severity: Minor
Found in lib/jekyll/typogrify.rb by rubocop

Use only ascii symbols in comments.
Open

    # converts a — (em dash) by optional whitespace or a non-breaking space
Severity: Minor
Found in lib/jekyll/typogrify.rb by rubocop

This cop checks for non-ascii (non-English) characters in comments. You could set an array of allowed non-ascii chars in AllowedChars attribute (empty by default).

Example:

# bad
# Translates from English to 日本語。

# good
# Translates from English to Japanese

No licenses found for titlecase. Either the library reports the licenses in an unsupported format, or the library is unlicensed.
Open

    titlecase (0.1.1)
Severity: Minor
Found in Gemfile.lock by git-legal
Severity
Category
Status
Source
Language