mysociety/alaveteli

View on GitHub
app/controllers/admin_request_controller.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method move has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  def move
    if params[:commit] == 'Move request to user' && !params[:user_url_name].blank?
      destination_user = User.find_by_url_name(params[:user_url_name])

      if @info_request.move_to_user(destination_user,
Severity: Minor
Found in app/controllers/admin_request_controller.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method generate_upload_url has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def generate_upload_url
    if params[:incoming_message_id]
      incoming_message = IncomingMessage.find(params[:incoming_message_id])
      email = incoming_message.from_email
      name = incoming_message.safe_mail_from || @info_request.public_body.name
Severity: Minor
Found in app/controllers/admin_request_controller.rb - About 1 hr to fix

    Method update has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def update
        old_title = @info_request.title
        old_prominence = @info_request.prominence
        old_described_state = @info_request.described_state
        old_awaiting_description = @info_request.awaiting_description
    Severity: Minor
    Found in app/controllers/admin_request_controller.rb - About 1 hr to fix

      Method hide has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def hide
          ActiveRecord::Base.transaction do
            subject = params[:subject]
            explanation = params[:explanation]
            @info_request.prominence = "requester_only"
      Severity: Minor
      Found in app/controllers/admin_request_controller.rb - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              destination_public_body = PublicBody.find_by_url_name(params[:public_body_url_name])
        
              if @info_request.move_to_public_body(destination_public_body,
                                                  :editor => admin_current_user,
                                                  :reindex => true)
        Severity: Minor
        Found in app/controllers/admin_request_controller.rb and 1 other location - About 30 mins to fix
        app/controllers/admin_request_controller.rb on lines 92..102

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              destination_user = User.find_by_url_name(params[:user_url_name])
        
              if @info_request.move_to_user(destination_user,
                                            :editor => admin_current_user,
                                            :reindex => true)
        Severity: Minor
        Found in app/controllers/admin_request_controller.rb and 1 other location - About 30 mins to fix
        app/controllers/admin_request_controller.rb on lines 104..114

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 32.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status