Sign upLogin

mysociety/alaveteli

View on GitHub
Star
app/controllers/application_controller.rb

Summary

Maintainability
C
1 day
Test Coverage

Class ApplicationController has 37 methods (exceeds 20 allowed). Consider refactoring.
Open

class ApplicationController < ActionController::Base
  class PermissionDenied < StandardError
  end

  class RouteNotFound < StandardError
Severity: Minor
Found in app/controllers/application_controller.rb - About 4 hrs to fix

    File application_controller.rb has 336 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    class ApplicationController < ActionController::Base
  class PermissionDenied < StandardError
  end

  class RouteNotFound < StandardError
    Severity: Minor
    Found in app/controllers/application_controller.rb - About 4 hrs to fix

      Method render_exception has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def render_exception(exception)
    # In development let Rails handle the exception with its stack trace
    # templates.
    raise exception if Rails.application.config.consider_all_requests_local
      Severity: Minor
      Found in app/controllers/application_controller.rb - About 1 hr to fix

        Method perform_search has 6 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          def perform_search(models, query, sortby, collapse, per_page = 25, this_page = nil)
        Severity: Minor
        Found in app/controllers/application_controller.rb - About 45 mins to fix

          Method check_in_post_redirect has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            def check_in_post_redirect
    if params[:post_redirect]
      if session[:post_redirect_token]
        post_redirect =
          PostRedirect.find_by_token(session[:post_redirect_token])
          Severity: Minor
          Found in app/controllers/application_controller.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          There are no issues that match your filters.

          Category
          Status