Sign upLogin

mysociety/alaveteli

View on GitHub
Star
app/controllers/attachments_controller.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Class AttachmentsController has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

class AttachmentsController < ApplicationController
  include FragmentCachable
  include InfoRequestHelper
  include PublicTokenable
Severity: Minor
Found in app/controllers/attachments_controller.rb - About 2 hrs to fix

    Method cache_attachments has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      def cache_attachments
    if !params[:skip_cache].nil?
      yield
    else
      if foi_fragment_cache_exists?(cache_key_path)
    Severity: Minor
    Found in app/controllers/attachments_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method ensure_masked has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

      def ensure_masked
    if @attachment.masked?
      yield
    else
      FoiAttachmentMaskJob.perform_later(@attachment)
    Severity: Minor
    Found in app/controllers/attachments_controller.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method authenticate_attachment has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def authenticate_attachment
    # Test for hidden
    if cannot?(:read, @info_request)
      request.format = :html
      return render_hidden
    Severity: Minor
    Found in app/controllers/attachments_controller.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status