Sign upLogin

mysociety/alaveteli

View on GitHub
Star
app/models/raw_email.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method valid_to_reply_to? has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

  def valid_to_reply_to?
    email = from_email.try(:downcase)

    # check validity of email
    return false if email.nil? || !MySociety::Validate.is_valid_email(email)
Severity: Minor
Found in app/models/raw_email.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

    return false if empty_return_path?
Severity: Major
Found in app/models/raw_email.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

        return false if auto_submitted?
    Severity: Major
    Found in app/models/raw_email.rb - About 30 mins to fix

      There are no issues that match your filters.

      Category
      Status