Sign upLogin

nagix/chartjs-plugin-datasource

View on GitHub
Star

Showing 40 of 40 total issues

Identical blocks of code found in 2 locations. Consider refactoring.
Open

function getPointData(arrays, datasetLabels, datapointLabels) {
    var lookup = {};
    var result = [];
    var array, obj, datapointLabel, datapointValue, i, j, ilen, jlen;
Severity: Major
Found in src/datasources/datasource.csv.js and 1 other location - About 1 day to fix
src/datasources/datasource.sheet.js on lines 149..173

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 265.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

function getPointData(arrays, datasetLabels, datapointLabels) {
    var lookup = {};
    var result = [];
    var array, obj, datapointLabel, datapointValue, i, j, ilen, jlen;
Severity: Major
Found in src/datasources/datasource.sheet.js and 1 other location - About 1 day to fix
src/datasources/datasource.csv.js on lines 96..120

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 265.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

function convertDatapointLabels(labels, mapping) {
    var keys = Object.keys(mapping);
    var result = labels.slice();
    var key, index, i, ilen;
Severity: Major
Found in src/datasources/datasource.csv.js and 1 other location - About 5 hrs to fix
src/datasources/datasource.sheet.js on lines 134..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 147.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Identical blocks of code found in 2 locations. Consider refactoring.
Open

function convertDatapointLabels(labels, mapping) {
    var keys = Object.keys(mapping);
    var result = labels.slice();
    var key, index, i, ilen;
Severity: Major
Found in src/datasources/datasource.sheet.js and 1 other location - About 5 hrs to fix
src/datasources/datasource.csv.js on lines 81..94

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 147.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function query has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

function query(obj, expr) {
    var regex = /(?:,|^)\s*(?:"([^"]*)"|'([^']*)'|([^,\s]*))/gi;
    var result = [];
    var matches, bracketKey, dotKey, nextExprWithDot, nextExpr, quotedKey, subset, i, ilen, keys;
Severity: Minor
Found in src/datasources/datasource.json.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function convert has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

    convert: function(input) {
        var me = this;
        var options = me._options;
        var workbook = XLSX.read(new Uint8Array(input), {type: 'array'});
        var dataRange = parseExpression(workbook, datasourceHelpers.valueOrDefault(options.data, ''));
Severity: Minor
Found in src/datasources/datasource.sheet.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function convert has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

    convert: function(input) {
        var me = this;
        var options = me._options;
        var arrays = csvToArrays(input, options.delimiter);
        var datasets = [];
Severity: Minor
Found in src/datasources/datasource.csv.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function exports has 72 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(karma) {
    const args = karma.args || {};
    const regex = args.watch ? /\.js$/ : /\.min\.js$/;
    const build = builds.filter((v) => v.output.file.match(regex))[0];
Severity: Major
Found in karma.config.js - About 2 hrs to fix

    Function mergeData has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

    function mergeData(target, source) {
    var sourceDatasets = source.datasets;
    var targetDatasets = target.datasets;
    var sourceLabels = source.labels;
    var targetLabels = target.labels;
    Severity: Minor
    Found in src/plugins/plugin.datasource.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function convert has 67 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        convert: function(input) {
        var me = this;
        var options = me._options;
        var workbook = XLSX.read(new Uint8Array(input), {type: 'array'});
        var dataRange = parseExpression(workbook, datasourceHelpers.valueOrDefault(options.data, ''));
    Severity: Major
    Found in src/datasources/datasource.sheet.js - About 2 hrs to fix

      Function convert has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

          convert: function(input) {
        var me = this;
        var options = me._options;
        var datasets = [];
        var datasetLabels, indexLabels, data, arrays, i, ilen;
      Severity: Minor
      Found in src/datasources/datasource.json.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function convert has 56 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          convert: function(input) {
        var me = this;
        var options = me._options;
        var datasets = [];
        var datasetLabels, indexLabels, data, arrays, i, ilen;
      Severity: Major
      Found in src/datasources/datasource.json.js - About 2 hrs to fix

        Function convert has 54 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            convert: function(input) {
        var me = this;
        var options = me._options;
        var arrays = csvToArrays(input, options.delimiter);
        var datasets = [];
        Severity: Major
        Found in src/datasources/datasource.csv.js - About 2 hrs to fix

          Function csvToArrays has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
          Open

          function csvToArrays(str, delimiter) {
    var regex = new RegExp('(' + delimiter +
        '|\r?\n(?!$)|\r(?!$)|^(?!$))(?:"((?:\\.|""|[^\\"])*)"|([^' + delimiter + '"\r\n]*))', 'gi');
    var array = [];
    var arrays = [array];
          Severity: Minor
          Found in src/datasources/datasource.csv.js - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  for (i = 0, ilen = Math.max(datasetLabels.length, data.length); i < ilen; ++i) {
            datasets.push({
                label: datasetLabels[i],
                data: data[i]
            });
          Severity: Major
          Found in src/datasources/datasource.json.js and 1 other location - About 2 hrs to fix
          src/datasources/datasource.sheet.js on lines 254..259

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 75.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                  for (i = 0, ilen = Math.max(datasetLabels.length, data.length); i < ilen; ++i) {
            datasets.push({
                label: datasetLabels[i],
                data: data[i]
            });
          Severity: Major
          Found in src/datasources/datasource.sheet.js and 1 other location - About 2 hrs to fix
          src/datasources/datasource.json.js on lines 193..198

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 75.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if (options.datasetLabels) {
                datasetLabels = query(parseExpression(workbook, options.datasetLabels), {header: true});
            } else if (detected) {
                if (indexLabels) {
                    indexLabels.shift();
          Severity: Major
          Found in src/datasources/datasource.sheet.js and 1 other location - About 1 hr to fix
          src/datasources/datasource.sheet.js on lines 226..233

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 74.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if (options.indexLabels) {
                indexLabels = query(parseExpression(workbook, options.indexLabels), {header: true});
            } else if (detected) {
                if (datasetLabels) {
                    datasetLabels.shift();
          Severity: Major
          Found in src/datasources/datasource.sheet.js and 1 other location - About 1 hr to fix
          src/datasources/datasource.sheet.js on lines 210..217

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 74.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function query has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
          Open

          function query(sheetRange, options) {
    var sheet = sheetRange.sheet;
    var range = sheetRange.range;
    var r = options && options.columnOriented ? 'c' : 'r';
    var c = options && options.columnOriented ? 'r' : 'c';
          Severity: Minor
          Found in src/datasources/datasource.sheet.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getPointData has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
          Open

          function getPointData(arrays, datasetLabels, datapointLabelMapping) {
    var keys = Object.keys(datapointLabelMapping);
    var datapointLabelLookup = {};
    var datasetLabelLookup = {};
    var result = [];
          Severity: Minor
          Found in src/datasources/datasource.json.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language