Sign upLogin

nagix/chartjs-plugin-datasource

View on GitHub
Star

Showing 40 of 40 total issues

Function getPointData has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

function getPointData(arrays, datasetLabels, datapointLabelMapping) {
    var keys = Object.keys(datapointLabelMapping);
    var datapointLabelLookup = {};
    var datasetLabelLookup = {};
    var result = [];
Severity: Minor
Found in src/datasources/datasource.json.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function query has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function query(obj, expr) {
    var regex = /(?:,|^)\s*(?:"([^"]*)"|'([^']*)'|([^,\s]*))/gi;
    var result = [];
    var matches, bracketKey, dotKey, nextExprWithDot, nextExpr, quotedKey, subset, i, ilen, keys;
Severity: Minor
Found in src/datasources/datasource.json.js - About 1 hr to fix

    Function mergeData has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function mergeData(target, source) {
    var sourceDatasets = source.datasets;
    var targetDatasets = target.datasets;
    var sourceLabels = source.labels;
    var targetLabels = target.labels;
    Severity: Minor
    Found in src/plugins/plugin.datasource.js - About 1 hr to fix

      Function parseExpression has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function parseExpression(workbook, expr) {
    var matches, sheetName, sheet, rangeExpr, ref, range, refRange;

    while (expr) {
        if (expr.match(/^(([A-Z]+\d*|[A-Z]*\d+):([A-Z]+\d*|[A-Z]*\d+)|[A-Z]+\d+)$/)) {
      Severity: Minor
      Found in src/datasources/datasource.sheet.js - About 1 hr to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                    if (options.datasetLabels) {
                datasetLabels = query(parseExpression(workbook, options.datasetLabels), {columnOriented: true, header: true});
            } else if (detected) {
                datasetLabels = getRowHeader(dataRange);
            }
        Severity: Major
        Found in src/datasources/datasource.sheet.js and 2 other locations - About 1 hr to fix
        src/datasources/datasource.sheet.js on lines 205..209
        src/datasources/datasource.sheet.js on lines 237..241

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                    if (options.datapointLabels) {
                datapointLabels = query(parseExpression(workbook, options.datapointLabels), {columnOriented: true, header: true});
            } else if (detected) {
                datapointLabels = getRowHeader(dataRange);
            }
        Severity: Major
        Found in src/datasources/datasource.sheet.js and 2 other locations - About 1 hr to fix
        src/datasources/datasource.sheet.js on lines 205..209
        src/datasources/datasource.sheet.js on lines 221..225

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                    if (options.indexLabels) {
                indexLabels = query(parseExpression(workbook, options.indexLabels), {columnOriented: true, header: true});
            } else if (detected) {
                indexLabels = getRowHeader(dataRange);
            }
        Severity: Major
        Found in src/datasources/datasource.sheet.js and 2 other locations - About 1 hr to fix
        src/datasources/datasource.sheet.js on lines 221..225
        src/datasources/datasource.sheet.js on lines 237..241

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 62.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function getPointData has 31 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function getPointData(arrays, datasetLabels, datapointLabelMapping) {
    var keys = Object.keys(datapointLabelMapping);
    var datapointLabelLookup = {};
    var datasetLabelLookup = {};
    var result = [];
        Severity: Minor
        Found in src/datasources/datasource.json.js - About 1 hr to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (range.e.c === -1) {
            range.e = {c: refRange.e.c, r: range.e.r};
        }
          Severity: Major
          Found in src/datasources/datasource.sheet.js and 1 other location - About 1 hr to fix
          src/datasources/datasource.sheet.js on lines 30..32

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (range.s.c === -1) {
            range.s = {c: refRange.s.c, r: range.s.r};
        }
          Severity: Major
          Found in src/datasources/datasource.sheet.js and 1 other location - About 1 hr to fix
          src/datasources/datasource.sheet.js on lines 33..35

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 59.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (isNaN(range.e.r)) {
            range.e = {c: range.e.c, r: refRange.e.r};
        }
          Severity: Major
          Found in src/datasources/datasource.sheet.js and 1 other location - About 1 hr to fix
          src/datasources/datasource.sheet.js on lines 36..38

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if (isNaN(range.s.r)) {
            range.s = {c: range.s.c, r: refRange.s.r};
        }
          Severity: Major
          Found in src/datasources/datasource.sheet.js and 1 other location - About 1 hr to fix
          src/datasources/datasource.sheet.js on lines 39..41

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function getPointData has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          function getPointData(arrays, datasetLabels, datapointLabels) {
    var lookup = {};
    var result = [];
    var array, obj, datapointLabel, datapointValue, i, j, ilen, jlen;
          Severity: Minor
          Found in src/datasources/datasource.sheet.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function getPointData has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          function getPointData(arrays, datasetLabels, datapointLabels) {
    var lookup = {};
    var result = [];
    var array, obj, datapointLabel, datapointValue, i, j, ilen, jlen;
          Severity: Minor
          Found in src/datasources/datasource.csv.js - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if (options.indexLabels) {
                indexLabels = query(input, options.indexLabels);
            } else if (arrays) {
                indexLabels = arrays._labels;
            }
          Severity: Minor
          Found in src/datasources/datasource.json.js and 1 other location - About 35 mins to fix
          src/datasources/datasource.json.js on lines 155..159

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if (options.datasetLabels) {
                datasetLabels = query(input, options.datasetLabels);
            } else if (arrays) {
                datasetLabels = arrays._labels;
            }
          Severity: Minor
          Found in src/datasources/datasource.json.js and 1 other location - About 35 mins to fix
          src/datasources/datasource.json.js on lines 173..177

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if (options.datasetLabels) {
                datasetLabels = query(input, options.datasetLabels);
            } else if (arrays) {
                datasetLabels = getSecondLevelLabels(arrays);
            }
          Severity: Minor
          Found in src/datasources/datasource.json.js and 1 other location - About 35 mins to fix
          src/datasources/datasource.json.js on lines 160..164

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                      if (options.indexLabels) {
                indexLabels = query(input, options.indexLabels);
            } else if (arrays) {
                indexLabels = getSecondLevelLabels(arrays);
            }
          Severity: Minor
          Found in src/datasources/datasource.json.js and 1 other location - About 35 mins to fix
          src/datasources/datasource.json.js on lines 168..172

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Avoid too many return statements within this function.
          Open

              return result.length > 1 ? result : result[0];
          Severity: Major
          Found in src/datasources/datasource.json.js - About 30 mins to fix

            Function beforeUpdate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                beforeUpdate: function(chart, options) {
        var me = this;
        var expando = chart[EXPANDO_KEY];
        var url = options.url;
        var type = options.type || me.getType(url);
            Severity: Minor
            Found in src/plugins/plugin.datasource.js - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language