Sign upLogin

netglue/prismic-php-kit

View on GitHub
Star

Showing 316 of 316 total issues

Avoid using static access to class '\Prismic\Document\Fragment\Link\AbstractLink' in method 'v1Factory'.
Open

                $fragment = AbstractLink::abstractFactory($value, $linkResolver);
Severity: Minor
Found in src/Prismic/Document/Fragment/FragmentCollection.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Prismic\Document\Fragment\Link\DocumentLink' in method 'abstractFactory'.
Open

                $link = DocumentLink::linkFactory($value, $linkResolver);
Severity: Minor
Found in src/Prismic/Document/Fragment/Link/AbstractLink.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Prismic\Document\Fragment\Link\FileLink' in method 'abstractFactory'.
Open

                $link = FileLink::linkFactory($value, $linkResolver);
Severity: Minor
Found in src/Prismic/Document/Fragment/Link/AbstractLink.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Prismic\Document\Fragment\ListElement' in method 'factory'.
Open

                        $openList = ListElement::fromTag('ul');
Severity: Minor
Found in src/Prismic/Document/Fragment/RichText.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Prismic\Experiments' in method 'withJsonObject'.
Open

                     : Experiments::parse(new stdClass);
Severity: Minor
Found in src/Prismic/ApiData.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\DateTimeImmutable' in method 'asDateTime'.
Open

        $date = DateTimeImmutable::createFromFormat('!Y-m-d', (string) $this->value);
Severity: Minor
Found in src/Prismic/Document/Fragment/Date.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused private methods such as 'v1Factory'.
Open

    private function v1Factory(string $key, $value, LinkResolver $linkResolver) : void
    {
        $fragment = null;
        switch ($value->type) {
            case 'Image':
Severity: Minor
Found in src/Prismic/Document/Fragment/FragmentCollection.php by phpmd

UnusedPrivateMethod

Since: 0.2

Unused Private Method detects when a private method is declared but is unused.

Example

class Something
{
    private function foo() {} // unused
}

Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

Avoid using static access to class 'Prismic\Document\Fragment\Date' in method 'v2Factory'.
Open

                $this->fragments[$key] = Date::factory($value);
Severity: Minor
Found in src/Prismic/Document/Fragment/FragmentCollection.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Prismic\Document\Fragment\ImageView' in method 'factory'.
Open

            $image->views[$viewName] = ImageView::factory($views->{$viewName}, $linkResolver);
Severity: Minor
Found in src/Prismic/Document/Fragment/Image.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method set uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

        } else {
            $data[$key] = $value;
        }
Severity: Minor
Found in src/Prismic/SearchForm.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class 'Prismic\Document\Fragment\TextElement' in method 'factory'.
Open

                    $item = TextElement::factory($blockData, $linkResolver);
Severity: Minor
Found in src/Prismic/Document/Fragment/RichText.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused private methods such as 'printJson'.
Open

        private function printJson()
        {
            $markup = ['<pre>'];
            $markup[] = htmlentities(json_encode($this->document, JSON_PRETTY_PRINT));
            $markup[] = '</pre>';
Severity: Minor
Found in samples/document-explorer.php by phpmd

UnusedPrivateMethod

Since: 0.2

Unused Private Method detects when a private method is declared but is unused.

Example

class Something
{
    private function foo() {} // unused
}

Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

Avoid using static access to class 'Prismic\Form' in method 'forms'.
Open

                $formObject = Form::withJsonObject($jsonObject);
Severity: Minor
Found in src/Prismic/Api.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Prismic\Exception\ExpiredPreviewTokenException' in method 'previewSession'.
Open

                throw Exception\ExpiredPreviewTokenException::fromResponse($apiResponse);
Severity: Minor
Found in src/Prismic/Api.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Prismic\Predicates' in method 'getByIds'.
Open

        return $this->query(Predicates::in('document.id', $ids), $options);
Severity: Minor
Found in src/Prismic/Api.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused private methods such as 'v2Factory'.
Open

    private function v2Factory(string $key, $value, LinkResolver $linkResolver) : void
    {
        if ($this->isEmptyFragment($value)) {
            return;
        }
Severity: Minor
Found in src/Prismic/Document/Fragment/FragmentCollection.php by phpmd

UnusedPrivateMethod

Since: 0.2

Unused Private Method detects when a private method is declared but is unused.

Example

class Something
{
    private function foo() {} // unused
}

Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

Avoid using static access to class 'Prismic\Document\Fragment\Group' in method 'fromJson'.
Open

            $group = Group::factory($value->value, $linkResolver);
Severity: Minor
Found in src/Prismic/Document/Fragment/Slice.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Prismic\Document\Fragment\FragmentCollection' in method 'fromJson'.
Open

                 ? FragmentCollection::factory($value->primary, $linkResolver)
Severity: Minor
Found in src/Prismic/Document/Fragment/Slice.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Prismic\Document\Fragment\Group' in method 'fromJson'.
Open

        $group = $group ? $group : Group::emptyGroup();
Severity: Minor
Found in src/Prismic/Document/Fragment/Slice.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Prismic\Response' in method 'submit'.
Open

        return Response::fromJsonObject($json, $this->api->getHydrator());
Severity: Minor
Found in src/Prismic/SearchForm.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Severity
Category
Status
Source
Language