Sign upLogin

netglue/prismic-php-kit

View on GitHub
Star

Showing 316 of 316 total issues

Avoid unused private methods such as 'listLinks'.
Open

        private function listLinks() : string
        {
            $markup = [];
            $markup[] = '<div class="list-group mb-4">';
            $markup[] = '<h5 class="list-group-item list-group-item-action active">Linked Documents</h5>';
Severity: Minor
Found in samples/document-explorer.php by phpmd

UnusedPrivateMethod

Since: 0.2

Unused Private Method detects when a private method is declared but is unused.

Example

class Something
{
    private function foo() {} // unused
}

Source https://phpmd.org/rules/unusedcode.html#unusedprivatemethod

Avoid using static access to class 'Prismic\Document\Fragment\Boolean' in method 'v1Factory'.
Open

                $fragment = Boolean::factory($value);
Severity: Minor
Found in src/Prismic/Document/Fragment/FragmentCollection.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method v2Factory() has an NPath complexity of 25920. The configured NPath complexity threshold is 200.
Open

    private function v2Factory(string $key, $value, LinkResolver $linkResolver) : void
    {
        if ($this->isEmptyFragment($value)) {
            return;
        }
Severity: Minor
Found in src/Prismic/Document/Fragment/FragmentCollection.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

Avoid using static access to class '\Prismic\Document\Fragment\Link\AbstractLink' in method 'factory'.
Open

                          ? AbstractLink::abstractFactory($value->linkTo, $linkResolver)
Severity: Minor
Found in src/Prismic/Document/Fragment/ImageView.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Prismic\Response' in method 'submit'.
Open

            return Response::fromJsonObject($json, $this->api->getHydrator());
Severity: Minor
Found in src/Prismic/SearchForm.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Prismic\Experiments' in method 'withJsonObject'.
Open

                     ? Experiments::parse($json->experiments)
Severity: Minor
Found in src/Prismic/ApiData.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid unused private fields such as '$attributes'.
Open

    private $attributes = [];
Severity: Minor
Found in src/Prismic/Document/Fragment/Embed.php by phpmd

UnusedPrivateField

Since: 0.2

Detects when a private field is declared and/or assigned a value, but not used.

Example

class Something
{
    private static $FOO = 2; // Unused
    private $i = 5; // Unused
    private $j = 6;
    public function addOne()
    {
        return $this->j++;
    }
}

Source https://phpmd.org/rules/unusedcode.html#unusedprivatefield

The method factory uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                $group->fragments[] = FragmentCollection::factory($collection, $linkResolver);
            }
Severity: Minor
Found in src/Prismic/Document/Fragment/Group.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class 'Prismic\Document\Fragment\ListElement' in method 'factory'.
Open

                        $openList = ListElement::fromTag('ol');
Severity: Minor
Found in src/Prismic/Document/Fragment/RichText.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Prismic\Api' in method 'getCacheItem'.
Open

            $key = Api::generateCacheKey($this->url());
Severity: Minor
Found in src/Prismic/SearchForm.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Prismic\Exception\RequestFailureException' in method 'submit'.
Open

            throw Exception\RequestFailureException::fromGuzzleException($guzzleException);
Severity: Minor
Found in src/Prismic/SearchForm.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method __construct() contains an exit expression.
Open

                exit;
Severity: Minor
Found in samples/document-explorer.php by phpmd

ExitExpression

Since: 0.2

An exit-expression within regular code is untestable and therefore it should be avoided. Consider to move the exit-expression into some kind of startup script where an error/exception code is returned to the calling environment.

Example

class Foo {
    public function bar($param)  {
        if ($param === 42) {
            exit(23);
        }
    }
}

Source https://phpmd.org/rules/design.html#exitexpression

Avoid using static access to class 'Prismic\Document\Fragment\Group' in method 'v1Factory'.
Open

                $fragment = Group::factory($value, $linkResolver);
Severity: Minor
Found in src/Prismic/Document/Fragment/FragmentCollection.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Prismic\Exception\ExpiredPreviewTokenException' in method 'previewSession'.
Open

            if ($apiResponse && Exception\ExpiredPreviewTokenException::isTokenExpiryResponse($apiResponse)) {
Severity: Minor
Found in src/Prismic/Api.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method htmlAttributes uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
Open

            } else {
                if (is_array($val)) {
                    $val = implode(' ', $val);
                }
            }
Severity: Minor
Found in src/Prismic/Document/Fragment/HtmlHelperTrait.php by phpmd

ElseExpression

Since: 1.4.0

An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

Example

class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

Source https://phpmd.org/rules/cleancode.html#elseexpression

Avoid using static access to class 'Prismic\Predicates' in method 'getById'.
Open

        return $this->queryFirst(Predicates::at('document.id', $id), $options);
Severity: Minor
Found in src/Prismic/Api.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Prismic\Document\Fragment\TextElement' in method 'factory'.
Open

                    $richText->blocks[] = TextElement::factory($blockData, $linkResolver);
Severity: Minor
Found in src/Prismic/Document/Fragment/RichText.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Prismic\Document\Fragment\Date' in method 'v1Factory'.
Open

                $fragment = Date::factory($value);
Severity: Minor
Found in src/Prismic/Document/Fragment/FragmentCollection.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class 'Prismic\Document\Fragment\Image' in method 'v2Factory'.
Open

            $this->fragments[$key] = Image::factory($value, $linkResolver);
Severity: Minor
Found in src/Prismic/Document/Fragment/FragmentCollection.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\Prismic\Document\Fragment\Link\AbstractLink' in method 'v2Factory'.
Open

            $link = AbstractLink::abstractFactory($value, $linkResolver);
Severity: Minor
Found in src/Prismic/Document/Fragment/FragmentCollection.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Severity
Category
Status
Source
Language