Sign upLogin

newscoop/plugin-NewscoopPaywallBundle

View on GitHub
Star
Services/NotificationsService.php

Summary

Maintainability
B
4 hrs
Test Coverage

Method sendNotification has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function sendNotification($code, array $recipients = array(), array $data = array())
    {
        if ($this->systemPreferences->PaywallEmailNotifyEnabled != '1') {
            return;
        }
Severity: Minor
Found in Services/NotificationsService.php - About 1 hr to fix

    Method loadProperMessageTemplateBy has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private function loadProperMessageTemplateBy($code)
    {
        switch ($code) {
            case Emails::USER_CONFIRMATION:
                $message = $this->templatesService->fetchTemplate(
    Severity: Minor
    Found in Services/NotificationsService.php - About 1 hr to fix

      Method __construct has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

              EmailService $emailService,
        SystemPreferencesService $systemPreferences,
        TemplatesService $templatesService,
        PlaceholdersService $placeholdersService,
        EntityManager $em,
      Severity: Minor
      Found in Services/NotificationsService.php - About 45 mins to fix

        Function loadProperMessageTemplateBy has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            private function loadProperMessageTemplateBy($code)
    {
        switch ($code) {
            case Emails::USER_CONFIRMATION:
                $message = $this->templatesService->fetchTemplate(
        Severity: Minor
        Found in Services/NotificationsService.php - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function sendNotification has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

            public function sendNotification($code, array $recipients = array(), array $data = array())
    {
        if ($this->systemPreferences->PaywallEmailNotifyEnabled != '1') {
            return;
        }
        Severity: Minor
        Found in Services/NotificationsService.php - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status