newscoop/plugin-NewscoopPaywallBundle

View on GitHub

Showing 67 of 67 total issues

UserSubscription has 67 functions (exceeds 20 allowed). Consider refactoring.
Open

class UserSubscription implements DiscountableInterface, ProlongableItemInterface, PriceableInterface
{
    const TYPE_PAID = 'P';
    const TYPE_PAID_NOW = 'PN';
    const TYPE_TRIAL = 'T';
Severity: Major
Found in Entity/UserSubscription.php - About 1 day to fix

    File PaywallService.php has 519 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    /**
     * @author Rafał Muszyński <rafal.muszynski@sourcefabric.org>
     * @copyright 2013 Sourcefabric o.p.s.
    Severity: Major
    Found in Services/PaywallService.php - About 1 day to fix

      PaywallService has 48 functions (exceeds 20 allowed). Consider refactoring.
      Open

      class PaywallService
      {
          /** @var EntityManager */
          protected $em;
      
      
      Severity: Minor
      Found in Services/PaywallService.php - About 6 hrs to fix

        Order has 39 functions (exceeds 20 allowed). Consider refactoring.
        Open

        class Order implements OrderInterface
        {
            /**
             * @ORM\Id
             * @ORM\GeneratedValue
        Severity: Minor
        Found in Entity/Order.php - About 5 hrs to fix

          File UserSubscription.php has 377 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
          
          /**
           * @author Rafał Muszyński <rafal.muszynski@sourcefabric.org>
           * @copyright 2014 Sourcefabric o.p.s.
          Severity: Minor
          Found in Entity/UserSubscription.php - About 5 hrs to fix

            File AdminController.php has 325 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
            
            /**
             * @author Rafał Muszyński <rafal.muszynski@sourcefabric.org>
             * @copyright 2013 Sourcefabric o.p.s.
            Severity: Minor
            Found in Controller/AdminController.php - About 3 hrs to fix

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                  public function deleteAction(Request $request, Currency $currency)
                  {
                      $this->hasPermission(Permissions::CURRENCIES_MANAGE);
                      $translator = $this->get('translator');
                      if ($this->findByCode($currency)) {
              Severity: Major
              Found in Controller/CurrencyController.php and 2 other locations - About 3 hrs to fix
              Controller/DiscountController.php on lines 75..90
              Controller/UserOrderController.php on lines 77..92

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 154.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                  public function deleteAction(Request $request, Discount $discount)
                  {
                      $this->hasPermission(Permissions::DISCOUNTS_MANAGE);
                      $translator = $this->get('translator');
                      if ($this->exists($discount)) {
              Severity: Major
              Found in Controller/DiscountController.php and 2 other locations - About 3 hrs to fix
              Controller/CurrencyController.php on lines 119..134
              Controller/UserOrderController.php on lines 77..92

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 154.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 3 locations. Consider refactoring.
              Open

                  public function deleteAction(Request $request, Order $order)
                  {
                      $this->hasPermission(Permissions::ORDERS_MANAGE);
                      $translator = $this->get('translator');
                      if ($this->exists($order)) {
              Severity: Major
              Found in Controller/UserOrderController.php and 2 other locations - About 3 hrs to fix
              Controller/CurrencyController.php on lines 119..134
              Controller/DiscountController.php on lines 75..90

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 154.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Subscription has 29 functions (exceeds 20 allowed). Consider refactoring.
              Open

              class Subscription implements Translatable, PriceableInterface
              {
                  /**
                   * @ORM\Id()
                   * @ORM\GeneratedValue(strategy="AUTO")
              Severity: Minor
              Found in Entity/Subscription.php - About 3 hrs to fix

                Function instantiateOrderItems has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function instantiateOrderItems(array $items = array())
                    {
                        try {
                            $order = new Order();
                            $order->setCurrency($this->context->getCurrency());
                Severity: Minor
                Found in Services/OrderService.php - About 2 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method buildForm has 66 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function buildForm(FormBuilderInterface $builder, array $options)
                    {
                        $builder
                        ->add('subscription', 'entity', array(
                            'label' => 'paywall.manage.label.subscriptions',
                Severity: Major
                Found in Form/Type/OrderItemType.php - About 2 hrs to fix

                  Method getListByCriteria has 65 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function getListByCriteria(SubscriptionCriteria $criteria, $returnQuery = false, $valid = false)
                      {
                          $qb = $this->createQueryBuilder('s');
                          $list = new ListResult();
                  
                  
                  Severity: Major
                  Found in Entity/Repository/UserSubscriptionRepository.php - About 2 hrs to fix

                    Function adminAction has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public function adminAction(Request $request, $id = null)
                        {
                            $em = $this->getDoctrine()->getManager();
                            if ($id) {
                                $this->hasPermission(Permissions::SUBSCRIPTIONS_MANAGE);
                    Severity: Minor
                    Found in Controller/AdminController.php - About 2 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method indexAction has 60 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public function indexAction(Request $request)
                        {
                            $this->hasPermission(Permissions::CONFIGURE);
                            $em = $this->getDoctrine()->getManager();
                            $preferencesService = $this->container->get('system_preferences_service');
                    Severity: Major
                    Found in Controller/ConfigurePaywallController.php - About 2 hrs to fix

                      Method createItemAction has 58 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          public function createItemAction(Request $request, Order $order)
                          {
                              $this->hasPermission(Permissions::ORDERS_MANAGE);
                              $em = $this->get('em');
                              $activeOnes = $this->getActiveSubscriptions($request->getLocale());
                      Severity: Major
                      Found in Controller/UserOrderController.php - About 2 hrs to fix

                        Method addSubscriptionAction has 57 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function addSubscriptionAction(Request $request, Order $order)
                            {
                                $this->hasPermission(Permissions::ORDERS_MANAGE);
                                $subscriptionService = $this->container->get('paywall.subscription.service');
                                $subscription = $subscriptionService->create();
                        Severity: Major
                        Found in Controller/UsersSubscriptionsController.php - About 2 hrs to fix

                          Method durationAction has 56 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function durationAction(Request $request, $id = null)
                              {
                                  $em = $this->getDoctrine()->getManager();
                                  $duration = new Duration();
                                  $form = $this->createForm(new DurationType(), $duration);
                          Severity: Major
                          Found in Controller/AdminController.php - About 2 hrs to fix

                            Method adminAction has 55 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public function adminAction(Request $request, $id = null)
                                {
                                    $em = $this->getDoctrine()->getManager();
                                    if ($id) {
                                        $this->hasPermission(Permissions::SUBSCRIPTIONS_MANAGE);
                            Severity: Major
                            Found in Controller/AdminController.php - About 2 hrs to fix

                              Modification has 21 functions (exceeds 20 allowed). Consider refactoring.
                              Open

                              class Modification
                              {
                                  /**
                                   * @ORM\Id
                                   * @ORM\GeneratedValue
                              Severity: Minor
                              Found in Entity/Modification.php - About 2 hrs to fix
                                Severity
                                Category
                                Status
                                Source
                                Language