Sign upLogin

newscoop/plugin-NewscoopPaywallBundle

View on GitHub
Star

Showing 67 of 67 total issues

Function getListByCriteria has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    public function getListByCriteria(SubscriptionCriteria $criteria, $returnQuery = false, $valid = false)
    {
        $qb = $this->createQueryBuilder('s');
        $list = new ListResult();
Severity: Minor
Found in Entity/Repository/UserSubscriptionRepository.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method instantiateOrderItems has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private function instantiateOrderItems(array $items = array())
    {
        try {
            $order = new Order();
            $order->setCurrency($this->context->getCurrency());
Severity: Minor
Found in Services/OrderService.php - About 1 hr to fix

    Function indexAction has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        public function indexAction(Request $request)
    {
        $this->hasPermission(Permissions::CONFIGURE);
        $em = $this->getDoctrine()->getManager();
        $preferencesService = $this->container->get('system_preferences_service');
    Severity: Minor
    Found in Controller/ConfigurePaywallController.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function step2Action has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

        public function step2Action(Request $request, $id = null)
    {
        $em = $this->getDoctrine()->getManager();
        $create = false;
        if ($id) {
    Severity: Minor
    Found in Controller/AdminController.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method step2Action has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function step2Action(Request $request, $id = null)
    {
        $em = $this->getDoctrine()->getManager();
        $create = false;
        if ($id) {
    Severity: Minor
    Found in Controller/AdminController.php - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function getSections($id)
    {
        $sections = $this->em->getRepository('Newscoop\PaywallBundle\Entity\Section')
            ->findBy(array(
                'subscription' => $id,
      Severity: Major
      Found in Services/PaywallService.php and 1 other location - About 1 hr to fix
      Services/PaywallService.php on lines 215..235

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 113.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function getArticles($id)
    {
        $articles = $this->em->getRepository('Newscoop\PaywallBundle\Entity\Article')
            ->findBy(array(
                'subscription' => $id,
      Severity: Major
      Found in Services/PaywallService.php and 1 other location - About 1 hr to fix
      Services/PaywallService.php on lines 186..206

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 113.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function updateOrCreate has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function updateOrCreate(array $managedCurrencies, $code, $rate)
    {
        if (!empty($managedCurrencies)) {
            foreach ($managedCurrencies as $currency) {
                if ($currency->getCode() !== $this->baseCurrency) {
      Severity: Minor
      Found in Importer/AbstractImporter.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function apply has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          private function apply(UserSubscription $subscription, SubscriptionData $data)
    {
        if ($data->userId) {
            $user = $this->em->getRepository('Newscoop\Entity\User')->getOneActiveUser($data->userId, false)->getOneOrNullResult();
            if ($user) {
      Severity: Minor
      Found in Services/PaywallService.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function addSubscriptionAction has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

          public function addSubscriptionAction(Request $request, Order $order)
    {
        $this->hasPermission(Permissions::ORDERS_MANAGE);
        $subscriptionService = $this->container->get('paywall.subscription.service');
        $subscription = $subscriptionService->create();
      Severity: Minor
      Found in Controller/UsersSubscriptionsController.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method buildForm has 39 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function buildForm(FormBuilderInterface $builder, array $options)
    {
        $builder
        ->add('name', null, array(
            'label' => 'paywall.step1.form.label.name',
      Severity: Minor
      Found in Form/Type/SubscriptionConfType.php - About 1 hr to fix

        Method buildForm has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function buildForm(FormBuilderInterface $builder, array $options)
    {
        $builder
            ->add('name', 'text', array(
                'label' => 'paywall.manage.label.name',
        Severity: Minor
        Found in Form/Type/DiscountType.php - About 1 hr to fix

          Method getListByCriteria has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function getListByCriteria($criteria, $returnQuery = false)
    {
        $qb = $this->createQueryBuilder('s');

        $qb->select('s', 'r', 'd')
          Severity: Minor
          Found in Entity/Repository/SubscriptionRepository.php - About 1 hr to fix

            Method apply has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function apply(UserSubscription $subscription, SubscriptionData $data)
    {
        if ($data->userId) {
            $user = $this->em->getRepository('Newscoop\Entity\User')->getOneActiveUser($data->userId, false)->getOneOrNullResult();
            if ($user) {
            Severity: Minor
            Found in Services/PaywallService.php - About 1 hr to fix

              Method buildForm has 32 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public function buildForm(FormBuilderInterface $builder, array $options)
    {
        $builder
        ->add('value', 'integer', array(
            'constraints' => array(
              Severity: Minor
              Found in Form/Type/DurationType.php - About 1 hr to fix

                Method sendNotification has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    public function sendNotification($code, array $recipients = array(), array $data = array())
    {
        if ($this->systemPreferences->PaywallEmailNotifyEnabled != '1') {
            return;
        }
                Severity: Minor
                Found in Services/NotificationsService.php - About 1 hr to fix

                  Method sidebarAction has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function sidebarAction(Request $request, $articleNumber, $articleLanguage, $allowed = false)
    {
        $entityManager = $this->get('em');
        $templateId = $request->request->get('paywallTemplateSubscriptionId');
        $templatesProvider = $this->get('newscoop_paywall.subscription_template_provider');
                  Severity: Minor
                  Found in Controller/HookController.php - About 1 hr to fix

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                        public function indexAction(Request $request)
    {
        $this->hasPermission(Permissions::PAYMENTS_VIEW);
        $query = $this->getRepository()->findAllAvailable();
        $paginator = $this->get('knp_paginator');
                    Severity: Major
                    Found in Controller/PaymentController.php and 2 other locations - About 1 hr to fix
                    Controller/CurrencyController.php on lines 26..42
                    Controller/UserOrderController.php on lines 27..43

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 106.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                        public function indexAction(Request $request)
    {
        $this->hasPermission(Permissions::CURRENCIES_VIEW);
        $query = $this->getRepository()->findAllAvailable();
        $paginator = $this->get('knp_paginator');
                    Severity: Major
                    Found in Controller/CurrencyController.php and 2 other locations - About 1 hr to fix
                    Controller/PaymentController.php on lines 25..41
                    Controller/UserOrderController.php on lines 27..43

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 106.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                        public function indexAction(Request $request)
    {
        $this->hasPermission(Permissions::ORDERS_VIEW);
        $query = $this->getOrderRepository()->findOrders();
        $paginator = $this->get('knp_paginator');
                    Severity: Major
                    Found in Controller/UserOrderController.php and 2 other locations - About 1 hr to fix
                    Controller/CurrencyController.php on lines 26..42
                    Controller/PaymentController.php on lines 25..41

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 106.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Severity
                    Category
                    Status
                    Source
                    Language