nheyek/SDP-2018

View on GitHub
app/src/main/java/ch/epfl/sweng/studyup/LoginActivity.java

Summary

Maintainability
A
3 hrs
Test Coverage

Method loadInterface has 39 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private void loadInterface(String lang) {

        viewPager = findViewById(R.id.viewPager);
        sliderDotsLayout = findViewById(R.id.SliderDots);

Severity: Minor
Found in app/src/main/java/ch/epfl/sweng/studyup/LoginActivity.java - About 1 hr to fix

    Method attemptLoginFromCache has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        private boolean attemptLoginFromCache() throws Exception {
    
            FileCacher<List<String>> loginPersistenceCache = new FileCacher<>(this, PERSIST_LOGIN_FILENAME);
    
            try {
    Severity: Minor
    Found in app/src/main/java/ch/epfl/sweng/studyup/LoginActivity.java - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method onLoginButtonClick has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public void onLoginButtonClick(View view) {
    
            RadioGroup roles = findViewById(R.id.StudentOrTeacherButtons);
            RadioButton checkedRole = findViewById(roles.getCheckedRadioButtonId());
            if (checkedRole == null) {
    Severity: Minor
    Found in app/src/main/java/ch/epfl/sweng/studyup/LoginActivity.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method onCreate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        @Override
        protected void onCreate(Bundle savedInstanceState) {
            super.onCreate(savedInstanceState);
            setContentView(R.layout.activity_login);
    
    
    Severity: Minor
    Found in app/src/main/java/ch/epfl/sweng/studyup/LoginActivity.java - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status