Sign upLogin

nheyek/SDP-2018

View on GitHub
Star
app/src/main/java/ch/epfl/sweng/studyup/player/HomeActivity.java

Summary

Maintainability
C
1 day
Test Coverage

File HomeActivity.java has 310 lines of code (exceeds 250 allowed). Consider refactoring.
Open

package ch.epfl.sweng.studyup.player;

import android.Manifest;
import android.annotation.SuppressLint;
import android.app.job.JobInfo;
Severity: Minor
Found in app/src/main/java/ch/epfl/sweng/studyup/player/HomeActivity.java - About 3 hrs to fix

    HomeActivity has 27 methods (exceeds 20 allowed). Consider refactoring.
    Open

    public class HomeActivity extends NavigationStudent {
    private final int MY_PERMISSION_REQUEST_FINE_LOCATION = 202;
    private ImageView image_view;

    // Text that will be displayed in the
    Severity: Minor
    Found in app/src/main/java/ch/epfl/sweng/studyup/player/HomeActivity.java - About 3 hrs to fix

      Method loadInterface has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private void loadInterface() {
        // User picture
        ImageButton pic_button = findViewById(R.id.pic_btn);
        pic_button2 = findViewById(R.id.pic_btn2);
        image_view = findViewById(R.id.pic_imageview);
      Severity: Minor
      Found in app/src/main/java/ch/epfl/sweng/studyup/player/HomeActivity.java - About 1 hr to fix

        Method getNbrAnswerPerCourse has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

            private Map<String, Integer> getNbrAnswerPerCourse(List<Question> questions) {
        Map<String, List<String>> answersInfoById = Player.get().getAnsweredQuestion();
        Map<String, Integer> nbrAnswerPerCourse = new HashMap<>();
        for(Question q : questions) {
            String course = q.getCourseName();
        Severity: Minor
        Found in app/src/main/java/ch/epfl/sweng/studyup/player/HomeActivity.java - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            public void populateSpecialQuestsList() {
        final List<SpecialQuest> specialQuestsList = Player.get().getSpecialQuests();

        List<Integer> iconList = new ArrayList<>();
        for (SpecialQuest currSpecialQuest : specialQuestsList) {
        Severity: Major
        Found in app/src/main/java/ch/epfl/sweng/studyup/player/HomeActivity.java and 1 other location - About 2 hrs to fix
        app/src/main/java/ch/epfl/sweng/studyup/specialQuest/AvailableSpecialQuestsActivity.java on lines 40..71

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 166.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

            public void scheduleBackgroundLocation(){
        JobScheduler scheduler = (JobScheduler) getSystemService(Context.JOB_SCHEDULER_SERVICE);
        JobInfo jobInfo = new JobInfo.Builder(BackgroundLocation.BACKGROUND_LOCATION_ID, new ComponentName(this, BackgroundLocation.class)).setPeriodic(15 * 60 * 1000).build();
        scheduler.schedule(jobInfo);
        for(JobInfo job: scheduler.getAllPendingJobs()){
        Severity: Major
        Found in app/src/main/java/ch/epfl/sweng/studyup/player/HomeActivity.java and 1 other location - About 1 hr to fix
        app/src/main/java/ch/epfl/sweng/studyup/utils/navigation/NavigationStudent.java on lines 55..63

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 93.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status