nheyek/SDP-2018

View on GitHub

Showing 124 of 124 total issues

Method onCreate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        setContentView(R.layout.activity_login);

Severity: Minor
Found in app/src/main/java/ch/epfl/sweng/studyup/LoginActivity.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method setupTime has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

        private void setupTime(TextView timeTextview, double progress, long questionDuration) {
            long millisRemaining = (long) (progress * questionDuration);
            long hourRemaining = millisRemaining / (3600 * 1000);
            long minRemaining = (millisRemaining - hourRemaining * 3600 * 1000) / (1000 * 60);
            String timeRemaining;

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method setupLocksAndClickable has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public void setupLocksAndClickable() {
        Set<String> unlockedThemes = Player.get().getUnlockedThemes();

        for (String theme : unlockedThemes) {
            if(theme.equals(SETTINGS_COLOR_GREEN))  {

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method setCourses has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    public void setCourses(List<Course> courses) {
        if(isStudent()) {
            this.coursesEnrolled = new ArrayList<>(courses);
        } else {
            List<Course> oldCourses = getCoursesTeached();
Severity: Minor
Found in app/src/main/java/ch/epfl/sweng/studyup/player/Player.java - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language