Sign upLogin

ninoseki/SimpleWhatWeb

View on GitHub
Star

Showing 506 of 506 total issues

File joomla.rb has 317 lines of code (exceeds 250 allowed). Consider refactoring.
Open

WhatWeb::Plugin.define "Joomla" do
  @author = "Andrew Horton"
  @version = "0.7"
  @description = "Opensource CMS written in PHP. Aggressive version detection compares just 5 files, valid for versions 1.5.0-1.5.22 and 1.6.0-1.6.1."
  @website = "http://joomla.org"
Severity: Minor
Found in lib/whatweb/plugins/joomla.rb - About 3 hrs to fix

    Method passive has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
    Open

      def passive(target)
    m = []

    # x-webobjects-loadaverage
    m << { name: "x-webobjects-loadaverage" } unless target.headers["x-webobjects-loadaverage"].nil?
    Severity: Minor
    Found in lib/whatweb/plugins/webobjects.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method passive has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

      def passive(target)
    m = []

    # Check if the current file is a .htpasswd file
    if target.uri.path =~ /htpasswd/i && target.body =~ /^([0-9a-z\-_]{2,255}:[^\r^\n^\s^:]{1,80})[\r\n\s:]*/i
    Severity: Minor
    Found in lib/whatweb/plugins/htpasswd.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method passive has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

      def passive(target)
    m = []

    # Extract details
    if target.body =~ /^Interesting ports on (.+):[\r]?$/ && target.body =~ /^Starting (n|N)map /
    Severity: Minor
    Found in lib/whatweb/plugins/nmap-log.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method startup has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

      def startup
    # ok, set up @rfile. open once.
    whatweb_folder = __dir__
    country_db = whatweb_folder + "/country-ips.dat"
    Severity: Minor
    Found in lib/whatweb/plugins/country.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method passive has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

      def passive(target)
    m = []

    if /<TITLE> WEB POSTING INFORMATION <\/TITLE>/i.match?(target.body)
    Severity: Minor
    Found in lib/whatweb/plugins/web-publishing-wizard.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method passive has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

      def passive(target)
    m = []

    if target.body =~ /^## + RFI Scan & Exploit \(Exploit per engine\)        ##/ || target.body =~ /^######################################################/ || target.body =~ /^##   perl feelscanz.pl <chan w\/o #> <server> <port> ##/ || target.body =~ /##\[ RUTIN SEARCH ENGINE \]##/ || target.body =~ /^## + Fixed cryptz command \(v4.5\)/ && target.body =~ /^#!\/usr\/bin\/perl/
    Severity: Minor
    Found in lib/whatweb/plugins/rfi-scanner-bot.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method passive has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

      def passive(target)
    m = []

    if /=~=~=~=~=~=~=~=~=~=~=~= PuTTY log [0-9]{4}.[0-9]{2}.[0-9]{2} [0-9]{2}:[0-9]{2}:[0-9]{2} =~=~=~=~=~=~=~=~=~=~=~=/.match?(target.body)
    Severity: Minor
    Found in lib/whatweb/plugins/putty-log.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method passive has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

      def passive(_target)
    m = []

    if @rfile && @ip && @ip =~ /^([0-9]{1,3}\.){3}[0-9]{1,3}$/
      @rfile.seek(0, IO::SEEK_END)
    Severity: Minor
    Found in lib/whatweb/plugins/country.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method aggressive has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

      def aggressive(target)
    m = []

    # Local File Path Detection # Find application base path
    if /^[^\n]*\/(viewcvs|viewvc)/i.match?(target.uri.path)
    Severity: Minor
    Found in lib/whatweb/plugins/viewvc.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method passive has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

      def passive(target)
    m = []

    # Extract vcard Details
    if target.body =~ /^BEGIN:VCARD[\s]*$/i && target.body =~ /^END:VCARD/i
    Severity: Minor
    Found in lib/whatweb/plugins/vcard.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method passive has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

      def passive(target)
    m = []

    # Default Title
    if /<title>Pharos LPC[^<]*<\/title>/.match?(target.body)
    Severity: Minor
    Found in lib/whatweb/plugins/pharos-lpc.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method passive has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

      def passive(target)
    m = []

    # spiceworks_session cookie
    # Session cookie format: URL encoded base64 string beginning with "BAh7"
    Severity: Minor
    Found in lib/whatweb/plugins/spiceworks.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method aggressive has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def aggressive(target)
    m = []

    versions = Hash[
                        "5.0.0" =>
    Severity: Major
    Found in lib/whatweb/plugins/concrete5.rb - About 2 hrs to fix

      Method passive has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

        def passive(target)
    m = []

    # /administrator/ # Confirm the presence of Mambo with 100% certainty
    if target.uri.path =~ /\/administrator\// && (target.body =~ /<div id="mambo"><img src="[^"]*\/images\/header_text.png" alt="Mambo Logo" \/><\/div>/ || target.body =~ /<a href="http:\/\/mambo-foundation.org">Mambo<\/a> is Free Software released under the GNU\/GPL License.<\/div>/ || target.body =~ /<title>[^<]+ Administration \[Mambo( Open Source)?\]<\/title>/)
      Severity: Minor
      Found in lib/whatweb/plugins/mambo.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method passive has 56 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def passive(target)
    m = []

    # Excel
    if target.body =~ /<DocumentProperties xmlns="urn:schemas-microsoft-com:office:[excel|office]?">/ || target.body =~ /<?mso-application progid="Excel.Sheet"?>/
      Severity: Major
      Found in lib/whatweb/plugins/microsoft-office-xml.rb - About 2 hrs to fix

        Method passive has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

          def passive(target)
    m = []

    # About 62 ShodanHQ results for WWW-Authenticate: Basic realm="LOGIN Enter Password (default is private)"
    # Probably D-Link # HTTP Server Header and WWW-Authenticate Realm
        Severity: Minor
        Found in lib/whatweb/plugins/unknown-router.rb - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method passive has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
        Open

          def passive(target)
    m = []

    # HTTP Server Header # ZyXEL-RomPager
    if /^ZyXEL-RomPager/.match?(target.headers["server"])
        Severity: Minor
        Found in lib/whatweb/plugins/zyxel-router.rb - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def passive(target)
    m = []

    # Detect Title
    if /<title>QCubed Development Framework - Start Page<\/title>/.match?(target.body)
        Severity: Major
        Found in lib/whatweb/plugins/qcubed-development-framework.rb and 1 other location - About 2 hrs to fix
        lib/whatweb/plugins/qcodo-development-framework.rb on lines 32..57

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 79.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def passive(target)
    m = []

    # Detect Title
    if /<title>Qcodo Development Framework - Start Page<\/title>/.match?(target.body)
        Severity: Major
        Found in lib/whatweb/plugins/qcodo-development-framework.rb and 1 other location - About 2 hrs to fix
        lib/whatweb/plugins/qcubed-development-framework.rb on lines 36..61

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 79.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language