Sign upLogin

nofxx/georuby

View on GitHub
Star
lib/geo_ruby/georss.rb

Summary

Maintainability
D
1 day
Test Coverage

Method parse_geometry has a Cognitive Complexity of 52 (exceeds 5 allowed). Consider refactoring.
Open

    def parse_geometry(georss, with_tags)
      georss.strip!
      # check for W3CGeo first
      if georss =~ /<[^:>]*:lat\s*>([^<]*)</
        # if valid, it is W3CGeo
Severity: Minor
Found in lib/geo_ruby/georss.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parse_geometry has 111 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def parse_geometry(georss, with_tags)
      georss.strip!
      # check for W3CGeo first
      if georss =~ /<[^:>]*:lat\s*>([^<]*)</
        # if valid, it is W3CGeo
Severity: Major
Found in lib/geo_ruby/georss.rb - About 4 hrs to fix

    Avoid deeply nested control flow statements.
    Open

            elsif gml =~ /^<\s*[^:>]*:Polygon\s*>/
          if gml =~ /<\s*[^:>]*:posList\s*>([^<]*)/
            xy = Regexp.last_match[1].split(' ')
            @geometry = Polygon.new
            linear_ring = LinearRing.new
    Severity: Major
    Found in lib/geo_ruby/georss.rb - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                if gml =~ /<\s*[^:>]*:posList\s*>([^<]*)/
            xy = Regexp.last_match[1].split(' ')
            @geometry = LineString.new
            0.upto(xy.size / 2 - 1) do |index|
              @geometry << Point.from_x_y(xy[index * 2 + 1].to_f,
      Severity: Major
      Found in lib/geo_ruby/georss.rb - About 45 mins to fix

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                  0.upto(xy.size / 2 - 1) do |index|
            @geometry << Point.from_x_y(xy[index * 2 + 1].to_f,
                                        xy[index * 2].to_f)
        Severity: Minor
        Found in lib/geo_ruby/georss.rb and 1 other location - About 20 mins to fix
        lib/geo_ruby/georss.rb on lines 57..59

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 28.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                    0.upto(xy.size / 2 - 1) do |index|
              @geometry << Point.from_x_y(xy[index * 2 + 1].to_f,
                                          xy[index * 2].to_f)
        Severity: Minor
        Found in lib/geo_ruby/georss.rb and 1 other location - About 20 mins to fix
        lib/geo_ruby/georss.rb on lines 103..105

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 28.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                  0.upto(xy.size / 2 - 1) do |index|
            corners << Point.from_x_y(xy[index * 2 + 1].to_f,
                                      xy[index * 2].to_f)
        Severity: Minor
        Found in lib/geo_ruby/georss.rb and 2 other locations - About 20 mins to fix
        lib/geo_ruby/georss.rb on lines 71..73
        lib/geo_ruby/georss.rb on lines 113..115

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 28.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                  0.upto(xy.size / 2 - 1) do |index|
            linear_ring << Point.from_x_y(xy[index * 2 + 1].to_f,
                                          xy[index * 2].to_f)
        Severity: Minor
        Found in lib/geo_ruby/georss.rb and 2 other locations - About 20 mins to fix
        lib/geo_ruby/georss.rb on lines 71..73
        lib/geo_ruby/georss.rb on lines 121..123

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 28.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                    0.upto(xy.size / 2 - 1) do |index|
              linear_ring << Point.from_x_y(xy[index * 2 + 1].to_f,
                                            xy[index * 2].to_f)
        Severity: Minor
        Found in lib/geo_ruby/georss.rb and 2 other locations - About 20 mins to fix
        lib/geo_ruby/georss.rb on lines 113..115
        lib/geo_ruby/georss.rb on lines 121..123

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 28.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status