nofxx/georuby

View on GitHub
lib/geo_ruby/shp4r/shp.rb

Summary

Maintainability
F
4 days
Test Coverage

File shp.rb has 599 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'date'
require 'fileutils' unless defined?(FileUtils)

module GeoRuby
  module Shp4r
Severity: Major
Found in lib/geo_ruby/shp4r/shp.rb - About 1 day to fix

    Method get_record has 150 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def get_record(index)
            return nil if record_count <= index || index < 0
            dbf_record = @dbf.record(index)
            @shx.seek(100 + 8 * index) # 100 is the header length
            offset, length = @shx.read(8).unpack('N2')
    Severity: Major
    Found in lib/geo_ruby/shp4r/shp.rb - About 6 hrs to fix

      Method commit_add has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
      Open

            def commit_add(index)
              max_x, min_x, max_y, min_y, max_z, min_z, max_m, min_m = @shp.xmax, @shp.xmin, @shp.ymax, @shp.ymin, @shp.zmax, @shp.zmin, @shp.mmax, @shp.mmin
              @added.each do |record|
                @dbf_io << ['20'].pack('H2')
                @dbf.fields.each do |field|
      Severity: Minor
      Found in lib/geo_ruby/shp4r/shp.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method build_shp_geometry has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def build_shp_geometry(geometry)
              m_range = nil
              answer =
              case @shp.shp_type
              when ShpType::POINT
      Severity: Major
      Found in lib/geo_ruby/shp4r/shp.rb - About 2 hrs to fix

        Method commit_add has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def commit_add(index)
                max_x, min_x, max_y, min_y, max_z, min_z, max_m, min_m = @shp.xmax, @shp.xmin, @shp.ymax, @shp.ymin, @shp.zmax, @shp.zmin, @shp.mmax, @shp.mmin
                @added.each do |record|
                  @dbf_io << ['20'].pack('H2')
                  @dbf.fields.each do |field|
        Severity: Minor
        Found in lib/geo_ruby/shp4r/shp.rb - About 1 hr to fix

          Method commit_delete has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def commit_delete
                  @shp_r.rewind
                  header = @shp_r.read(100)
                  @shp_io << header
                  @shx_io << header
          Severity: Minor
          Found in lib/geo_ruby/shp4r/shp.rb - About 1 hr to fix

            Method build_polygon has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  def build_polygon(geometry, str)
                    if geometry.is_a? GeoRuby::SimpleFeatures::Polygon
                      str << [geometry.length,
                        geometry.reduce(0) { |a, e| a + e.length }
                      ].pack('V2')
            Severity: Minor
            Found in lib/geo_ruby/shp4r/shp.rb - About 1 hr to fix

              Method commit_finalize has 8 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                    def commit_finalize(min_x, max_x, min_y, max_y, min_z, max_z, min_m, max_m)
              Severity: Major
              Found in lib/geo_ruby/shp4r/shp.rb - About 1 hr to fix

                Method commit_delete has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                Open

                      def commit_delete
                        @shp_r.rewind
                        header = @shp_r.read(100)
                        @shp_io << header
                        @shx_io << header
                Severity: Minor
                Found in lib/geo_ruby/shp4r/shp.rb - About 45 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method get_record has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                Open

                      def get_record(index)
                        return nil if record_count <= index || index < 0
                        dbf_record = @dbf.record(index)
                        @shx.seek(100 + 8 * index) # 100 is the header length
                        offset, length = @shx.read(8).unpack('N2')
                Severity: Minor
                Found in lib/geo_ruby/shp4r/shp.rb - About 35 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                          str << [geometry.length, geometry.reduce(0) { |a, e| a + e.length }].pack('V2')
                          str << geometry.reduce([0]) do |a, e|
                            a << (a.last + e.length) # last element of the previous array is dropped
                          end.pack("V#{geometry.length}")
                          geometry.each do |ls|
                Severity: Major
                Found in lib/geo_ruby/shp4r/shp.rb and 1 other location - About 1 hr to fix
                lib/geo_ruby/shp4r/shp.rb on lines 646..655

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 54.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                          str << [geometry.length,
                            geometry.reduce(0) { |a, e| a + e.length }
                          ].pack('V2')
                          # last element of the previous array is dropped
                          str << geometry.reduce([0]) do |a, e|
                Severity: Major
                Found in lib/geo_ruby/shp4r/shp.rb and 1 other location - About 1 hr to fix
                lib/geo_ruby/shp4r/shp.rb on lines 614..620

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 54.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                        when ShpType::POLYGONZ
                          str, bbox = create_bbox(geometry)
                          m_range = geometry.m_range
                          build_polygon(geometry, str)
                          build_polygon_zm(geometry, :@z, [bbox[0].z, bbox[1].z], str)
                Severity: Minor
                Found in lib/geo_ruby/shp4r/shp.rb and 2 other locations - About 35 mins to fix
                lib/geo_ruby/shp4r/shp.rb on lines 560..565
                lib/geo_ruby/shp4r/shp.rb on lines 572..577

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 35.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                        when ShpType::MULTIPOINTZ
                          str, bbox = create_bbox(geometry)
                          m_range = geometry.m_range
                          build_multi_point(geometry, str)
                          build_multi_point_zm(geometry, :@z, [bbox[0].z, bbox[1].z], str)
                Severity: Minor
                Found in lib/geo_ruby/shp4r/shp.rb and 2 other locations - About 35 mins to fix
                lib/geo_ruby/shp4r/shp.rb on lines 560..565
                lib/geo_ruby/shp4r/shp.rb on lines 566..571

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 35.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 3 locations. Consider refactoring.
                Open

                        when ShpType::POLYLINEZ
                          str, bbox = create_bbox(geometry)
                          m_range = geometry.m_range
                          build_polyline(geometry, str)
                          build_polyline_zm(geometry, :@z, [bbox[0].z, bbox[1].z], str)
                Severity: Minor
                Found in lib/geo_ruby/shp4r/shp.rb and 2 other locations - About 35 mins to fix
                lib/geo_ruby/shp4r/shp.rb on lines 566..571
                lib/geo_ruby/shp4r/shp.rb on lines 572..577

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 35.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                          linear_rings = Array.new(num_parts) do |i|
                            GeoRuby::SimpleFeatures::LinearRing.from_points(points[(parts[i])...(parts[i + 1])], GeoRuby::SimpleFeatures::DEFAULT_SRID, false, true)
                Severity: Minor
                Found in lib/geo_ruby/shp4r/shp.rb and 1 other location - About 15 mins to fix
                lib/geo_ruby/shp4r/shp.rb on lines 307..308

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 26.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 3 locations. Consider refactoring.
                Open

                          points = Array.new(num_points) do |i|
                            GeoRuby::SimpleFeatures::Point.from_x_y_z_m(xys[i][0], xys[i][1], zs[i], ms[i])
                Severity: Minor
                Found in lib/geo_ruby/shp4r/shp.rb and 2 other locations - About 15 mins to fix
                lib/geo_ruby/shp4r/shp.rb on lines 249..250
                lib/geo_ruby/shp4r/shp.rb on lines 269..270

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 26.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 3 locations. Consider refactoring.
                Open

                          points = Array.new(num_points) do |i|
                            GeoRuby::SimpleFeatures::Point.from_x_y_z_m(xys[i][0], xys[i][1], zs[i], ms[i])
                Severity: Minor
                Found in lib/geo_ruby/shp4r/shp.rb and 2 other locations - About 15 mins to fix
                lib/geo_ruby/shp4r/shp.rb on lines 249..250
                lib/geo_ruby/shp4r/shp.rb on lines 286..287

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 26.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                          line_strings = Array.new(num_parts) do |i|
                            GeoRuby::SimpleFeatures::LineString.from_points(points[(parts[i])...(parts[i + 1])], GeoRuby::SimpleFeatures::DEFAULT_SRID, true, true)
                Severity: Minor
                Found in lib/geo_ruby/shp4r/shp.rb and 1 other location - About 15 mins to fix
                lib/geo_ruby/shp4r/shp.rb on lines 272..273

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 26.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                          linear_rings = Array.new(num_parts) do |i|
                            GeoRuby::SimpleFeatures::LinearRing.from_points(points[(parts[i])...(parts[i + 1])], GeoRuby::SimpleFeatures::DEFAULT_SRID, true, true)
                Severity: Minor
                Found in lib/geo_ruby/shp4r/shp.rb and 1 other location - About 15 mins to fix
                lib/geo_ruby/shp4r/shp.rb on lines 252..253

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 26.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                          line_strings = Array.new(num_parts) do |i|
                            GeoRuby::SimpleFeatures::LineString.from_points(points[(parts[i])...(parts[i + 1])], GeoRuby::SimpleFeatures::DEFAULT_SRID, false, true)
                Severity: Minor
                Found in lib/geo_ruby/shp4r/shp.rb and 1 other location - About 15 mins to fix
                lib/geo_ruby/shp4r/shp.rb on lines 325..326

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 26.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 3 locations. Consider refactoring.
                Open

                          points = Array.new(num_points) do |i|
                            GeoRuby::SimpleFeatures::Point.from_x_y_z_m(xys[i][0], xys[i][1], zs[i], ms[i])
                Severity: Minor
                Found in lib/geo_ruby/shp4r/shp.rb and 2 other locations - About 15 mins to fix
                lib/geo_ruby/shp4r/shp.rb on lines 269..270
                lib/geo_ruby/shp4r/shp.rb on lines 286..287

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 26.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                There are no issues that match your filters.

                Category
                Status