nondev/spoon

View on GitHub

Showing 65 of 65 total issues

Method operators has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    def self.operators(operators={})
      trailing_chars = Hash.new { |hash,symbol| hash[symbol] = [] }

      operators.each_value do |symbol|
        operators.each_value do |op|
Severity: Minor
Found in lib/spoon/parser.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method scope_name has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def scope_name(node)
      content = subtree(node)
      is_self = node.option :is_self
      is_this = node.option :is_this

Severity: Minor
Found in lib/spoon/compiler.rb - About 1 hr to fix

    Method compile has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def compile
          children = @node.children.dup
    
          if @node.option :is_interpolated
            children.each do |child|
    Severity: Minor
    Found in lib/spoon/compiler.rb - About 1 hr to fix

      Method initialize has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def initialize(path = "main")
            @name = File.basename(path, ".*")
              .split('-')
              .collect(&:capitalize)
              .join
      Severity: Minor
      Found in lib/spoon/compiler.rb - About 1 hr to fix

        Method compile has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def compile
              @compiler.scope.add
              children = @node.children.dup
              @content << "#" unless @parent.node.type == :ifdef
              @content << "if (#{subtree(children.shift)})\n"
        Severity: Minor
        Found in lib/spoon/compiler.rb - About 1 hr to fix

          Method cache has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

              def cache
                result = ""
          
                @compiler.static_scope.get.each do |key, value|
                  if value
          Severity: Minor
          Found in lib/spoon/compiler.rb - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method compile has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def compile
                children = @node.children.dup
                left = children.shift
                right = children.shift
                left_children = left.children.dup
          Severity: Minor
          Found in lib/spoon/compiler.rb - About 1 hr to fix

            Method keywords has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                def keywords
                  [
                    :ifdef,
                    :if,
                    :else,
            Severity: Minor
            Found in lib/spoon/lexer.rb - About 1 hr to fix

              Method check_indentation has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                    def check_indentation(source)
                      @current = 0
              
                      while source.matches?(@matcher)
                        source.consume(1)
              Severity: Minor
              Found in lib/spoon/util/indent_parser.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid deeply nested control flow statements.
              Open

                        @content << ": #{type}" unless @parent.node.option(:is_self) || @parent.node.option(:is_this)
              Severity: Major
              Found in lib/spoon/compiler.rb - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                        elsif @node.option(:is_type) && node.option(:is_generic)
                          @content << "#{simple(children.shift)}<"
                
                          children.each do |child|
                            @content << simple(child)
                Severity: Major
                Found in lib/spoon/compiler.rb - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                @content << eol(child) unless child.equal? left.children.last
                  Severity: Major
                  Found in lib/spoon/compiler.rb - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                              elsif @parent.parent != nil && @parent.parent.node.type == :class
                                is_this = left.option :is_this
                                name = simple(left.children.first)
                    
                                if is_this
                    Severity: Major
                    Found in lib/spoon/compiler.rb - About 45 mins to fix

                      Method compile has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                      Open

                          def compile
                            imports = ""
                            classes = ""
                            import_calls = ""
                            push_scope @compiler.name
                      Severity: Minor
                      Found in lib/spoon/compiler.rb - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method to_op has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                      Open

                            def to_op
                              str = trim
                      
                              return "..." if str == ".." || str == "to"
                              return "!" if str == "not"
                      Severity: Minor
                      Found in lib/spoon/util/ast_extensions.rb - About 35 mins to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Avoid too many return statements within this method.
                      Open

                              return "!=" if str == "isnt"
                      Severity: Major
                      Found in lib/spoon/util/ast_extensions.rb - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                return str
                        Severity: Major
                        Found in lib/spoon/util/ast_extensions.rb - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                  return  "==" if str == "is"
                          Severity: Major
                          Found in lib/spoon/util/ast_extensions.rb - About 30 mins to fix

                            Method fix_position has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                            Open

                                  def fix_position(source)
                                    source.bytepos = source.bytepos - @current
                            
                                    if @current <= @prev_stack[@prev_stack.length - 1]
                                      while @last != @current && !@prev_stack.empty?
                            Severity: Minor
                            Found in lib/spoon/util/indent_parser.rb - About 25 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                      @content << subtree(left)
                                      @content << " " unless @node.option :is_chain
                                      @content << operator
                                      @content << " " unless @node.option :is_chain
                                      @content << subtree(right)
                            Severity: Minor
                            Found in lib/spoon/compiler.rb and 1 other location - About 15 mins to fix
                            lib/spoon/compiler.rb on lines 293..297

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 26.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Severity
                            Category
                            Status
                            Source
                            Language