Sign upLogin

nondev/spoon

View on GitHub
Star
lib/spoon/compiler.rb

Summary

Maintainability
F
5 days
Test Coverage

Method compile has a Cognitive Complexity of 57 (exceeds 5 allowed). Consider refactoring.
Open

    def compile
      children = @node.children.dup
      operator = children.shift.to_s
      insert_parens = @parent.node.type == :op && !@parent.node.children.first.to_s.end_with?("=")
Severity: Minor
Found in lib/spoon/compiler.rb - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File compiler.rb has 518 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require "spoon/util/namespace"

module Spoon
  class Compiler
    attr_reader :name
Severity: Major
Found in lib/spoon/compiler.rb - About 1 day to fix

    Method has too many lines. [73/30]
    Open

        def compile
      children = @node.children.dup
      operator = children.shift.to_s
      insert_parens = @parent.node.type == :op && !@parent.node.children.first.to_s.end_with?("=")
    Severity: Minor
    Found in lib/spoon/compiler.rb by rubocop

    This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

    Method compile has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
    Open

        def compile
      children = @node.children.dup

      if @node.option :is_interpolated
        children.each do |child|
    Severity: Minor
    Found in lib/spoon/compiler.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Cyclomatic complexity for compile is too high. [21/6]
    Open

        def compile
      children = @node.children.dup
      operator = children.shift.to_s
      insert_parens = @parent.node.type == :op && !@parent.node.children.first.to_s.end_with?("=")
    Severity: Minor
    Found in lib/spoon/compiler.rb by rubocop

    This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

    An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

    Method scope_name has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
    Open

        def scope_name(node)
      content = subtree(node)
      is_self = node.option :is_self
      is_this = node.option :is_this
    Severity: Minor
    Found in lib/spoon/compiler.rb - About 3 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method compile has 73 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def compile
      children = @node.children.dup
      operator = children.shift.to_s
      insert_parens = @parent.node.type == :op && !@parent.node.children.first.to_s.end_with?("=")
    Severity: Major
    Found in lib/spoon/compiler.rb - About 2 hrs to fix

      Cyclomatic complexity for compile is too high. [13/6]
      Open

          def compile
      children = @node.children.dup

      if @node.option :is_interpolated
        children.each do |child|
      Severity: Minor
      Found in lib/spoon/compiler.rb by rubocop

      This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

      An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

      Cyclomatic complexity for scope_name is too high. [12/6]
      Open

          def scope_name(node)
      content = subtree(node)
      is_self = node.option :is_self
      is_this = node.option :is_this
      Severity: Minor
      Found in lib/spoon/compiler.rb by rubocop

      This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

      An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

      Method has too many lines. [35/30]
      Open

          def scope_name(node)
      content = subtree(node)
      is_self = node.option :is_self
      is_this = node.option :is_this
      Severity: Minor
      Found in lib/spoon/compiler.rb by rubocop

      This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

      Method has too many lines. [33/30]
      Open

          def compile
      children = @node.children.dup

      if @node.option :is_interpolated
        children.each do |child|
      Severity: Minor
      Found in lib/spoon/compiler.rb by rubocop

      This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

      Method compile has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

          def compile
      @compiler.scope.add

      children = @node.children.dup
      type = (@node.option(:is_typed) ? children.shift : false)
      Severity: Minor
      Found in lib/spoon/compiler.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Cyclomatic complexity for compile is too high. [8/6]
      Open

          def compile
      @compiler.scope.add
      children = @node.children.dup
      @content << "#" unless @parent.node.type == :ifdef
      @content << "if (#{subtree(children.shift)})\n"
      Severity: Minor
      Found in lib/spoon/compiler.rb by rubocop

      This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

      An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

      Method has too many lines. [32/30]
      Open

          def initialize(path = "main")
      @name = File.basename(path, ".*")
        .split('-')
        .collect(&:capitalize)
        .join
      Severity: Minor
      Found in lib/spoon/compiler.rb by rubocop

      This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

      Cyclomatic complexity for compile is too high. [7/6]
      Open

          def compile
      @compiler.scope.add

      children = @node.children.dup
      type = (@node.option(:is_typed) ? children.shift : false)
      Severity: Minor
      Found in lib/spoon/compiler.rb by rubocop

      This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

      An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

      Method compile has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          def compile
      @compiler.scope.add
      children = @node.children.dup
      @content << "#" unless @parent.node.type == :ifdef
      @content << "if (#{subtree(children.shift)})\n"
      Severity: Minor
      Found in lib/spoon/compiler.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method scope_name has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def scope_name(node)
      content = subtree(node)
      is_self = node.option :is_self
      is_this = node.option :is_this
      Severity: Minor
      Found in lib/spoon/compiler.rb - About 1 hr to fix

        Method compile has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            def compile
      children = @node.children.dup

      if @node.option :is_interpolated
        children.each do |child|
        Severity: Minor
        Found in lib/spoon/compiler.rb - About 1 hr to fix

          Method initialize has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              def initialize(path = "main")
      @name = File.basename(path, ".*")
        .split('-')
        .collect(&:capitalize)
        .join
          Severity: Minor
          Found in lib/spoon/compiler.rb - About 1 hr to fix

            Method compile has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                def compile
      @compiler.scope.add
      children = @node.children.dup
      @content << "#" unless @parent.node.type == :ifdef
      @content << "if (#{subtree(children.shift)})\n"
            Severity: Minor
            Found in lib/spoon/compiler.rb - About 1 hr to fix

              Method cache has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
              Open

                  def cache
      result = ""

      @compiler.static_scope.get.each do |key, value|
        if value
              Severity: Minor
              Found in lib/spoon/compiler.rb - About 1 hr to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method compile has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  def compile
      children = @node.children.dup
      left = children.shift
      right = children.shift
      left_children = left.children.dup
              Severity: Minor
              Found in lib/spoon/compiler.rb - About 1 hr to fix

                Avoid deeply nested control flow statements.
                Open

                          @content << ": #{type}" unless @parent.node.option(:is_self) || @parent.node.option(:is_this)
                Severity: Major
                Found in lib/spoon/compiler.rb - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                          elsif @node.option(:is_type) && node.option(:is_generic)
          @content << "#{simple(children.shift)}<"

          children.each do |child|
            @content << simple(child)
                  Severity: Major
                  Found in lib/spoon/compiler.rb - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                  @content << eol(child) unless child.equal? left.children.last
                    Severity: Major
                    Found in lib/spoon/compiler.rb - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                elsif @parent.parent != nil && @parent.parent.node.type == :class
            is_this = left.option :is_this
            name = simple(left.children.first)

            if is_this
                      Severity: Major
                      Found in lib/spoon/compiler.rb - About 45 mins to fix

                        Method compile has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                        Open

                            def compile
      imports = ""
      classes = ""
      import_calls = ""
      push_scope @compiler.name
                        Severity: Minor
                        Found in lib/spoon/compiler.rb - About 35 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                  @content << subtree(left)
          @content << " " unless @node.option :is_chain
          @content << operator
          @content << " " unless @node.option :is_chain
          @content << subtree(right)
                        Severity: Minor
                        Found in lib/spoon/compiler.rb and 1 other location - About 15 mins to fix
                        lib/spoon/compiler.rb on lines 293..297

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 26.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                    @content << scope_name(left)
            @content << " " unless @node.option :is_chain
            @content << operator
            @content << " " unless @node.option :is_chain
            @content << subtree(right)
                        Severity: Minor
                        Found in lib/spoon/compiler.rb and 1 other location - About 15 mins to fix
                        lib/spoon/compiler.rb on lines 300..304

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 26.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                              @compiler.static_scope.get.each do |key, value|
        if value
          result << "  static public var #{key}"
          result << " : #{value}" if value.is_a?(String)
          result << eol
                        Severity: Minor
                        Found in lib/spoon/compiler.rb and 1 other location - About 15 mins to fix
                        lib/spoon/compiler.rb on lines 118..122

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 26.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                              @compiler.instance_scope.get.each do |key, value|
        if value
          result << "  public var #{key}"
          result << " : #{value}" if value.is_a?(String)
          result << eol
                        Severity: Minor
                        Found in lib/spoon/compiler.rb and 1 other location - About 15 mins to fix
                        lib/spoon/compiler.rb on lines 110..114

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 26.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        There are no issues that match your filters.

                        Category
                        Status