Avoid assigning values to variables in if clauses and the like (line '136', column '13'). Open
public function formatUser(string $entity, $readable = null) : string
{
if ($readable) {
return "@$readable";
}- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
Avoid assigning values to variables in if clauses and the like (line '34', column '13'). Open
public function getUser(array $data)
{
if ($userId = $this->getUserId($data)) {
return $this->getUserById($userId);
}- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
Avoid assigning values to variables in if clauses and the like (line '150', column '13'). Open
public function formatChannel(string $entity, $readable = null) : string
{
if ($readable) {
return "#$readable";
}- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
Parameter $logger has undeclared type ?\Psr\Log\LoggerInterface Open
public function __construct(Client $slackClient, LoggerInterface $logger = null)- Exclude checks
Return type of getChannel() is undeclared type \Slack\Channel Open
public function getChannel(array $data) : Channel- Exclude checks
Checking instanceof against undeclared class \Slack\Channel Open
if ($channel instanceof Channel) {- Exclude checks