Sign upLogin

nopolabs/yabot

View on GitHub
Star
src/Plugin/MessageLogPlugin.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid assigning values to variables in if clauses and the like (line '34', column '13').
Open

    public function status(): string
    {
        if ($file = $this->yabot->getMessageLog()) {
            return "logging messages in $file";
        }
Severity: Minor
Found in src/Plugin/MessageLogPlugin.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Parameter $logger has undeclared type ?\Psr\Log\LoggerInterface
Open

    public function __construct(Yabot $yabot, LoggerInterface $logger = null)
Severity: Minor
Found in src/Plugin/MessageLogPlugin.php by phan

There must be one blank line after the namespace declaration
Open

namespace Nopolabs\Yabot\Plugin;
Severity: Minor
Found in src/Plugin/MessageLogPlugin.php by phpcodesniffer

Expected 1 newline at end of file; 0 found
Open

}
Severity: Minor
Found in src/Plugin/MessageLogPlugin.php by phpcodesniffer

There are no issues that match your filters.

Category
Status